Skip to contentSkip to conversation

doc: fix some statements for ice vector PMD

PATCH In review Qi Zhang 2 participants 3 messages Dec 16, 2020 – Dec 23, 2020

lore
Share & tools
lore

Qi Zhang

author
#0 lore raw

PATCH v2 1/1 doc: fix some statements for ice vector PMD

1. Add descriptions for how to select avx512 datapath.
2. Add explanation for "P" in ice.ini.

Fixes 7f85d5ebcfe1 ("net/ice: add AVX512 vector path")
Fixes 271cc8c5028a ("doc: update ice features list")

---

v2:
fix statement for force-max-simd-bitwidth which is an EAL argument but not devarg.

 doc/guides/nics/ice.rst | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
doc/guides/nics/ice.rst +4 -1
index a0887f129f..2a4439a63a 100644
@@ -211,9 +211,12 @@ are chosen based on 2 conditions.
 - ``CPU``
   On the X86 platform, the driver checks if the CPU supports AVX2.
   If it's supported, AVX2 paths will be chosen. If not, SSE is chosen.
+  If the CPU supports AVX512 and EAL argument ``force-max-simd-bitwidth``
+  is set to 512, AVX512 paths will be chosen.
 
 - ``Offload features``
-  The supported HW offload features are described in the document ice_vec.ini.
+  The supported HW offload features are described in the document ice.ini,
+  A value "P" means the offload feature is not supported by vector path.
   If any not supported features are used, ICE vector PMD is disabled and the
   normal paths are chosen.
 
Signature · 1 line
2.26.2
Acked-by on v2 1/1
#1 lore raw
Quoted 45 lines

-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Wednesday, December 16, 2020 8:22 AM
To: Rong, Leyi <[email protected]>
Cc: Yigit, Ferruh <[email protected]>; [email protected]; Zhang, Qi Z <[email protected]>; [email protected]
Subject: [PATCH v2] doc: fix some statements for ice vector PMD

1. Add descriptions for how to select avx512 datapath.
2. Add explanation for "P" in ice.ini.

Fixes 7f85d5ebcfe1 ("net/ice: add AVX512 vector path")
Fixes 271cc8c5028a ("doc: update ice features list")

---

v2:
fix statement for force-max-simd-bitwidth which is an EAL argument but not devarg.

 doc/guides/nics/ice.rst | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
doc/guides/nics/ice.rst index renamed from doc/guides/nics/ice.rst +0 -0

a0887f129f..2a4439a63a 100644

doc/guides/nics/ice.rst +4 -2
@@ -211,9 +211,12 @@ are chosen based on 2 conditions.
 - ``CPU``
   On the X86 platform, the driver checks if the CPU supports AVX2.
   If it's supported, AVX2 paths will be chosen. If not, SSE is chosen.
+  If the CPU supports AVX512 and EAL argument
+ ``force-max-simd-bitwidth``  is set to 512, AVX512 paths will be chosen.
 
 - ``Offload features``
-  The supported HW offload features are described in the document ice_vec.ini.
+  The supported HW offload features are described in the document
+ ice.ini,  A value "P" means the offload feature is not supported by vector path.
   If any not supported features are used, ICE vector PMD is disabled and the
   normal paths are chosen.
 
--
Quoted 1 line

2.26.2

Best Regards,
Leyi Rong

author Applied
#2 lore raw
Quoted 52 lines

-----Original Message-----
From: Rong, Leyi <[email protected]>
Sent: Thursday, December 17, 2020 10:13 AM
To: Zhang, Qi Z <[email protected]>
Cc: Yigit, Ferruh <[email protected]>; [email protected]; [email protected]
Subject: RE: [PATCH v2] doc: fix some statements for ice vector PMD

Quoted 30 lines

-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Wednesday, December 16, 2020 8:22 AM
To: Rong, Leyi <[email protected]>
Cc: Yigit, Ferruh <[email protected]>; [email protected]; Zhang, Qi Z <[email protected]>; [email protected]
Subject: [PATCH v2] doc: fix some statements for ice vector PMD

1. Add descriptions for how to select avx512 datapath.
2. Add explanation for "P" in ice.ini.

Fixes 7f85d5ebcfe1 ("net/ice: add AVX512 vector path")
Fixes 271cc8c5028a ("doc: update ice features list")

---

v2:
fix statement for force-max-simd-bitwidth which is an EAL argument but not devarg.

 doc/guides/nics/ice.rst | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
doc/guides/nics/ice.rst index renamed from doc/guides/nics/ice.rst +0 -0

a0887f129f..2a4439a63a 100644

doc/guides/nics/ice.rst are chosen based on 2 conditions. · line 216

Quoted 8 lines
doc/guides/nics/ice.rst +2 -1
@@ -211,9 +211,12 @@ are chosen based on 2 conditions.
 - ``CPU``
   On the X86 platform, the driver checks if the CPU supports AVX2.
   If it's supported, AVX2 paths will be chosen. If not, SSE is chosen.
+  If the CPU supports AVX512 and EAL argument
+ ``force-max-simd-bitwidth``  is set to 512, AVX512 paths will be chosen.
 
 - ``Offload features``
-  The supported HW offload features are described in the document

ice_vec.ini.

doc/guides/nics/ice.rst are chosen based on 2 conditions. · line 219

Quoted 2 lines
doc/guides/nics/ice.rst +2 -0
+  The supported HW offload features are described in the document
+ ice.ini,  A value "P" means the offload feature is not supported by vector

path.

Quoted 8 lines

doc/guides/nics/ice.rst are chosen based on 2 conditions. · line 220

Quoted 1 line
doc/guides/nics/ice.rst +0 -0
   If any not supported features are used, ICE vector PMD is disabled and

the

Quoted 4 lines
doc/guides/nics/ice.rst +0 -1
   normal paths are chosen.
 
--

2.26.2

Applied to dpdk-next-net-intel.

Thanks
Qi

Quoted 3 lines

Best Regards,
Leyi Rong