mm-thp-simplify-lru_add_page_tail.patch removed from -mm tree
The patch titled
Subject: mm/thp: simplify lru_add_page_tail()
has been removed from the -mm tree. Its filename was
mm-thp-simplify-lru_add_page_tail.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Alex Shi <[email protected]>
Subject: mm/thp: simplify lru_add_page_tail()
Simplify lru_add_page_tail(), there are actually only two cases possible:split_huge_page_to_list(), with list supplied and head isolated from lru by its caller; or split_huge_page(), with NULL list and head on lru - because when head is racily isolated from lru, the isolator's reference will stop the split from getting any further than its page_ref_freeze().
So decide between the two cases by "list", but add VM_WARN_ON()s to verify that they match our lru expectations.
---
mm/huge_memory.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-)
mm/huge_memory.c renamed from mm/huge_memory.c~mm-thp-simplify-lru_add_page_tail +6 -14
@@ -2367,24 +2367,16 @@ static void lru_add_page_tail(struct pagVM_BUG_ON_PAGE (PageLRU (tail), head);lockdep_assert_held (&lruvec_pgdat (lruvec)->lru_lock); -if (!list) -SetPageLRU (tail); - -if (likely (PageLRU (head))) -list_add_tail (&tail->lru, &head->lru); -else if (list) { +if (list) {/* page reclaim is reclaiming a huge page */ +VM_WARN_ON (PageLRU (head));get_page (tail);list_add_tail (&tail->lru, list); }else { -/* -* Head page has not yet been counted, as an hpage, -* so we must account for each subpage individually. -* -* Put tail on the list at the correct position -* so they all end up in order. -*/ -add_page_to_lru_list_tail (tail, lruvec,page_lru (tail)); +/* head is still on lru (and we have it frozen) */ +VM_WARN_ON (!PageLRU (head)); +SetPageLRU (tail); +list_add_tail (&tail->lru, &head->lru); } }
_
Patches currently in -mm which might be from [email protected] are
mm-vmscan-__isolate_lru_page_prepare-clean-up.patch fs-nilfs2-remove-some-unused-macros-to-tame-gcc.patch gcov-fix-kernel-doc-markup-issue.patch mm-memcg-bail-early-from-swap-accounting-if-memcg-disabled.patch mm-memcg-warning-on-memcg-after-readahead-page-charged.patch mm-memcontrol-rewrite-mem_cgroup_page_lruvec-fix.patch