mm-page_idle_get_page-does-not-need-lru_lock.patch removed from -mm tree
The patch titled
Subject: mm: page_idle_get_page() does not need lru_lock
has been removed from the -mm tree. Its filename was
mm-page_idle_get_page-does-not-need-lru_lock.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Hugh Dickins <[email protected]>
Subject: mm: page_idle_get_page() does not need lru_lock
It is necessary for page_idle_get_page() to recheck PageLRU() after get_page_unless_zero(), but holding lru_lock around that serves no useful purpose, and adds to lru_lock contention: delete it.
See https://lore.kernel.org/lkml/20150504031722.GA2768@blaptop for the discussion that led to lru_lock there; but __page_set_anon_rmap() now uses WRITE_ONCE(), and I see no other risk in page_idle_clear_pte_refs() using rmap_walk() (beyond the risk of racing PageAnon->PageKsm, mostly but not entirely prevented by page_count() check in ksm.c's write_protect_page():
that risk being shared with page_referenced() and not helped by lru_lock).
---
mm/page_idle.c | 4 ---- 1 file changed, 4 deletions(-)
mm/page_idle.c renamed from mm/page_idle.c~mm-page_idle_get_page-does-not-need-lru_lock +0 -4
@@ -32,19 +32,15 @@static struct page *page_idle_get_page (unsigned long pfn) {struct page *page =pfn_to_online_page (pfn); -pg_data_t *pgdat;if (!page || !PageLRU (page) || !get_page_unless_zero (page))return NULL ; - pgdat =page_pgdat (page); -spin_lock_irq (&pgdat->lru_lock);if (unlikely (!PageLRU (page))) {put_page (page); page =NULL ; } -spin_unlock_irq (&pgdat->lru_lock);return page; }
_
Patches currently in -mm which might be from [email protected] are