mm-compaction-do-page-isolation-first-in-compaction.patch removed from -mm tree
The patch titled
Subject: mm/compaction: do page isolation first in compaction
has been removed from the -mm tree. Its filename was
mm-compaction-do-page-isolation-first-in-compaction.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Alex Shi <[email protected]>
Subject: mm/compaction: do page isolation first in compaction
Currently, compaction would get the lru_lock and then do page isolation which works fine with pgdat->lru_lock, since any page isoltion would compete for the lru_lock. If we want to change to memcg lru_lock, we have to isolate the page before getting lru_lock, thus isoltion would block page's memcg change which relay on page isoltion too. Then we could safely use per memcg lru_lock later.
The new page isolation use previous introduced TestClearPageLRU() + pgdat lru locking which will be changed to memcg lru lock later.
Hugh Dickins <[email protected]> fixed following bugs in this patch's early version:
Fix lots of crashes under compaction load: isolate_migratepages_block() must clean up appropriately when rejecting a page, setting PageLRU again if it had been cleared; and a put_page() after get_page_unless_zero() cannot safely be done while holding locked_lruvec - it may turn out to be the final put_page(), which will take an lruvec lock when PageLRU.
And move __isolate_lru_page_prepare back after get_page_unless_zero to make trylock_page() safe: trylock_page() is not safe to use at this time:
its setting PG_locked can race with the page being freed or allocated ("Bad page"), and can also erase flags being set by one of those "sole owners" of a freshly allocated page who use non-atomic __SetPageFlag().
---
include/linux/swap.h | 2 - mm/compaction.c | 42 +++++++++++++++++++++++++++++++--------- mm/vmscan.c | 43 ++++++++++++++++++++--------------------- 3 files changed, 56 insertions(+), 31 deletions(-)
include/linux/swap.h renamed from include/linux/swap.h~mm-compaction-do-page-isolation-first-in-compaction +1 -1
@@ -356,7 +356,7 @@ extern void lru_cache_add_inactive_or_unextern unsigned long zone_reclaimable_pages (struct zone *zone);extern unsigned long try_to_free_pages (struct zonelist *zonelist,int order,gfp_t gfp_mask,nodemask_t *mask); -extern int __isolate_lru_page (struct page *page,isolate_mode_t mode); +extern int __isolate_lru_page_prepare (struct page *page,isolate_mode_t mode); extern unsigned long try_to_free_mem_cgroup_pages(struct mem_cgroup *memcg, unsigned long nr_pages, gfp_t gfp_mask,
mm/compaction.c renamed from mm/compaction.c~mm-compaction-do-page-isolation-first-in-compaction +33 -9
86 lines not on this page · raw message
mm/vmscan.c renamed from mm/vmscan.c~mm-compaction-do-page-isolation-first-in-compaction +22 -21
71 lines not on this page · raw message
_
Patches currently in -mm which might be from [email protected] are
mm-vmscan-__isolate_lru_page_prepare-clean-up.patch fs-nilfs2-remove-some-unused-macros-to-tame-gcc.patch gcov-fix-kernel-doc-markup-issue.patch mm-memcg-bail-early-from-swap-accounting-if-memcg-disabled.patch mm-memcg-warning-on-memcg-after-readahead-page-charged.patch mm-memcontrol-rewrite-mem_cgroup_page_lruvec-fix.patch