octeontx2-af: Fix undetected unmap PF error check
Subsystems (4)
PATCH 1/1 octeontx2-af: Fix undetected unmap PF error check
From: Colin Ian King <[email protected]>
Currently the check for an unmap PF error is always going to be false because intr_val is a 32 bit int and is being bit-mask checked against 1ULL << 32. Fix this by making intr_val a u64 to match the type at it is copied from, namely npa_event_context->npa_af_rvu_ge.
Addresses-Coverity: ("Operands don't affect result")
Fixes f1168d1e207c ("octeontx2-af: Add devlink health reporters for NPA")
Signed-off-by Colin Ian King <[email protected]>
--- drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c +2 -1
@@ -275,7 +275,8 @@ static int rvu_npa_report_show(struct devlink_fmsg *fmsg, void *ctx, enum npa_af_rvu_health health_reporter) {struct rvu_npa_event_ctx *npa_event_context; -unsigned int intr_val, alloc_dis, free_dis; +unsigned int alloc_dis, free_dis; +u64 intr_val;int err; npa_event_context = ctx;
Signature · 1 line
2.29.2