Skip to contentSkip to conversation

hwmon: SENSORS_SBTSI should depend on X86

PATCH Guenter Roeck 3 participants 4 messages Dec 16, 2020 – Dec 17, 2020 Hardware monitoring

lore
Share & tools
lore

Guenter Roeck

author maintainer
#0 lore raw
Quoted 7 lines · Geert Uytterhoeven

The AMD SB Temperature Sensor Interface (SB-TSI) is only present on AMD X86 SoCs. Hence add a dependency on X86, to prevent asking the user about this driver when configuring a kernel without AMD X86 platform support.

Fixes e7bb1a2ab8c4b156 ("hwmon: (sbtsi) Add basic support for SB-TSI sensors")

Makes sense. Applied.

Thanks,
Guenter

Quoted 19 lines
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/hwmon/Kconfig +1 -0
index 1ecf697d8d99b70c..63d28f98108d4bb5 100644
@@ -1536,6 +1536,7 @@ config SENSORS_SL28CPLD
 config SENSORS_SBTSI
 	tristate "Emulated SB-TSI temperature sensor"
 	depends on I2C
+	depends on X86 || COMPILE_TEST
 	help
 	  If you say yes here you get support for emulated temperature
 	  sensors on AMD SoCs with SB-TSI interface connected to a BMC device.
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines · Guenter Roeck
Quoted 4 lines · Geert Uytterhoeven

The AMD SB Temperature Sensor Interface (SB-TSI) is only present on AMD X86 SoCs. Hence add a dependency on X86, to prevent asking the user about this driver when configuring a kernel without AMD X86 platform support.

Sorry, I think there is some confusion. AMD SoC is a 'remote sensor', or the client, whereas the device using the SB-TSI hwmon driver is the master.
In industry, a typical scenario is ARM-based Board Management Controllers (BMCs) using SB-TSI to monitor the host CPU temperature.

Quoted 28 lines
Quoted 3 lines
Fixes e7bb1a2ab8c4b156 ("hwmon: (sbtsi) Add basic support for SB-TSI sensors")

Makes sense. Applied.

Thanks,
Guenter

Quoted 19 lines
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/hwmon/Kconfig +1 -1
index 1ecf697d8d99b70c..63d28f98108d4bb5 100644
@@ -1536,6 +1536,7 @@ config SENSORS_SL28CPLD
 config SENSORS_SBTSI
      tristate "Emulated SB-TSI temperature sensor"
      depends on I2C
+     depends on X86 || COMPILE_TEST
      help
        If you say yes here you get support for emulated temperature
        sensors on AMD SoCs with SB-TSI interface connected to a BMC device.
--

2.25.1

Signature · 2 lines
Regards,
Kun
author maintainer
#2 lore raw
Quoted 8 lines · Kun Yi
Quoted 6 lines · Guenter Roeck
Quoted 4 lines · Geert Uytterhoeven

The AMD SB Temperature Sensor Interface (SB-TSI) is only present on AMD X86 SoCs. Hence add a dependency on X86, to prevent asking the user about this driver when configuring a kernel without AMD X86 platform support.

Quoted 6 lines

Sorry, I think there is some confusion. AMD SoC is a 'remote sensor', or the client, whereas the device using the SB-TSI hwmon driver is the master.
In industry, a typical scenario is ARM-based Board Management Controllers (BMCs) using SB-TSI to monitor the host CPU temperature.

Ah, good point. I'll drop this patch.

Thanks,
Guenter

#3 lore raw

Hi Kun, Günter,

Quoted 9 lines · Guenter Roeck
Quoted 8 lines · Kun Yi
Quoted 6 lines · Guenter Roeck
Quoted 4 lines · Geert Uytterhoeven

The AMD SB Temperature Sensor Interface (SB-TSI) is only present on AMD X86 SoCs. Hence add a dependency on X86, to prevent asking the user about this driver when configuring a kernel without AMD X86 platform support.

Quoted 5 lines
Quoted 5 lines

Sorry, I think there is some confusion. AMD SoC is a 'remote sensor', or the client, whereas the device using the SB-TSI hwmon driver is the master.
In industry, a typical scenario is ARM-based Board Management Controllers (BMCs) using SB-TSI to monitor the host CPU temperature.

Thanks for the explanation!

Quoted 1 line

Ah, good point. I'll drop this patch.

Agreed.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds