erofs-utils: fuse: disable backtrace if unsupported
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 erofs-utils: fuse: disable backtrace if unsupported
From: Gao Xiang <[email protected]>
Let's enable backtrace conditionally since it's a GNU extension.
Fixes 5e35b75ad499 ("erofs-utils: introduce fuse implementation")
Signed-off-by Gao Xiang <[email protected]>
--- configure.ac | 3 ++- fuse/main.c | 8 ++++++-- 2 files changed, 8 insertions(+), 3 deletions(-)
configure.ac +2 -1
@@ -96,6 +96,7 @@ AC_ARG_VAR([LZ4_LIBS], [linker flags for lz4]) # Checks for header files. AC_CHECK_HEADERS(m4_flatten([ dirent.h + execinfo.h fcntl.h getopt.h inttypes.h
@@ -147,7 +148,7 @@ AC_CHECK_DECL(lseek64,[AC_DEFINE(HAVE_LSEEK64_PROTOTYPE, 1, #include <unistd.h>]) # Checks for library functions. -AC_CHECK_FUNCS([fallocate gettimeofday memset realpath strdup strerror strrchr strtoull]) +AC_CHECK_FUNCS([backtrace fallocate gettimeofday memset realpath strdup strerror strrchr strtoull]) # Configure libuuid AS_IF([test "x$with_uuid" != "xno"], [
fuse/main.c +6 -2
@@ -6,7 +6,6 @@*/ #include <stdlib.h> #include <string.h> -#include <execinfo.h> #include <signal.h> #include <libgen.h> #include <fuse.h>
@@ -168,6 +167,9 @@ static int optional_opt_func(void *data, const char *arg, int key,return 1 ; } +#if defined(HAVE_EXECINFO_H ) && defined(HAVE_BACKTRACE ) +#include <execinfo.h> +static void signal_handle_sigsegv (int signal) {void *array[10 ];
@@ -187,7 +189,7 @@ static void signal_handle_sigsegv(int signal)erofs_dump ("========================================\n" ); abort(); } - +#endif int main (int argc,char *argv[]) {
@@ -197,11 +199,13 @@ int main(int argc, char *argv[])erofs_init_configure ();fprintf (stderr,"%s %s\n" ,basename (argv[0 ]), cfg.c_version); +#if defined(HAVE_EXECINFO_H ) && defined(HAVE_BACKTRACE )if (signal (SIGSEGV , signal_handle_sigsegv) ==SIG_ERR ) {fprintf (stderr,"failed to initialize signals\n" ); ret = -errno; goto err; } +#endif /* parse options */ ret =fuse_opt_parse (&args, &fusecfg, option_spec, optional_opt_func);
Signature · 1 line
2.24.0
Quoted 11 lines · Gao Xiang via Linux-erofs
From: Gao Xiang <[email protected]>
Let's enable backtrace conditionally since it's a GNU extension.
Fixes 5e35b75ad499 ("erofs-utils: introduce fuse implementation")Signed-off-by Gao Xiang <[email protected]>--- configure.ac | 3 ++- fuse/main.c | 8 ++++++-- 2 files changed, 8 insertions(+), 3 deletions(-)
It looks good
Reviewed-by Li Guifu <[email protected]>
Thanks,