ltp: fix rpc build error
PATCH 1/1 ltp: fix rpc build error
Add support to tirpc tests build.
Export incdir and libdir to have the right path.
--- meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-extended/ltp/ltp_20200930.bb +3 -3
@@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "\ file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \ " -DEPENDS = "attr libaio libcap acl openssl zip-native" +DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc" DEPENDS_append_libc-musl = " fts " EXTRA_OEMAKE_append_libc-musl = " LIBC=musl " EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "
@@ -44,12 +44,12 @@ TARGET_CC_ARCH += "${LDFLAGS}" export prefix = "/opt/${PN}" export exec_prefix = "/opt/${PN}" +export libdir = "/usr/lib" +export incdir = "/usr/include" PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl," EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4" EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite " -# ltp network/rpc test cases ftbfs when libtirpc is found -EXTRA_OECONF += " --without-tirpc " do_install(){ install -d ${D}${prefix}/
Signature · 1 line
2.17.1
Quoted 10 lines · Kory Maincent
Signed-off-by Kory Maincent <[email protected]>--- meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)meta/recipes-extended/ltp/ltp_20200930.bb +0
-0
meta/recipes-extended/ltp/ltp_20200930.bb LIC_FILES_CHKSUM = "\ · line 17
Quoted 5 lines
meta/recipes-extended/ltp/ltp_20200930.bb +1
-1@@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "\ file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \ " -DEPENDS = "attr libaio libcap acl openssl zip-native" +DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc"
Can we have that as a PACKAGECONFIG entry, please? otherwise I think it will change the behavior of the existing setups. Also the dependency has a PROVIDES = "virtual/librpc", so I think depending on virtual/librpc should be the safest way
meta/recipes-extended/ltp/ltp_20200930.bb TARGET_CC_ARCH += "${LDFLAGS}" · line 48
Quoted 9 lines
meta/recipes-extended/ltp/ltp_20200930.bb +2
-0DEPENDS_append_libc-musl = " fts " EXTRA_OEMAKE_append_libc-musl = " LIBC=musl " EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "@@ -44,12 +44,12 @@ TARGET_CC_ARCH += "${LDFLAGS}" export prefix = "/opt/${PN}" export exec_prefix = "/opt/${PN}" +export libdir = "/usr/lib" +export incdir = "/usr/include"
Those should be ${libdir} and ${incdir} if I'm not mistaken
meta/recipes-extended/ltp/ltp_20200930.bb TARGET_CC_ARCH += "${LDFLAGS}" · line 52
Quoted 8 lines
meta/recipes-extended/ltp/ltp_20200930.bb +0
-2PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl," EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4" EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite " -# ltp network/rpc test cases ftbfs when libtirpc is found -EXTRA_OECONF += " --without-tirpc "
Should be part of a PACKAGECONFIG entry, with --without-tirpc being the default
Quoted 8 lines
meta/recipes-extended/ltp/ltp_20200930.bb +0
-0do_install(){ install -d ${D}${prefix}/
Hello Konrad,
Quoted 14 lines · On Thu, 17 Dec 2020 11:03:39 +0100 Konrad Weihmann <[email protected]>…
Quoted 13 lines · Kory Maincent
Signed-off-by Kory Maincent <[email protected]>--- meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)(quoted diff) +0
-0b/meta/recipes-extended/ltp/ltp_20200930.bb index
7acf15b360..9b17d68f67100644 --- a/meta/recipes-extended/ltp/ltp_20200930.bb
+++ b/meta/recipes-extended/ltp/ltp_20200930.bb(quoted diff) +0
-0@@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "\ file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f\ "
Quoted 5 lines
meta/recipes-extended/ltp/ltp_20200930.bb LIC_FILES_CHKSUM = "\ · line 17
Quoted 2 lines
meta/recipes-extended/ltp/ltp_20200930.bb +1
-1-DEPENDS = "attr libaio libcap acl openssl zip-native" +DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc"Can we have that as a PACKAGECONFIG entry, please? otherwise I think it will change the behavior of the existing setups.
I assumed the tirpc was disable because they did not manage to build with it "# ltp network/rpc test cases ftbfs when libtirpc is found". But if you prefer I can add it to PACKAGECONFIG.
Quoted 2 lines
Also the dependency has a
PROVIDES = "virtual/librpc", so I think depending on virtual/librpc should be the safest way
Ok
Quoted 6 lines
Quoted 6 lines
DEPENDS_append_libc-musl = " fts "
EXTRA_OEMAKE_append_libc-musl = " LIBC=musl "
EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "(quoted diff) +0
-0@@ -44,12 +44,12 @@ TARGET_CC_ARCH += "${LDFLAGS}"
Quoted 6 lines
meta/recipes-extended/ltp/ltp_20200930.bb TARGET_CC_ARCH += "${LDFLAGS}" · line 48
Quoted 4 lines
meta/recipes-extended/ltp/ltp_20200930.bb +2
-0export prefix = "/opt/${PN}" export exec_prefix = "/opt/${PN}" +export libdir = "/usr/lib" +export incdir = "/usr/include"Those should be ${libdir} and ${incdir} if I'm not mistaken
The exporting of ${prefix} change the value of ${libdir} and ${incdir} therefore I set them up again. If I don't set it, pkgconfig can not find libtirpc.
Quoted 5 lines
Quoted 3 lines
meta/recipes-extended/ltp/ltp_20200930.bb +0
-0PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"
Quoted 7 lines
meta/recipes-extended/ltp/ltp_20200930.bb TARGET_CC_ARCH += "${LDFLAGS}" · line 52
Quoted 4 lines
meta/recipes-extended/ltp/ltp_20200930.bb +0
-2EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4" EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite " -# ltp network/rpc test cases ftbfs when libtirpc is found -EXTRA_OECONF += " --without-tirpc "Should be part of a PACKAGECONFIG entry, with
--without-tirpcbeing the default
Ok,
Köry
Quoted 47 lines · Köry Maincent
Hello Konrad,
Quoted 14 lines · On Thu, 17 Dec 2020 11:03:39 +0100 Konrad Weihmann <[email protected]>…
Quoted 13 lines · Kory Maincent
Signed-off-by Kory Maincent <[email protected]>--- meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)(quoted diff) +0
-0b/meta/recipes-extended/ltp/ltp_20200930.bb index
7acf15b360..9b17d68f67100644 --- a/meta/recipes-extended/ltp/ltp_20200930.bb
+++ b/meta/recipes-extended/ltp/ltp_20200930.bb(quoted diff) +0
-0@@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "\ file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f\ "
Quoted 5 lines
meta/recipes-extended/ltp/ltp_20200930.bb LIC_FILES_CHKSUM = "\ · line 17
Quoted 2 lines
meta/recipes-extended/ltp/ltp_20200930.bb +1
-1-DEPENDS = "attr libaio libcap acl openssl zip-native" +DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc"Can we have that as a PACKAGECONFIG entry, please? otherwise I think it will change the behavior of the existing setups.
I assumed the tirpc was disable because they did not manage to build with it "# ltp network/rpc test cases ftbfs when libtirpc is found". But if you prefer I can add it to PACKAGECONFIG.
Quoted 2 lines
Also the dependency has a
PROVIDES = "virtual/librpc", so I think depending on virtual/librpc should be the safest wayOk
Quoted 6 lines
Quoted 6 lines
DEPENDS_append_libc-musl = " fts "
EXTRA_OEMAKE_append_libc-musl = " LIBC=musl "
EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "(quoted diff) +0
-0@@ -44,12 +44,12 @@ TARGET_CC_ARCH += "${LDFLAGS}"Quoted 6 lines
meta/recipes-extended/ltp/ltp_20200930.bb TARGET_CC_ARCH += "${LDFLAGS}" · line 48
Quoted 4 lines
meta/recipes-extended/ltp/ltp_20200930.bb +2
-0export prefix = "/opt/${PN}" export exec_prefix = "/opt/${PN}" +export libdir = "/usr/lib" +export incdir = "/usr/include"Those should be ${libdir} and ${incdir} if I'm not mistaken
Quoted 4 lines
The exporting of ${prefix} change the value of ${libdir} and ${incdir} therefore I set them up again. If I don't set it, pkgconfig can not find libtirpc.
I see, then please just export ${libdir} and ${incdir} before the prefix export and it should be fine
Quoted 20 lines
Quoted 5 lines
Quoted 3 lines
meta/recipes-extended/ltp/ltp_20200930.bb +0
-0PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"Quoted 7 lines
meta/recipes-extended/ltp/ltp_20200930.bb TARGET_CC_ARCH += "${LDFLAGS}" · line 52
Quoted 4 lines
meta/recipes-extended/ltp/ltp_20200930.bb +0
-2EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4" EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite " -# ltp network/rpc test cases ftbfs when libtirpc is found -EXTRA_OECONF += " --without-tirpc "Should be part of a PACKAGECONFIG entry, with
--without-tirpcbeing the defaultOk,
Köry
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 48 lines · Konrad Weihmann
Quoted 47 lines · Köry Maincent
Hello Konrad,
Quoted 12 lines · On Thu, 17 Dec 2020 11:03:39 +0100 Konrad Weihmann <[email protected]>…
Quoted 11 lines · Kory Maincent
Signed-off-by Kory Maincent <[email protected]>---
meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---1 file changed, 3 insertions(+), 3 deletions(-)(quoted diff) +0
-0b/meta/recipes-extended/ltp/ltp_20200930.bb index
7acf15b360..9b17d68f67100644 --- a/meta/recipes-extended/ltp/ltp_20200930.bb
+++ b/meta/recipes-extended/ltp/ltp_20200930.bb(quoted diff) +0
-0@@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "\Quoted 8 lines
meta/recipes-extended/ltp/ltp_20200930.bb LIC_FILES_CHKSUM = "\ · line 17
Quoted 5 lines
file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f
\ "
meta/recipes-extended/ltp/ltp_20200930.bb +1
-1-DEPENDS = "attr libaio libcap acl openssl zip-native" +DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc"Can we have that as a PACKAGECONFIG entry, please? otherwise I think it will change the behavior of the existing setups.
I assumed the tirpc was disable because they did not manage to build with it "# ltp network/rpc test cases ftbfs when libtirpc is found". But if you prefer I can add it to PACKAGECONFIG.
Quoted 2 lines
Also the dependency has a
PROVIDES = "virtual/librpc", so I think depending on virtual/librpc should be the safest wayOk
Quoted 11 lines
meta/recipes-extended/ltp/ltp_20200930.bb TARGET_CC_ARCH += "${LDFLAGS}" · line 48
Quoted 9 lines
DEPENDS_append_libc-musl = " fts "
EXTRA_OEMAKE_append_libc-musl = " LIBC=musl "
EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "(quoted diff) +0
-0@@ -44,12 +44,12 @@ TARGET_CC_ARCH += "${LDFLAGS}"export prefix = "
/opt/${PN}"
exportexec_prefix= "/opt/${PN}"meta/recipes-extended/ltp/ltp_20200930.bb +2
-0+export libdir = "/usr/lib" +export incdir = "/usr/include"Those should be ${libdir} and ${incdir} if I'm not mistaken
Quoted 5 lines
Quoted 4 lines
The exporting of ${prefix} change the value of ${libdir} and ${incdir} therefore I set them up again. If I don't set it, pkgconfig can not find libtirpc.
I see, then please just export ${libdir} and ${incdir} before the prefix export and it should be fine
for instance that here
export libdir := "${exec_prefix}/${baselib}"
export incdir := "${exec_prefix}/include"
export prefix = "/opt/${PN}"
worked for me
Quoted 24 lines
Quoted 20 lines
Quoted 4 lines
Quoted 2 lines
PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"
Quoted 8 lines
meta/recipes-extended/ltp/ltp_20200930.bb TARGET_CC_ARCH += "${LDFLAGS}" · line 52
Quoted 5 lines
EXTRA_AUTORECONF+= "-I ${S}/testcases/realtime/m4"EXTRA_OECONF= " --with-realtime-testsuite --with-open-posix-testsuite "meta/recipes-extended/ltp/ltp_20200930.bb +0
-2-# ltp network/rpc test cases ftbfs when libtirpc is found -EXTRA_OECONF += " --without-tirpc "Should be part of a PACKAGECONFIG entry, with
--without-tirpcbeing the defaultOk,
Köry