Skip to contentSkip to conversation

cma_heap: fix implicit function declaration

PATCH In review [email protected] 2 participants 2 messages Dec 17, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cma_heap: fix implicit function declaration

From: siyanteng <[email protected]>

When building cma_heap the following error shows up:

drivers/dma-buf/heaps/cma_heap.c:195:10: error: implicit declaration of function 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]

195 |  vaddr = vmap(buffer->pages, buffer->pagecount, VM_MAP, PAGE_KERNEL);
    |          ^~~~
    |          kmap

Use this include: linux-next/include/linux/vmalloc.h

---
 drivers/dma-buf/heaps/cma_heap.c | 1 +
 1 file changed, 1 insertion(+)
drivers/dma-buf/heaps/cma_heap.c +1 -0
index 5e7c3436310c..3c4e34301172 100644
@@ -20,6 +20,7 @@
 #include <linux/module.h>
 #include <linux/scatterlist.h>
 #include <linux/slab.h>
+#include <linux/vmalloc.h>
 
 
 struct cma_heap {
Signature · 1 line
2.27.0
#1 lore raw
Quoted 5 lines · On Thu, Dec 17, 2020 at 4:31 AM <[email protected]> wrote:

From: siyanteng <[email protected]>

When building cma_heap the following error shows up:

Quoted 8 lines

drivers/dma-buf/heaps/cma_heap.c:195:10: error: implicit declaration of function 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]

195 |  vaddr = vmap(buffer->pages, buffer->pagecount, VM_MAP, PAGE_KERNEL);
    |          ^~~~
    |          kmap

Use this include: linux-next/include/linux/vmalloc.h

Thanks for submitting this! My apologies for the trouble!

We already have a similar patch queued here:
https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-next-fixes&id=8075c3005e4b1efa12dbbf6e84bc412a713de92c
so hopefully that will land upstream soon.

thanks again!
-john
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel