Skip to contentSkip to conversation

libsemanage: Free contents of modkey in semanage_direct_remove

PATCH In review Jakub Hrozek 2 participants 2 messages Dec 17, 2020 – Dec 30, 2020 SELinux security module

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libsemanage: Free contents of modkey in semanage_direct_remove

semanage_direct_remove allocates struct semanage_module_key_t on stack, then calls semanage_module_key_set_name which allocates modkey->name on heap, but modkey->name wasn't free()-d anywhere, creating a small leak.

---
 libsemanage/src/direct_api.c | 1 +
 1 file changed, 1 insertion(+)
libsemanage/src/direct_api.c +1 -0
index d2b91fb2..9a4e7938 100644
@@ -1951,6 +1951,7 @@ static int semanage_direct_remove(semanage_handle_t * sh, char *module_name)
 	status = semanage_direct_remove_key(sh, &modkey);
 
 cleanup:
+	semanage_module_key_destroy(sh, &modkey);
 	return status;
 }
 
Signature · 1 line
2.26.2
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Jakub Hrozek

semanage_direct_remove allocates struct semanage_module_key_t on stack, then calls semanage_module_key_set_name which allocates modkey->name on heap, but modkey->name wasn't free()-d anywhere, creating a small leak.

Thanks for your patch!

I merged it directly.
Nicolas

Quoted 19 lines
---
 libsemanage/src/direct_api.c | 1 +
 1 file changed, 1 insertion(+)
libsemanage/src/direct_api.c +1 -1
index d2b91fb2..9a4e7938 100644
@@ -1951,6 +1951,7 @@ static int semanage_direct_remove(semanage_handle_t * sh, char *module_name)
        status = semanage_direct_remove_key(sh, &modkey);
 
 cleanup:
+       semanage_module_key_destroy(sh, &modkey);
        return status;
 }
 
--

2.26.2