libsemanage: Free contents of modkey in semanage_direct_remove
PATCH 1/1 libsemanage: Free contents of modkey in semanage_direct_remove
semanage_direct_remove allocates struct semanage_module_key_t on stack, then calls semanage_module_key_set_name which allocates modkey->name on heap, but modkey->name wasn't free()-d anywhere, creating a small leak.
Signed-off-by Jakub Hrozek <[email protected]>
--- libsemanage/src/direct_api.c | 1 + 1 file changed, 1 insertion(+)
libsemanage/src/direct_api.c +1 -0
@@ -1951,6 +1951,7 @@ static int semanage_direct_remove(semanage_handle_t * sh, char *module_name) status =semanage_direct_remove_key (sh, &modkey); cleanup: +semanage_module_key_destroy (sh, &modkey);return status; }
Signature · 1 line
2.26.2
Quoted 7 lines · Jakub Hrozek
semanage_direct_removeallocates structsemanage_module_key_ton stack, then callssemanage_module_key_set_namewhich allocatesmodkey->nameon heap, butmodkey->namewasn't free()-d anywhere, creating a small leak.Signed-off-by Jakub Hrozek <[email protected]>
Thanks for your patch!
Acked-by Nicolas Iooss <[email protected]>
I merged it directly.
Nicolas
Quoted 19 lines
--- libsemanage/src/direct_api.c | 1 + 1 file changed, 1 insertion(+)libsemanage/src/direct_api.c +1
-1@@ -1951,6 +1951,7 @@ static int semanage_direct_remove(semanage_handle_t * sh, char *module_name) status =semanage_direct_remove_key (sh, &modkey); cleanup: +semanage_module_key_destroy (sh, &modkey);return status; } --2.26.2