Skip to contentSkip to conversation

iio: adc: stm32-dfsdm: Remove redundant null check before clk_disable_unprepare

PATCH In review Xu Wang 2 participants 2 messages Dec 18, 2020 – Dec 30, 2020

Subsystems (2)
lore
Share & tools
lore

Xu Wang

author
#0 lore raw

PATCH 1/1 iio: adc: stm32-dfsdm: Remove redundant null check before clk_disable_unprepare

ecause clk_disable_unprepare() already checked NULL clock parameter, so the additional check is unnecessary, just remove it.

---
 drivers/iio/adc/stm32-dfsdm-core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/adc/stm32-dfsdm-core.c +1 -2
index 42a7377704a4..bb925a11c8ae 100644
@@ -117,8 +117,7 @@ static void stm32_dfsdm_clk_disable_unprepare(struct stm32_dfsdm *dfsdm)
 {
 	struct dfsdm_priv *priv = to_stm32_dfsdm_priv(dfsdm);
 
-	if (priv->aclk)
-		clk_disable_unprepare(priv->aclk);
+	clk_disable_unprepare(priv->aclk);
 	clk_disable_unprepare(priv->clk);
 }
 
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 2 lines · On Fri, 18 Dec 2020 09:41:45 +0000 Xu Wang <[email protected]> wrote:

ecause clk_disable_unprepare() already checked NULL clock parameter, so the additional check is unnecessary, just remove it.

Please resend, making sure to cc [email protected]

Thanks,

Jonathan

Quoted 20 lines
---
 drivers/iio/adc/stm32-dfsdm-core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/adc/stm32-dfsdm-core.c +1 -2
index 42a7377704a4..bb925a11c8ae 100644
@@ -117,8 +117,7 @@ static void stm32_dfsdm_clk_disable_unprepare(struct stm32_dfsdm *dfsdm)
 {
 	struct dfsdm_priv *priv = to_stm32_dfsdm_priv(dfsdm);
 
-	if (priv->aclk)
-		clk_disable_unprepare(priv->aclk);
+	clk_disable_unprepare(priv->aclk);
 	clk_disable_unprepare(priv->clk);
 }