Skip to contentSkip to conversation

xen/Kconfig: Correct the NR_CPUS description

PATCH In review Andrew Cooper 2 participants 3 messages Dec 18, 2020 – Dec 21, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/Kconfig: Correct the NR_CPUS description

The description "physical CPUs" is especially wrong, as it implies the number of sockets, which tops out at 8 on all but the very biggest servers.

NR_CPUS is the number of logical entities the scheduler can use.

---
CC: Jan Beulich <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Wei Liu <[email protected]>
CC: Stefano Stabellini <[email protected]>
CC: Julien Grall <[email protected]>
CC: Volodymyr Babchuk <[email protected]>
CC: [email protected]

---
 xen/arch/Kconfig | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
xen/arch/Kconfig +9 -3
index 1954d1c5c1..d144d4c8d3 100644
@@ -1,11 +1,17 @@
 
 config NR_CPUS
-	int "Maximum number of physical CPUs"
+	int "Maximum number of CPUs"
 	range 1 4095
 	default "256" if X86
 	default "8" if ARM && RCAR3
 	default "4" if ARM && QEMU
 	default "4" if ARM && MPSOC
 	default "128" if ARM
-	---help---
-	  Specifies the maximum number of physical CPUs which Xen will support.
+	help
+	  Controls the build-time size of various arrays and bitmaps
+	  associated with multiple-cpu management.  It is the upper bound of
+	  the number of logical entities the scheduler can run code on.
+
+	  For CPU cores which support Simultaneous Multi-Threading or similar
+	  technologies, this the number of logical threads which Xen will
+	  support.
Signature · 1 line
2.11.0
#2 lore raw
Quoted 8 lines · Jan Beulich
Quoted 6 lines · Andrew Cooper

The description "physical CPUs" is especially wrong, as it implies the number of sockets, which tops out at 8 on all but the very biggest servers.

NR_CPUS is the number of logical entities the scheduler can use.

Reported-by [email protected]

This wasn't on xen-devel, was it?

No.  It was on IRC, hence the rather late patch.

Quoted 3 lines
Quoted 2 lines

Thanks.

~Andrew