ltp-pan: Use long long int to print time_t
PATCH 1/1 ltp-pan: Use long long int to print time_t
Some newer 32bit architectures ( e.g. riscv32 ) uses 64bit time_t so using %ld is not sufficient to print time_t, this also fixes a crash in ltp-pan on riscv32
Signed-off-by Khem Raj <[email protected]>
--- pan/ltp-pan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pan/ltp-pan.c +2 -2
@@ -1389,8 +1389,8 @@ static void write_test_start(struct tag_pgrp *running, int no_kmsg)if (!strcmp (reporttype,"rts" )) {printf - ("%s\ntag=%s stime=%ld\ncmdline=\"%s\"\ncontacts=\"%s\"\nanalysis=%s\n%s\n" , -"<<<test_start>>>" , running->cmd->name, running->mystime, + ("%s\ntag=%s stime=%lld\ncmdline=\"%s\"\ncontacts=\"%s\"\nanalysis=%s\n%s\n" , +"<<<test_start>>>" , running->cmd->name, (long long )running->mystime, running->cmd->cmdline,"" ,"exit" ,"<<<test_output>>>" ); }fflush (stdout);
Signature · 1 line
2.29.2
PATCH 1/1 ltp-pan: Use long long int to print time_t
Hi Khem,
Quoted 5 lines
Some newer 32bit architectures ( e.g. riscv32 ) uses 64bit
time_tso using %ld is not sufficient to printtime_t, this also fixes a crash in ltp-pan on riscv32Signed-off-by Khem Raj <[email protected]>
Reviewed-by Petr Vorel <[email protected]>
LGTM, thank you!
Kind regards,
Petr
Quoted 19 lines
--- pan/ltp-pan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)pan/ltp-pan.c +2
-2@@ -1389,8 +1389,8 @@ static void write_test_start(struct tag_pgrp *running, int no_kmsg)if (!strcmp (reporttype,"rts" )) {printf - ("%s\ntag=%s stime=%ld\ncmdline=\"%s\"\ncontacts=\"%s\"\nanalysis=%s\n%s\n" , -"<<<test_start>>>" , running->cmd->name, running->mystime, + ("%s\ntag=%s stime=%lld\ncmdline=\"%s\"\ncontacts=\"%s\"\nanalysis=%s\n%s\n" , +"<<<test_start>>>" , running->cmd->name, (long long )running->mystime, running->cmd->cmdline,"" ,"exit" ,"<<<test_output>>>" ); }fflush (stdout);
Petr Vorel
AppliedPATCH 1/1 ltp-pan: Use long long int to print time_t
Hi Khem,
Quoted 3 lines
Quoted 3 lines
Some newer 32bit architectures ( e.g. riscv32 ) uses 64bit
time_tso using %ld is not sufficient to printtime_t, this also fixes a crash in ltp-pan on riscv32
Merged, thanks!
Kind regards,
Petr