x86/resctrl: add printf attribute to log function
Subsystems (2)
PATCH 1/1 x86/resctrl: add printf attribute to log function
From: Tom Rix <[email protected]>
Attributing the function allows the compiler to more thoroughly check the use of the function with -Wformat and similar flags.
--- arch/x86/kernel/cpu/resctrl/internal.h | 1 + 1 file changed, 1 insertion(+)
arch/x86/kernel/cpu/resctrl/internal.h +1 -0
@@ -572,6 +572,7 @@ union cpuid_0x10_x_edx {void rdt_last_cmd_clear (void );void rdt_last_cmd_puts (const char *s); +__printf(1, 2)void rdt_last_cmd_printf (const char *fmt, ...);void rdt_ctrl_update (void *arg);
Signature · 1 line
2.27.0
Hi Tom,
Quoted 16 lines · On 12/21/2020 8:00 AM, [email protected] wrote:
From: Tom Rix <[email protected]>
Attributing the function allows the compiler to more thoroughly check the use of the function with -Wformat and similar flags.
Signed-off-by Tom Rix <[email protected]>--- arch/x86/kernel/cpu/resctrl/internal.h | 1 + 1 file changed, 1 insertion(+)arch/x86/kernel/cpu/resctrl/internal.h +0
-0
arch/x86/kernel/cpu/resctrl/internal.h union cpuid_0x10_x_edx { · line 578
Quoted 7 lines
arch/x86/kernel/cpu/resctrl/internal.h +1
-0@@ -572,6 +572,7 @@ union cpuid_0x10_x_edx {void rdt_last_cmd_clear (void );void rdt_last_cmd_puts (const char *s); +__printf(1, 2)void rdt_last_cmd_printf (const char *fmt, ...);void rdt_ctrl_update (void *arg);
This is a valuable addition, thank you.
Reinette
[tip: x86/cache] x86/resctrl: Add printf attribute to log function
In reply to [email protected]The following commit has been merged into the x86/cache branch of tip:
The following commit has been merged into the x86/cache branch of tip:
Commit-ID: 91031e096e1fa0216027bfb7fdca931225aebbf0 Gitweb: https://git.kernel.org/tip/91031e096e1fa0216027bfb7fdca931225aebbf0 Author: Tom Rix <[email protected]> AuthorDate: Mon, 21 Dec 2020 08:00:09 -08:00 Committer: Borislav Petkov <[email protected]> CommitterDate: Fri, 08 Jan 2021 08:55:02 +01:00
x86/resctrl: Add printf attribute to log function
Mark the function with the __printf attribute to allow the compiler to more thoroughly typecheck its arguments against a format string with -Wformat and similar flags.
[ bp: Massage commit message. ]
--- arch/x86/kernel/cpu/resctrl/internal.h | 1 + 1 file changed, 1 insertion(+)
arch/x86/kernel/cpu/resctrl/internal.h +1 -0
@@ -572,6 +572,7 @@ union cpuid_0x10_x_edx {void rdt_last_cmd_clear (void );void rdt_last_cmd_puts (const char *s); +__printf(1, 2)void rdt_last_cmd_printf (const char *fmt, ...);void rdt_ctrl_update (void *arg);
[tip: x86/cache] x86/resctrl: Add printf attribute to log function
In reply to [email protected]The following commit has been merged into the x86/cache branch of tip:
The following commit has been merged into the x86/cache branch of tip:
Commit-ID: 3ff4ec0e281d0b234917e6e3033dd3067a5ea945 Gitweb: https://git.kernel.org/tip/3ff4ec0e281d0b234917e6e3033dd3067a5ea945 Author: Tom Rix <[email protected]> AuthorDate: Mon, 21 Dec 2020 08:00:09 -08:00 Committer: Borislav Petkov <[email protected]> CommitterDate: Mon, 11 Jan 2021 11:20:36 +01:00
x86/resctrl: Add printf attribute to log function
Mark the function with the __printf attribute to allow the compiler to more thoroughly typecheck its arguments against a format string with -Wformat and similar flags.
[ bp: Massage commit message. ]
--- arch/x86/kernel/cpu/resctrl/internal.h | 1 + 1 file changed, 1 insertion(+)
arch/x86/kernel/cpu/resctrl/internal.h +1 -0
@@ -572,6 +572,7 @@ union cpuid_0x10_x_edx {void rdt_last_cmd_clear (void );void rdt_last_cmd_puts (const char *s); +__printf(1, 2)void rdt_last_cmd_printf (const char *fmt, ...);void rdt_ctrl_update (void *arg);