igb: Enable RSS for Intel I211 Ethernet Controller
Subsystems (3)
PATCH 1/1 igb: Enable RSS for Intel I211 Ethernet Controller
The Intel I211 Ethernet Controller supports 2 Receive Side Scaling (RSS) queues. It should not be excluded from having this feature enabled.
Via commit c883de9fd787b6f49bf825f3de3601aeb78a7114 E1000_MRQC_ENABLE_RSS_4Q was renamed to E1000_MRQC_ENABLE_RSS_MQ to indicate that this is a generic bit flag to enable queues and not a flag that is specific to devices that support 4 queues
The bit flag enables 2, 4 or 8 queues appropriately depending on the part.
Tested with a multicore CPU and frames were then distributed as expected.
This issue appears to have been introduced because of confusion caused by the prior name.
--- drivers/net/ethernet/intel/igb/igb_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ethernet/intel/igb/igb_main.c +1 -2
@@ -4482,8 +4482,7 @@ static void igb_setup_mrqc(struct igb_adapter *adapter)else mrqc |=E1000_MRQC_ENABLE_VMDQ ; }else { -if (hw->mac.type != e1000_i211) - mrqc |=E1000_MRQC_ENABLE_RSS_MQ ; + mrqc |=E1000_MRQC_ENABLE_RSS_MQ ; }igb_vmm_control (adapter);
Signature · 1 line
2.29.2
Jakub Kicinski
maintainerQuoted 8 lines · On Mon, 21 Dec 2020 19:15:49 +0000 Nick Lowe wrote:
The Intel I211 Ethernet Controller supports 2 Receive Side Scaling (RSS) queues. It should not be excluded from having this feature enabled.
Via commit
c883de9fd787b6f49bf825f3de3601aeb78a7114E1000_MRQC_ENABLE_RSS_4Qwas renamed toE1000_MRQC_ENABLE_RSS_MQto indicate that this is a generic bit flag to enable queues and not a flag that is specific to devices that support 4 queues
Quoted 8 lines
The bit flag enables 2, 4 or 8 queues appropriately depending on the part.
Tested with a multicore CPU and frames were then distributed as expected.
This issue appears to have been introduced because of confusion caused by the prior name.
Signed-off-by Nick Lowe <[email protected]>
Please repost CCing the maintainers.