video: remove VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME
cover video: remove VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME
I propose this serie to remove the vidconsole work-around, activated with the 2 options VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME and cleanup the associated code in console.c (under #ifdef CONFIG_VIDCONSOLE_AS_LCD)
This options are now obsolete and they was planned to be removed around the end of 2020.
I propose this patchset for v2021.04 even if I don't test this serie on real boards.
Patrick.
Patrick Delaunay (6):
tbs2910: configs: remove VIDCONSOLE_AS_LCD
peach-pit: configs: remove VIDCONSOLE_AS_LCD
snow: configs: remove VIDCONSOLE_AS_LCD
peach-pi: configs: remove VIDCONSOLE_AS_LCD
spring: configs: remove VIDCONSOLE_AS_LCD
video: remove VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME
common/console.c | 10 ---------- configs/peach-pi_defconfig | 1 - configs/peach-pit_defconfig | 1 - configs/snow_defconfig | 1 - configs/spring_defconfig | 1 - configs/tbs2910_defconfig | 1 - drivers/video/Kconfig | 22 ---------------------- 7 files changed, 37 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/6 tbs2910: configs: remove VIDCONSOLE_AS_LCD
Remove the obsolete CONFIG_VIDCONSOLE_AS_LCD as vidconsole is used in ./include/configs/tbs2910.h since commit 513acd04452f ("tbs2910: migrate to DM_VIDEO").
---
configs/tbs2910_defconfig | 1 - 1 file changed, 1 deletion(-)
configs/tbs2910_defconfig +0 -1
@@ -103,7 +103,6 @@ CONFIG_DM_VIDEO=y # CONFIG_VIDEO_ANSI is not set CONFIG_SYS_WHITE_ON_BLACK=y # CONFIG_PANEL is not set -CONFIG_VIDCONSOLE_AS_LCD=y CONFIG_I2C_EDID=y CONFIG_VIDEO_IPUV3=y CONFIG_VIDEO_BMP_RLE8=y
Signature · 1 line
2.17.1
PATCH 1/6 tbs2910: configs: remove VIDCONSOLE_AS_LCD
Quoted 3 lines · Patrick Delaunay
Remove the obsolete
CONFIG_VIDCONSOLE_AS_LCDas vidconsole is used in./include/configs/tbs2910.hsince commit513acd04452f("tbs2910: migrate toDM_VIDEO").
I don't consider this workaround as obsolete, please see my response to the cover letter of this series. [1]
So please do not remove this code.
Thanks,
Soeren
[1] https://lists.denx.de/pipermail/u-boot/2020-December/434239.html
Quoted 19 lines
Signed-off-by Patrick Delaunay <[email protected]>---
configs/tbs2910_defconfig | 1 - 1 file changed, 1 deletion(-)configs/tbs2910_defconfig +0
-1@@ -103,7 +103,6 @@ CONFIG_DM_VIDEO=y # CONFIG_VIDEO_ANSI is not set CONFIG_SYS_WHITE_ON_BLACK=y # CONFIG_PANEL is not set -CONFIG_VIDCONSOLE_AS_LCD=y CONFIG_I2C_EDID=y CONFIG_VIDEO_IPUV3=y CONFIG_VIDEO_BMP_RLE8=y
PATCH 2/6 peach-pit: configs: remove VIDCONSOLE_AS_LCD
In reply to Patrick DelaunayRemove the obsolete CONFIG_VIDCONSOLE_AS_LCD as vidconsole is used in ./include/configs/peach-pit.h => configs/exynos5-dt-common.h since the commit bb5930d5c97f ("exynos: video: Convert several boards to driver model for video")
---
configs/peach-pit_defconfig | 1 - 1 file changed, 1 deletion(-)
configs/peach-pit_defconfig +0 -1
@@ -74,7 +74,6 @@ CONFIG_USB_XHCI_DWC3=y CONFIG_USB_HOST_ETHER=y CONFIG_DM_VIDEO=y # CONFIG_VIDEO_BPP8 is not set -CONFIG_VIDCONSOLE_AS_LCD=y CONFIG_DISPLAY=y CONFIG_VIDEO_BRIDGE=y CONFIG_VIDEO_BRIDGE_PARADE_PS862X=y
Signature · 1 line
2.17.1
PATCH 3/6 snow: configs: remove VIDCONSOLE_AS_LCD
In reply to Patrick DelaunayRemove the obsolete CONFIG_VIDCONSOLE_AS_LCD as vidconsole is used in ./include/configs/snow.h => configs/exynos5-dt-common.h since the commit bb5930d5c97f ("exynos: video: Convert several boards to driver model for video")
---
configs/snow_defconfig | 1 - 1 file changed, 1 deletion(-)
configs/snow_defconfig +0 -1
@@ -85,7 +85,6 @@ CONFIG_USB_HOST_ETHER=y CONFIG_USB_ETHER_ASIX88179=y CONFIG_DM_VIDEO=y # CONFIG_VIDEO_BPP8 is not set -CONFIG_VIDCONSOLE_AS_LCD=y CONFIG_DISPLAY=y CONFIG_VIDEO_BRIDGE=y CONFIG_VIDEO_BRIDGE_PARADE_PS862X=y
Signature · 1 line
2.17.1
PATCH 4/6 peach-pi: configs: remove VIDCONSOLE_AS_LCD
In reply to Patrick DelaunayRemove the obsolete CONFIG_VIDCONSOLE_AS_LCD as vidconsole is used in ./include/configs/peach-pi.h => configs/exynos5-dt-common.h since the commit bb5930d5c97f ("exynos: video: Convert several boards to driver model for video")
---
configs/peach-pi_defconfig | 1 - 1 file changed, 1 deletion(-)
configs/peach-pi_defconfig +0 -1
@@ -75,7 +75,6 @@ CONFIG_USB_XHCI_DWC3=y CONFIG_USB_HOST_ETHER=y CONFIG_DM_VIDEO=y # CONFIG_VIDEO_BPP8 is not set -CONFIG_VIDCONSOLE_AS_LCD=y CONFIG_DISPLAY=y CONFIG_VIDEO_BRIDGE=y CONFIG_VIDEO_BRIDGE_PARADE_PS862X=y
Signature · 1 line
2.17.1
PATCH 5/6 spring: configs: remove VIDCONSOLE_AS_LCD
In reply to Patrick DelaunayRemove the obsolete CONFIG_VIDCONSOLE_AS_LCD as vidconsole is used in ./include/configs/spring.h => configs/exynos5-dt-common.h since the commit bb5930d5c97f ("exynos: video: Convert several boards to driver model for video")
---
configs/spring_defconfig | 1 - 1 file changed, 1 deletion(-)
configs/spring_defconfig +0 -1
@@ -86,7 +86,6 @@ CONFIG_USB_HOST_ETHER=y CONFIG_USB_ETHER_ASIX88179=y CONFIG_DM_VIDEO=y # CONFIG_VIDEO_BPP8 is not set -CONFIG_VIDCONSOLE_AS_LCD=y CONFIG_DISPLAY=y CONFIG_VIDEO_BRIDGE=y CONFIG_VIDEO_BRIDGE_PARADE_PS862X=y
Signature · 1 line
2.17.1
PATCH 5/6 spring: configs: remove VIDCONSOLE_AS_LCD
Quoted 6 lines · Patrick Delaunay
Remove the obsolete
CONFIG_VIDCONSOLE_AS_LCDas vidconsole is used in./include/configs/spring.h=>configs/exynos5-dt-common.hsince the commitbb5930d5c97f("exynos: video: Convert several boards to driver model for video")
Quoted 6 lines
Signed-off-by Patrick Delaunay <[email protected]>---
configs/spring_defconfig | 1 - 1 file changed, 1 deletion(-)
PATCH 6/6 video: remove VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME
In reply to Patrick DelaunayRemove as planned (option will be removed around the end of 2020) the workaround for boards which have 'lcd' or 'vga' in their stdout environment variable.
These options are no more used in any defconfig and this patch simplify the code in console.c file.
---
common/console.c | 10 ---------- drivers/video/Kconfig | 22 ---------------------- 2 files changed, 32 deletions(-)
common/console.c +0 -10
@@ -730,11 +730,6 @@ struct stdio_dev *search_device(int flags, const char *name)struct stdio_dev *dev; dev =stdio_get_by_name (name); -#ifdef CONFIG_VIDCONSOLE_AS_LCD -if (!dev && !strcmp (name,CONFIG_VIDCONSOLE_AS_NAME )) - dev =stdio_get_by_name ("vidconsole" ); -#endif -if (dev && (dev->flags & flags))return dev;
@@ -914,11 +909,6 @@ done:#ifndef CONFIG_SYS_CONSOLE_INFO_QUIET stdio_print_current_devices ();#endif /* CONFIG_SYS_CONSOLE_INFO_QUIET */ -#ifdef CONFIG_VIDCONSOLE_AS_LCD -if (strstr (stdoutname,CONFIG_VIDCONSOLE_AS_NAME )) -printf ("Warning: Please change '%s' to 'vidconsole' in stdout/stderr environment vars\n" , -CONFIG_VIDCONSOLE_AS_NAME ); -#endif #ifdef CONFIG_SYS_CONSOLE_ENV_OVERWRITE /* set the environment variables (will overwrite previous env settings) */
drivers/video/Kconfig +0 -22
@@ -207,28 +207,6 @@ config SIMPLE_PANEL source "drivers/video/fonts/Kconfig" -config VIDCONSOLE_AS_LCD - bool "Use 'vidconsole' when CONFIG_VIDCONSOLE_AS_NAME string is seen in stdout" - depends on DM_VIDEO - help - This is a work-around for boards which have 'lcd' or 'vga' in their - stdout environment variable, but have moved to use driver model for - video. In this case the console will no-longer work. While it is - possible to update the environment, the breakage may be confusing for - users. This option will be removed around the end of 2020. - -config VIDCONSOLE_AS_NAME - string "Use 'vidconsole' when string defined here is seen in stdout" - depends on VIDCONSOLE_AS_LCD - default "lcd" if LCD || TEGRA_COMMON - default "vga" if !LCD - help - This is a work-around for boards which have 'lcd' or 'vga' in their - stdout environment variable, but have moved to use driver model for - video. In this case the console will no-longer work. While it is - possible to update the environment, the breakage may be confusing for - users. This option will be removed around the end of 2020. - config VIDEO_COREBOOT bool "Enable coreboot framebuffer driver support" depends on X86 && SYS_COREBOOT
Signature · 1 line
2.17.1
cover video: remove VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME
In reply to Patrick DelaunayQuoted 9 lines · Patrick Delaunay
I propose this serie to remove the vidconsole work-around, activated with the 2 options
VIDCONSOLE_AS_LCDandVIDCONSOLE_AS_NAMEand cleanup the associated code inconsole.c(under #ifdefCONFIG_VIDCONSOLE_AS_LCD)This options are now obsolete and they was planned to be removed around the end of 2020.
I propose this patchset for v2021.04 even if I don't test this serie on real boards.
I really would like to keep this code for now.
On the tbs2910 board this workaround was introduced in the last u-boot release (v2020.10), so there was almost no time for end users to notice the warning and to update there environment. Not every end user installs every new u-boot release, so we really should give more time for this change.
This workaround is self-contained, small, easy to maintain, and strictly opt-in. So this workaround hurts nobody, but removing this will let users alone without any HDMI output. So on this board (without included serial console port), this will result in unhappy users, especially since without any console output there is no chance to get any idea what is going wrong.
Thanks,
Soeren
Quoted 22 lines
Patrick.
Patrick Delaunay (6):
tbs2910: configs: removeVIDCONSOLE_AS_LCD
peach-pit: configs: removeVIDCONSOLE_AS_LCD
snow: configs: removeVIDCONSOLE_AS_LCD
peach-pi: configs: removeVIDCONSOLE_AS_LCD
spring: configs: removeVIDCONSOLE_AS_LCD
video: removeVIDCONSOLE_AS_LCDandVIDCONSOLE_AS_NAMEcommon/console.c | 10 ---------- configs/peach-pi_defconfig | 1 - configs/peach-pit_defconfig | 1 - configs/snow_defconfig | 1 - configs/spring_defconfig | 1 - configs/tbs2910_defconfig | 1 - drivers/video/Kconfig | 22 ---------------------- 7 files changed, 37 deletions(-)
A message that is not in the archive (sent off-list or not yet received): [email protected]
cover video: remove VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME
Hi Soeren,
Quoted 12 lines
From: Soeren Moch <[email protected]> Sent: dimanche 6 d?cembre 2020 20:59
Quoted 7 lines · Patrick Delaunay
I propose this serie to remove the vidconsole work-around, activated with the 2 options
VIDCONSOLE_AS_LCDandVIDCONSOLE_AS_NAMEand cleanup the associated code inconsole.c(under #ifdefCONFIG_VIDCONSOLE_AS_LCD) This options are now obsolete and they was planned to be removed around the end of 2020. I propose this patchset for v2021.04 even if I don't test this serie on real boards.I really would like to keep this code for now.
I propose to remove these options because they are indicated obsolete in the config description
in drivers/video/Kconfig (I see it during code review):
"This option will be removed around the end of 2020"
But I have no issue to kept it.
Quoted 6 lines
On the tbs2910 board this workaround was introduced in the last u-boot release (v2020.10), so there was almost no time for end users to notice the warning and to update there environment. Not every end user installs every new u-boot release, so we really should give more time for this change.
I agree that for your project, with migration to DM_VIDEO it is a really short notice.
??? commit 645d39aea367064868dcdd30c411806f4403b67b
??? board: tbs2910: Fix video output with existing environments
=> only integrated in v2020.10-rc2, sorry to miss it
Quoted 7 lines
This workaround is self-contained, small, easy to maintain, and strictly opt-in. So this workaround hurts nobody, but removing this will let users alone without any HDMI output. So on this board (without included serial console port), this will result in unhappy users, especially since without any console output there is no chance to get any idea what is going wrong.
Initially, I proposed this patch to cleanup the console.c code with 2 other series:
1) http://patchwork.ozlabs.org/project/uboot/list/?series=218309
??? "console: remove #ifdef CONFIG when it is possible"
2) http://patchwork.ozlabs.org/project/uboot/list/?series=218089
??? "console: cosmetics: remove #if 0"
And I just want just to remove the remaining "#ifdef CONFIG_...."? in console.c
But I agree that I need to change my proposal to remove this workaround code
(it is only use to help the DM VIDEO migration for existing board)
and change the release target.
I propose to :
- remove patch 1/6 of the serie for your board
- no more remove the options in 6/6 but add warning in Makefile when the option is activated
? and change target in config desciption
ifeq ($(CONFIG_VIDCONSOLE_AS_LCD),y)
??? @echo >&2 "===================== WARNING ======================" ??? @echo >&2 "This board does use CONFIG_VIDCONSOLE_AS_LCD workaround." ??? @echo >&2 "Please update the existing user defined environments
before "
??? @echo >&2 "v2022.01 release."
??? @echo >&2 "Failure to update by the deadline may result in video
console"
@echo >&2 "issue when this woarkaround will be removed."
??? @echo >&2 "===================================================="
endif
=> open point: which acceptable target to remove this feature ? v2022.01 ?
Anyway, if the the maintainers (video or console) think this code should be kept, I can also drop this serie.
Thanks.
Patrick
cover video: remove VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME
Quoted 87 lines · Patrick DELAUNAY
Hi Soeren,
Quoted 11 lines
From: Soeren Moch <[email protected]> Sent: dimanche 6 d?cembre 2020 20:59 On
Quoted 8 lines · Patrick Delaunay
I propose this serie to remove the vidconsole work-around, activated with the 2 options
VIDCONSOLE_AS_LCDandVIDCONSOLE_AS_NAMEand cleanup the associated code inconsole.c(under #ifdefCONFIG_VIDCONSOLE_AS_LCD) This options are now obsolete and they was planned to be removed around the end of 2020. I propose this patchset for v2021.04 even if I don't test this serie on real boards.Quoted 2 lines
I really would like to keep this code for now.
I propose to remove these options because they are indicated obsolete in the config description
in
drivers/video/Kconfig(I see it during code review):"This option will be removed around the end of 2020"
But I have no issue to kept it.
Quoted 6 lines
On the tbs2910 board this workaround was introduced in the last u-boot release (v2020.10), so there was almost no time for end users to notice the warning and to update there environment. Not every end user installs every new u-boot release, so we really should give more time for this change.
I agree that for your project, with migration to
DM_VIDEOit is a really short notice.??? commit
645d39aea367064868dcdd30c411806f4403b67b??? board: tbs2910: Fix video output with existing environments
=> only integrated in v2020.10-rc2, sorry to miss it
Quoted 7 lines
This workaround is self-contained, small, easy to maintain, and strictly opt-in. So this workaround hurts nobody, but removing this will let users alone without any HDMI output. So on this board (without included serial console port), this will result in unhappy users, especially since without any console output there is no chance to get any idea what is going wrong.
Initially, I proposed this patch to cleanup the
console.ccode with 2 other series:1) http://patchwork.ozlabs.org/project/uboot/list/?series=218309
??? "console: remove #ifdef CONFIG when it is possible"
2) http://patchwork.ozlabs.org/project/uboot/list/?series=218089
??? "console: cosmetics: remove #if 0"
And I just want just to remove the remaining "#ifdef
CONFIG_...."? inconsole.cBut I agree that I need to change my proposal to remove this workaround code
(it is only use to help the DM VIDEO migration for existing board)
and change the release target.
I propose to :
- remove patch 1/6 of the serie for your board
- no more remove the options in 6/6 but add warning in
Makefilewhen the option is activated? and change target in config desciption
ifeq ($(CONFIG_VIDCONSOLE_AS_LCD),y)
??? @echo >&2 "===================== WARNING ======================" ??? @echo >&2 "This board does useCONFIG_VIDCONSOLE_AS_LCDworkaround." ??? @echo >&2 "Please update the existing user defined environments before " ??? @echo >&2 "v2022.01 release."
??? @echo >&2 "Failure to update by the deadline may result in video console"
Quoted 5 lines
@echo >&2 "issue when this woarkaround will be removed." ??? @echo >&2 "====================================================" endif
=> open point: which acceptable target to remove this feature ? v2022.01 ?
This sounds like a good plan and reasonable date to me. Anatolij? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201208/f2a19038/attachment.sig>
cover video: remove VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME
Quoted 88 lines · Tom Rini
Quoted 87 lines · Patrick DELAUNAY
Hi Soeren,
Quoted 11 lines
From: Soeren Moch <[email protected]> Sent: dimanche 6 d?cembre 2020 20:59 On
Quoted 8 lines · Patrick Delaunay
I propose this serie to remove the vidconsole work-around, activated with the 2 options
VIDCONSOLE_AS_LCDandVIDCONSOLE_AS_NAMEand cleanup the associated code inconsole.c(under #ifdefCONFIG_VIDCONSOLE_AS_LCD) This options are now obsolete and they was planned to be removed around the end of 2020. I propose this patchset for v2021.04 even if I don't test this serie on real boards.Quoted 2 lines
I really would like to keep this code for now.
I propose to remove these options because they are indicated obsolete in the config description
in
drivers/video/Kconfig(I see it during code review):"This option will be removed around the end of 2020"
But I have no issue to kept it.
Quoted 6 lines
On the tbs2910 board this workaround was introduced in the last u-boot release (v2020.10), so there was almost no time for end users to notice the warning and to update there environment. Not every end user installs every new u-boot release, so we really should give more time for this change.
I agree that for your project, with migration to
DM_VIDEOit is a really short notice.??? commit
645d39aea367064868dcdd30c411806f4403b67b??? board: tbs2910: Fix video output with existing environments
=> only integrated in v2020.10-rc2, sorry to miss it
Quoted 7 lines
This workaround is self-contained, small, easy to maintain, and strictly opt-in. So this workaround hurts nobody, but removing this will let users alone without any HDMI output. So on this board (without included serial console port), this will result in unhappy users, especially since without any console output there is no chance to get any idea what is going wrong.
Initially, I proposed this patch to cleanup the
console.ccode with 2 other series:1) http://patchwork.ozlabs.org/project/uboot/list/?series=218309
??? "console: remove #ifdef CONFIG when it is possible"
2) http://patchwork.ozlabs.org/project/uboot/list/?series=218089
??? "console: cosmetics: remove #if 0"
And I just want just to remove the remaining "#ifdef
CONFIG_...."? inconsole.cBut I agree that I need to change my proposal to remove this workaround code
(it is only use to help the DM VIDEO migration for existing board)
and change the release target.
I propose to :
- remove patch 1/6 of the serie for your board
- no more remove the options in 6/6 but add warning in
Makefilewhen the option is activated? and change target in config desciption
ifeq ($(CONFIG_VIDCONSOLE_AS_LCD),y)
??? @echo >&2 "===================== WARNING ======================" ??? @echo >&2 "This board does useCONFIG_VIDCONSOLE_AS_LCDworkaround." ??? @echo >&2 "Please update the existing user defined environments before " ??? @echo >&2 "v2022.01 release."
??? @echo >&2 "Failure to update by the deadline may result in video console"
Quoted 8 lines
Quoted 5 lines
@echo >&2 "issue when this woarkaround will be removed." ??? @echo >&2 "====================================================" endif
=> open point: which acceptable target to remove this feature ? v2022.01 ?
This sounds like a good plan and reasonable date to me. Anatolij? Thanks!
Probably board users will not pay much attention to the build warning, hopefully more to the console output warning.
Nevertheless, the proposed plan sounds like a good idea to me.
Thanks,
Soeren
cover video: remove VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME
In reply to Tom RiniOn Tue, 8 Dec 2020 11:16:30 -0500
Tom Rini trini at konsulko.com wrote:
...
Quoted 3 lines
Quoted 1 line
=> open point: which acceptable target to remove this feature ? v2022.01 ?
This sounds like a good plan and reasonable date to me. Anatolij?
I have no objection, this target date is okay for me.
--
Anatolij
cover video: remove VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME
Quoted 8 lines · Anatolij Gustschin
On Tue, 8 Dec 2020 11:16:30 -0500
Tom Rini trini at konsulko.com wrote:
...Quoted 3 lines
Quoted 1 line
=> open point: which acceptable target to remove this feature ? v2022.01 ?
This sounds like a good plan and reasonable date to me. Anatolij?
I have no objection, this target date is okay for me.
Can you please make up the patch for noting this, etc? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201221/bfe798ba/attachment.sig>