trace: select TIMER_EARLY to avoid infinite recursion
Subsystems (3)
PATCH v2 1/2 trace: select TIMER_EARLY to avoid infinite recursion
When tracing functions is enabled this adds calls to __cyg_profile_func_enter() and __cyg_profile_func_exit() to the traced functions.
__cyg_profile_func_enter() and __cyg_profile_func_exit() invoke timer_get_us() to record the entry and exit time.
initr_dm() will make gd->dm_root = NULL and gd->timer = NULL, so timer_get_us() -> get_ticks() -> dm_timer_init() will lead to an indefinite recursion.
So select TIMER_EARLY when tracing got enabled.
---
Changes in v2:
- new patch
lib/Kconfig | 1 + 1 file changed, 1 insertion(+)
lib/Kconfig +1 -0
@@ -210,6 +210,7 @@ config BITREVERSE config TRACE bool "Support for tracing of function calls and timing" imply CMD_TRACE + select TIMER_EARLY help Enables function tracing within U-Boot. This allows recording of call traces including timing information. The command can write data to
Signature · 1 line
2.17.1
PATCH v2 2/2 riscv: timer: Add support for an early timer
Added support for timer_early_get_count() and timer_early_get_rate() This is mostly useful in tracing.
---
Changes in v2:
- make u-boot compile for qemu (include/configs/qemu-riscv.h)
drivers/timer/andes_plmt_timer.c | 21 ++++++++++++++++++++- drivers/timer/riscv_timer.c | 21 ++++++++++++++++++++- drivers/timer/sifive_clint_timer.c | 21 ++++++++++++++++++++- include/configs/ax25-ae350.h | 5 +++++ include/configs/qemu-riscv.h | 5 +++++ include/configs/sifive-fu540.h | 5 +++++ 6 files changed, 75 insertions(+), 3 deletions(-)
drivers/timer/andes_plmt_timer.c +20 -1
@@ -17,11 +17,30 @@/* mtime register */ #define MTIME_REG (base) ((ulong)(base)) -static u64 andes_plmt_get_count (struct udevice *dev) +static u64 notrace andes_plmt_get_count(struct udevice *dev) {return readq ((void __iomem *)MTIME_REG (dev->priv)); } +#if CONFIG_IS_ENABLED (RISCV_MMODE ) +/** +* timer_early_get_rate() - Get the timer rate before driver model +*/ +unsigned long notrace timer_early_get_rate (void ) +{ +return RISCV_MMODE_TIMER_FREQ ; +} + +/** +* timer_early_get_count() - Get the timer count before driver model +* +*/ +u64 notrace timer_early_get_count(void) +{ +return readq ((void __iomem *)MTIME_REG (RISCV_MMODE_TIMERBASE )); +} +#endif +static const struct timer_ops andes_plmt_ops = { .get_count = andes_plmt_get_count, };
drivers/timer/riscv_timer.c +20 -1
@@ -16,7 +16,7 @@#include <timer.h> #include <asm/csr.h> -static u64 riscv_timer_get_count (struct udevice *dev) +static u64 notrace riscv_timer_get_count(struct udevice *dev) {__maybe_unused u32 hi, lo;
@@ -31,6 +31,25 @@ static u64 riscv_timer_get_count(struct udevice *dev)return ((u64 )hi <<32 ) | lo; } +#if CONFIG_IS_ENABLED (RISCV_SMODE ) +/** +* timer_early_get_rate() - Get the timer rate before driver model +*/ +unsigned long notrace timer_early_get_rate (void ) +{ +return RISCV_SMODE_TIMER_FREQ ; +} + +/** +* timer_early_get_count() - Get the timer count before driver model +* +*/ +u64 notrace timer_early_get_count(void) +{ +return riscv_timer_get_count (NULL ); +} +#endif +static int riscv_timer_probe (struct udevice *dev) {struct timer_dev_priv *uc_priv =dev_get_uclass_priv (dev);
drivers/timer/sifive_clint_timer.c +20 -1
@@ -14,11 +14,30 @@/* mtime register */ #define MTIME_REG (base) ((ulong)(base) + 0xbff8) -static u64 sifive_clint_get_count (struct udevice *dev) +static u64 notrace sifive_clint_get_count(struct udevice *dev) {return readq ((void __iomem *)MTIME_REG (dev->priv)); } +#if CONFIG_IS_ENABLED (RISCV_MMODE ) +/** +* timer_early_get_rate() - Get the timer rate before driver model +*/ +unsigned long notrace timer_early_get_rate (void ) +{ +return RISCV_MMODE_TIMER_FREQ ; +} + +/** +* timer_early_get_count() - Get the timer count before driver model +* +*/ +u64 notrace timer_early_get_count(void) +{ +return readq ((void __iomem *)MTIME_REG (RISCV_MMODE_TIMERBASE )); +} +#endif +static const struct timer_ops sifive_clint_ops = { .get_count = sifive_clint_get_count, };
include/configs/ax25-ae350.h +5 -0
@@ -17,6 +17,11 @@#endif #endif +#define RISCV_MMODE_TIMERBASE 0xe6000000 +#define RISCV_MMODE_TIMER_FREQ 60000000 + +#define RISCV_SMODE_TIMER_FREQ 60000000 +/* * CPU and Board Configuration Options */
include/configs/qemu-riscv.h +5 -0
@@ -29,6 +29,11 @@#define CONFIG_STANDALONE_LOAD_ADDR 0x80200000 +#define RISCV_MMODE_TIMERBASE 0x2000000 +#define RISCV_MMODE_TIMER_FREQ 1000000 + +#define RISCV_SMODE_TIMER_FREQ 1000000 +/* Environment options */ #ifndef CONFIG_SPL_BUILD
include/configs/sifive-fu540.h +5 -0
@@ -36,6 +36,11 @@#define CONFIG_STANDALONE_LOAD_ADDR 0x80200000 +#define RISCV_MMODE_TIMERBASE 0x2000000 +#define RISCV_MMODE_TIMER_FREQ 1000000 + +#define RISCV_SMODE_TIMER_FREQ 1000000 +/* Environment options */ #ifndef CONFIG_SPL_BUILD
Signature · 1 line
2.17.1
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v2 2/2 riscv: timer: Add support for an early timer
Quoted 15 lines
From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
Sent: Tuesday, December 22, 2020 2:23 PM
To: u-boot at lists.denx.de
Cc: atish.patra at wdc.com; palmerdabbelt at google.com; bmeng.cn at gmail.com; paul.walmsley at sifive.com; anup.patel at wdc.com; sagar.kadam at sifive.com; Rick Jian-Zhi Chen(???); pragnesh.patel at openfive.com; Pragnesh Patel; Palmer Dabbelt; Sean Anderson; Claudiu Beznea; Simon Glass
Subject: [PATCH v2 2/2] riscv: timer: Add support for an early timerAdded support for
timer_early_get_count()andtimer_early_get_rate()This is mostly useful in tracing.Signed-off-by Pragnesh Patel <[email protected]>---
Changes in v2:
- make u-boot compile for qemu (include/configs/qemu-riscv.h)
Quoted 7 lines
drivers/timer/andes_plmt_timer.c | 21 ++++++++++++++++++++- drivers/timer/riscv_timer.c | 21 ++++++++++++++++++++- drivers/timer/sifive_clint_timer.c | 21 ++++++++++++++++++++- include/configs/ax25-ae350.h | 5 +++++ include/configs/qemu-riscv.h | 5 +++++ include/configs/sifive-fu540.h | 5 +++++ 6 files changed, 75 insertions(+), 3 deletions(-)
PATCH v2 2/2 riscv: timer: Add support for an early timer
Hi Pragnesh
Quoted 23 lines
Quoted 15 lines
From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
Sent: Tuesday, December 22, 2020 2:23 PM
To: u-boot at lists.denx.de
Cc: atish.patra at wdc.com; palmerdabbelt at google.com; bmeng.cn at gmail.com; paul.walmsley at sifive.com; anup.patel at wdc.com; sagar.kadam at sifive.com; Rick Jian-Zhi Chen(???); pragnesh.patel at openfive.com; Pragnesh Patel; Palmer Dabbelt; Sean Anderson; Claudiu Beznea; Simon Glass
Subject: [PATCH v2 2/2] riscv: timer: Add support for an early timerAdded support for
timer_early_get_count()andtimer_early_get_rate()This is mostly useful in tracing.Signed-off-by Pragnesh Patel <[email protected]>---
Changes in v2:
- make u-boot compile for qemu (include/configs/qemu-riscv.h)Quoted 7 lines
drivers/timer/andes_plmt_timer.c | 21 ++++++++++++++++++++- drivers/timer/riscv_timer.c | 21 ++++++++++++++++++++- drivers/timer/sifive_clint_timer.c | 21 ++++++++++++++++++++- include/configs/ax25-ae350.h | 5 +++++ include/configs/qemu-riscv.h | 5 +++++ include/configs/sifive-fu540.h | 5 +++++ 6 files changed, 75 insertions(+), 3 deletions(-)
Quoted 1 line
Reviewed-by Rick Chen <[email protected]>
Please check about the CI failure item:
https://gitlab.denx.de/u-boot/custodians/u-boot-riscv/-/jobs/196578
Thanks,
Rick
PATCH v2 2/2 riscv: timer: Add support for an early timer
Quoted 25 lines · Rick Chen
Hi Pragnesh
Quoted 23 lines
Quoted 22 lines
From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
Sent: Tuesday, December 22, 2020 2:23 PM
To: u-boot at lists.denx.de
Cc: atish.patra at wdc.com; palmerdabbelt at google.com; bmeng.cn at gmail.com; paul.walmsley at sifive.com; anup.patel at wdc.com; sagar.kadam at sifive.com; Rick Jian-Zhi Chen(???); pragnesh.patel at openfive.com; Pragnesh Patel; Palmer Dabbelt; Sean Anderson; Claudiu Beznea; Simon Glass
Subject: [PATCH v2 2/2] riscv: timer: Add support for an early timerAdded support for
timer_early_get_count()andtimer_early_get_rate()This is mostly useful in tracing.Signed-off-by Pragnesh Patel <[email protected]>---
Changes in v2:
- make u-boot compile for qemu (include/configs/qemu-riscv.h)drivers/timer/andes_plmt_timer.c | 21 ++++++++++++++++++++- drivers/timer/riscv_timer.c | 21 ++++++++++++++++++++- drivers/timer/sifive_clint_timer.c | 21 ++++++++++++++++++++- include/configs/ax25-ae350.h | 5 +++++ include/configs/qemu-riscv.h | 5 +++++ include/configs/sifive-fu540.h | 5 +++++ 6 files changed, 75 insertions(+), 3 deletions(-)
Quoted 4 lines
Quoted 1 line
Reviewed-by Rick Chen <[email protected]>Please check about the CI failure item:
https://gitlab.denx.de/u-boot/custodians/u-boot-riscv/-/jobs/196578
404 for me (though I suspect it's really a 403).
--Sean
PATCH v2 2/2 riscv: timer: Add support for an early timer
Quoted 27 lines · Sean Anderson
Quoted 25 lines · Rick Chen
Hi Pragnesh
Quoted 23 lines
Quoted 22 lines
From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
Sent: Tuesday, December 22, 2020 2:23 PM
To: u-boot at lists.denx.de
Cc: atish.patra at wdc.com; palmerdabbelt at google.com; bmeng.cn at gmail.com; paul.walmsley at sifive.com; anup.patel at wdc.com; sagar.kadam at sifive.com; Rick Jian-Zhi Chen(???); pragnesh.patel at openfive.com; Pragnesh Patel; Palmer Dabbelt; Sean Anderson; Claudiu Beznea; Simon Glass
Subject: [PATCH v2 2/2] riscv: timer: Add support for an early timerAdded support for
timer_early_get_count()andtimer_early_get_rate()This is mostly useful in tracing.Signed-off-by Pragnesh Patel <[email protected]>---
Changes in v2:
- make u-boot compile for qemu (include/configs/qemu-riscv.h)drivers/timer/andes_plmt_timer.c | 21 ++++++++++++++++++++- drivers/timer/riscv_timer.c | 21 ++++++++++++++++++++- drivers/timer/sifive_clint_timer.c | 21 ++++++++++++++++++++- include/configs/ax25-ae350.h | 5 +++++ include/configs/qemu-riscv.h | 5 +++++ include/configs/sifive-fu540.h | 5 +++++ 6 files changed, 75 insertions(+), 3 deletions(-)
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Reviewed-by Rick Chen <[email protected]>Please check about the CI failure item:
https://gitlab.denx.de/u-boot/custodians/u-boot-riscv/-/jobs/196578404 for me (though I suspect it's really a 403).
404 for me also.
Quoted 3 lines
--Sean
PATCH v2 2/2 riscv: timer: Add support for an early timer
Hi Pragnesh
Quoted 28 lines · Sean Anderson
Quoted 27 lines · Rick Chen
Quoted 25 lines
Hi Pragnesh
Quoted 23 lines
Quoted 22 lines
From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
Sent: Tuesday, December 22, 2020 2:23 PM
To: u-boot at lists.denx.de
Cc: atish.patra at wdc.com; palmerdabbelt at google.com; bmeng.cn at gmail.com; paul.walmsley at sifive.com; anup.patel at wdc.com; sagar.kadam at sifive.com; Rick Jian-Zhi Chen(???); pragnesh.patel at openfive.com; Pragnesh Patel; Palmer Dabbelt; Sean Anderson; Claudiu Beznea; Simon Glass
Subject: [PATCH v2 2/2] riscv: timer: Add support for an early timerAdded support for
timer_early_get_count()andtimer_early_get_rate()This is mostly useful in tracing.Signed-off-by Pragnesh Patel <[email protected]>---
Changes in v2:
- make u-boot compile for qemu (include/configs/qemu-riscv.h)drivers/timer/andes_plmt_timer.c | 21 ++++++++++++++++++++- drivers/timer/riscv_timer.c | 21 ++++++++++++++++++++- drivers/timer/sifive_clint_timer.c | 21 ++++++++++++++++++++- include/configs/ax25-ae350.h | 5 +++++ include/configs/qemu-riscv.h | 5 +++++ include/configs/sifive-fu540.h | 5 +++++ 6 files changed, 75 insertions(+), 3 deletions(-)
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Reviewed-by Rick Chen <[email protected]>Please check about the CI failure item:
https://gitlab.denx.de/u-boot/custodians/u-boot-riscv/-/jobs/196578404 for me (though I suspect it's really a 403).
404 for me also.
Followings are the errors from CI:
...
...
+====================================================
562 riscv: + microchip_mpfs_icicle 563+drivers/timer/sifive_clint_timer.c: In function 'timer_early_get_rate':564+drivers/timer/sifive_clint_timer.c:28:9: error:
'RISCV_MMODE_TIMER_FREQ' undeclared (first use in this function) 565+ 28 | return RISCV_MMODE_TIMER_FREQ;
566+ | ^~~~~~~~~~~~~~~~~~~~~~ 567+drivers/timer/sifive_clint_timer.c:28:9: note: each undeclared identifier is reported only once for each function it appears in 568+drivers/timer/sifive_clint_timer.c: In function 'timer_early_get_count':569+drivers/timer/sifive_clint_timer.c:37:41: error:
'RISCV_MMODE_TIMERBASE' undeclared (first use in this function) 570+ 37 | return readq((void __iomem *)MTIME_REG(RISCV_MMODE_TIMERBASE)); 571+ | ^~~~~~~~~~~~~~~~~~~~~ 572+drivers/timer/sifive_clint_timer.c:15:36: note: in definition of macro 'MTIME_REG'
573+ 15 | #define MTIME_REG(base) ((ulong)(base) + 0xbff8)
574+ | ^~~~575+drivers/timer/sifive_clint_timer.c:29:1: error: control reaches end of non-void function [-Werror=return-type]
576+ 29 | }
577+ | ^578+drivers/timer/sifive_clint_timer.c:38:1: error: control reaches end of non-void function [-Werror=return-type]
579+ 38 | }
580+cc1: all warnings being treated as errors
581+make[3]: *** [drivers/timer/sifive_clint_timer.o] Error 1 582+make[2]: *** [drivers/timer] Error 2
583+make[1]: *** [drivers] Error 2
584+make: *** [sub-make] Error 2
585 riscv: + sipeed_maix_bitm 586+drivers/timer/sifive_clint_timer.c: In function 'timer_early_get_rate':587+drivers/timer/sifive_clint_timer.c:28:9: error:
'RISCV_MMODE_TIMER_FREQ' undeclared (first use in this function) 588+ 28 | return RISCV_MMODE_TIMER_FREQ;
589+ | ^~~~~~~~~~~~~~~~~~~~~~ 590+drivers/timer/sifive_clint_timer.c:28:9: note: each undeclared identifier is reported only once for each function it appears in 591+drivers/timer/sifive_clint_timer.c: In function 'timer_early_get_count':592+drivers/timer/sifive_clint_timer.c:37:41: error:
'RISCV_MMODE_TIMERBASE' undeclared (first use in this function) 593+ 37 | return readq((void __iomem *)MTIME_REG(RISCV_MMODE_TIMERBASE)); 594+ | ^~~~~~~~~~~~~~~~~~~~~ 595+drivers/timer/sifive_clint_timer.c:15:36: note: in definition of macro 'MTIME_REG'
596+ 15 | #define MTIME_REG(base) ((ulong)(base) + 0xbff8)
597+ | ^~~~598+drivers/timer/sifive_clint_timer.c:29:1: error: control reaches end of non-void function [-Werror=return-type]
599+ 29 | }
600+ | ^601+drivers/timer/sifive_clint_timer.c:38:1: error: control reaches end of non-void function [-Werror=return-type]
602+ 38 | }
603+cc1: all warnings being treated as errors
604+make[3]: *** [drivers/timer/sifive_clint_timer.o] Error 1 605+make[2]: *** [drivers/timer] Error 2
606+make[1]: *** [drivers] Error 2
607+make: *** [sub-make] Error 2
608 riscv: + sipeed_maix_smode609+drivers/timer/riscv_timer.c: In function 'timer_early_get_rate':610+drivers/timer/riscv_timer.c:40:9: error: 'RISCV_SMODE_TIMER_FREQ' undeclared (first use in this function)
611+ 40 | return RISCV_SMODE_TIMER_FREQ;
612+ | ^~~~~~~~~~~~~~~~~~~~~~ 613+drivers/timer/riscv_timer.c:40:9: note: each undeclared identifier is reported only once for each function it appears in 614+drivers/timer/riscv_timer.c:41:1: error: control reaches end of non-void function [-Werror=return-type]
615+ 41 | }
616+ | ^
...
...
Thanks,
Rick
Quoted 3 lines
Quoted 3 lines
--Sean
PATCH v2 2/2 riscv: timer: Add support for an early timer
Hi Rick,
Quoted 108 lines · Rick Chen
Hi Pragnesh
Quoted 28 lines · Sean Anderson
Quoted 27 lines · Rick Chen
Quoted 25 lines
Hi Pragnesh
Quoted 23 lines
Quoted 22 lines
From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
Sent: Tuesday, December 22, 2020 2:23 PM
To: u-boot at lists.denx.de
Cc: atish.patra at wdc.com; palmerdabbelt at google.com; bmeng.cn at gmail.com; paul.walmsley at sifive.com; anup.patel at wdc.com; sagar.kadam at sifive.com; Rick Jian-Zhi Chen(???); pragnesh.patel at openfive.com; Pragnesh Patel; Palmer Dabbelt; Sean Anderson; Claudiu Beznea; Simon Glass
Subject: [PATCH v2 2/2] riscv: timer: Add support for an early timerAdded support for
timer_early_get_count()andtimer_early_get_rate()This is mostly useful in tracing.Signed-off-by Pragnesh Patel <[email protected]>---
Changes in v2:
- make u-boot compile for qemu (include/configs/qemu-riscv.h)drivers/timer/andes_plmt_timer.c | 21 ++++++++++++++++++++- drivers/timer/riscv_timer.c | 21 ++++++++++++++++++++- drivers/timer/sifive_clint_timer.c | 21 ++++++++++++++++++++- include/configs/ax25-ae350.h | 5 +++++ include/configs/qemu-riscv.h | 5 +++++ include/configs/sifive-fu540.h | 5 +++++ 6 files changed, 75 insertions(+), 3 deletions(-)Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Reviewed-by Rick Chen <[email protected]>Please check about the CI failure item:
https://gitlab.denx.de/u-boot/custodians/u-boot-riscv/-/jobs/196578404 for me (though I suspect it's really a 403).
404 for me also.
Followings are the errors from CI:
...
...
+====================================================
562 riscv: +microchip_mpfs_icicle563+drivers/timer/sifive_clint_timer.c: In function 'timer_early_get_rate':564+drivers/timer/sifive_clint_timer.c:28:9: error:
'RISCV_MMODE_TIMER_FREQ' undeclared (first use in this function) 565+ 28 | returnRISCV_MMODE_TIMER_FREQ;
566+ | ^~~~~~~~~~~~~~~~~~~~~~567+drivers/timer/sifive_clint_timer.c:28:9: note: each undeclared identifier is reported only once for each function it appears in568+drivers/timer/sifive_clint_timer.c: In function 'timer_early_get_count':569+drivers/timer/sifive_clint_timer.c:37:41: error:
'RISCV_MMODE_TIMERBASE' undeclared (first use in this function) 570+ 37 | returnreadq((void __iomem *)MTIME_REG(RISCV_MMODE_TIMERBASE)); 571+ | ^~~~~~~~~~~~~~~~~~~~~572+drivers/timer/sifive_clint_timer.c:15:36: note: in definition of macro 'MTIME_REG'
573+ 15 | #defineMTIME_REG(base)((ulong)(base) +0xbff8)
574+ | ^~~~575+drivers/timer/sifive_clint_timer.c:29:1: error: control reaches end of non-void function [-Werror=return-type]
576+ 29 | }
577+ | ^578+drivers/timer/sifive_clint_timer.c:38:1: error: control reaches end of non-void function [-Werror=return-type]
579+ 38 | }
580+cc1: all warnings being treated as errors
581+make[3]: *** [drivers/timer/sifive_clint_timer.o] Error 1 582+make[2]: *** [drivers/timer] Error 2
583+make[1]: *** [drivers] Error 2
584+make: *** [sub-make] Error 2
585 riscv: +sipeed_maix_bitm586+drivers/timer/sifive_clint_timer.c: In function 'timer_early_get_rate':587+drivers/timer/sifive_clint_timer.c:28:9: error:
'RISCV_MMODE_TIMER_FREQ' undeclared (first use in this function) 588+ 28 | returnRISCV_MMODE_TIMER_FREQ;
589+ | ^~~~~~~~~~~~~~~~~~~~~~590+drivers/timer/sifive_clint_timer.c:28:9: note: each undeclared identifier is reported only once for each function it appears in591+drivers/timer/sifive_clint_timer.c: In function 'timer_early_get_count':592+drivers/timer/sifive_clint_timer.c:37:41: error:
'RISCV_MMODE_TIMERBASE' undeclared (first use in this function) 593+ 37 | returnreadq((void __iomem *)MTIME_REG(RISCV_MMODE_TIMERBASE)); 594+ | ^~~~~~~~~~~~~~~~~~~~~595+drivers/timer/sifive_clint_timer.c:15:36: note: in definition of macro 'MTIME_REG'
596+ 15 | #defineMTIME_REG(base)((ulong)(base) +0xbff8)
597+ | ^~~~598+drivers/timer/sifive_clint_timer.c:29:1: error: control reaches end of non-void function [-Werror=return-type]
599+ 29 | }
600+ | ^601+drivers/timer/sifive_clint_timer.c:38:1: error: control reaches end of non-void function [-Werror=return-type]
602+ 38 | }
603+cc1: all warnings being treated as errors
604+make[3]: *** [drivers/timer/sifive_clint_timer.o] Error 1 605+make[2]: *** [drivers/timer] Error 2
606+make[1]: *** [drivers] Error 2
607+make: *** [sub-make] Error 2
608 riscv: +sipeed_maix_smode609+drivers/timer/riscv_timer.c: In function 'timer_early_get_rate':610+drivers/timer/riscv_timer.c:40:9: error: 'RISCV_SMODE_TIMER_FREQ' undeclared (first use in this function)
Quoted 8 lines
611+ 40 | return
RISCV_SMODE_TIMER_FREQ;
612+ | ^~~~~~~~~~~~~~~~~~~~~~613+drivers/timer/riscv_timer.c:40:9: note: each undeclared identifier is reported only once for each function it appears in614+drivers/timer/riscv_timer.c:41:1: error: control reaches end of non-void function [-Werror=return-type]
615+ 41 | }
616+ | ^
Will solve this in v3.
- Pragnesh
Quoted 9 lines
...
...Thanks,
RickQuoted 3 lines
Quoted 3 lines
--Sean
PATCH v2 1/2 trace: select TIMER_EARLY to avoid infinite recursion
In reply to Pragnesh PatelQuoted 14 lines · Pragnesh Patel
When tracing functions is enabled this adds calls to
__cyg_profile_func_enter()and__cyg_profile_func_exit()to the traced functions.
__cyg_profile_func_enter()and__cyg_profile_func_exit()invoketimer_get_us()to record the entry and exit time.
initr_dm()will makegd->dm_root= NULL andgd->timer= NULL, sotimer_get_us()->get_ticks()->dm_timer_init()will lead to an indefinite recursion.So select
TIMER_EARLYwhen tracing got enabled.
Quoted 8 lines
Signed-off-by Pragnesh Patel <[email protected]>---
Changes in v2:
- new patchlib/Kconfig | 1 + 1 file changed, 1 insertion(+)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v2 1/2 trace: select TIMER_EARLY to avoid infinite recursion
Quoted 19 lines
From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
Sent: Tuesday, December 22, 2020 2:23 PM
To: u-boot at lists.denx.de
Cc: atish.patra at wdc.com; palmerdabbelt at google.com; bmeng.cn at gmail.com; paul.walmsley at sifive.com; anup.patel at wdc.com; sagar.kadam at sifive.com; Rick Jian-Zhi Chen(???); pragnesh.patel at openfive.com; Pragnesh Patel; Simon Glass; Stefan Roese; Joao Marcos Costa; Reuben Dowle; Weijie Gao; Marcin Juszkiewicz; Michael Walle; Marek Szyprowski; Keerthy
Subject: [PATCH v2 1/2] trace: selectTIMER_EARLYto avoid infinite recursionWhen tracing functions is enabled this adds calls to
__cyg_profile_func_enter()and__cyg_profile_func_exit()to the traced functions.
__cyg_profile_func_enter()and__cyg_profile_func_exit()invoketimer_get_us()to record the entry and exit time.
initr_dm()will makegd->dm_root= NULL andgd->timer= NULL, sotimer_get_us()->get_ticks()->dm_timer_init()will lead to an indefinite recursion.So select
TIMER_EARLYwhen tracing got enabled.
Quoted 8 lines
Signed-off-by Pragnesh Patel <[email protected]>---
Changes in v2:
- new patchlib/Kconfig | 1 + 1 file changed, 1 insertion(+)