packages: Add SELinux modules to some packages
cover packages: Add SELinux modules to some packages
Hello everyone,
Following the recent support for the SELinux refpolicy and the ability for packages to select their own SELinux module in the refpolicy [1], this series adds a first batch of matching between packages and their respective module.
This series focuses on the tools that are impacted by the following modules in the refpolicy [2] :
- services/networkmanager, which adds support for :
- dhcp
- iwd
- network-manager
- wpa_supplicant
- system/ipatbles, which adds support for :
- ebtables
- ipset
- iptables
- nftables
- admin/netutils, which adds support for :
- fping
- iputils
- mtr
- nmap
- tcpdump
- services/entropyd, which adds support for :
- haveged
- jitterentropy-library
With this series, the above-mentionned tools can now be used on systems that have SELinux enabled.
This series was split per-package, which generates lots of one-liner patches. Due to the nature of the changes, I expect more patches like that to follow, so we might also use a "one package per module" approach if you want.
Thanks,
Maxime
[1] : 0228f521d6 package/refpolicy: allow packages to select SELinux modules
[2] : https://github.com/SELinuxProject/refpolicy
Maxime Chevallier (15):
packages/dhcp: add SELinux module package/iwd: add SELinux module package/network-manager: add SELinux module package/wpa_supplicant: add SELinux module package/ebtables: add SELinux module package/ipset: add SELinux module package/iptables: add SELinux module package/nftables: add SELinux module package/fping: add SELinux module package/iputils: add SELinux module package/mtr: add SELinux module package/nmap: add SELinux module package/tcpdump: add SELinux module package/haveged: add SELinux module package/jitterentropy-library: add SELinux module
package/dhcp/dhcp.mk | 1 + package/ebtables/ebtables.mk | 1 + package/fping/fping.mk | 1 + package/haveged/haveged.mk | 1 + package/ipset/ipset.mk | 1 + package/iptables/iptables.mk | 2 ++ package/iputils/iputils.mk | 1 + package/iwd/iwd.mk | 1 + package/jitterentropy-library/jitterentropy-library.mk | 1 + package/mtr/mtr.mk | 1 + package/network-manager/network-manager.mk | 1 + package/nftables/nftables.mk | 1 + package/nmap/nmap.mk | 1 + package/tcpdump/tcpdump.mk | 1 + package/wpa_supplicant/wpa_supplicant.mk | 1 + 15 files changed, 16 insertions(+)
Signature · 1 line
2.25.4
PATCH 1/15 packages/dhcp: add SELinux module
Support for dhcp is added by the services/networkmanager module in the SELinux repolicy.
Add this information so that dhcp can be used when SELinux is enabled on the system.
--- package/dhcp/dhcp.mk | 1 + 1 file changed, 1 insertion(+)
package/dhcp/dhcp.mk +1 -0
@@ -10,6 +10,7 @@ DHCP_INSTALL_STAGING = YES DHCP_LICENSE = MPL-2.0 DHCP_LICENSE_FILES = LICENSE DHCP_DEPENDENCIES = bind +DHCP_SELINUX_MODULES = networkmanager # use libtool-enabled configure.ac define DHCP_LIBTOOL_AUTORECONF
Signature · 1 line
2.25.4
PATCH 2/15 package/iwd: add SELinux module
In reply to Maxime ChevallierSupport for iwd and its configuration files is added by the services/networkmanager module in the SELinux refpolicy.
--- package/iwd/iwd.mk | 1 + 1 file changed, 1 insertion(+)
package/iwd/iwd.mk +1 -0
@@ -11,6 +11,7 @@ IWD_LICENSE = LGPL-2.1+ IWD_LICENSE_FILES = COPYING # sources from git, no configure script provided IWD_AUTORECONF = YES +IWD_SELINUX_MODULES = networkmanager IWD_CONF_OPTS = \ --disable-manual-pages \
Signature · 1 line
2.25.4
PATCH 3/15 package/network-manager: add SELinux module
In reply to Maxime ChevallierSupport for NetworkManager is added by the services/networkmanager module in the SELinux refpolicy.
--- package/network-manager/network-manager.mk | 1 + 1 file changed, 1 insertion(+)
package/network-manager/network-manager.mk +1 -0
@@ -13,6 +13,7 @@ NETWORK_MANAGER_DEPENDENCIES = host-pkgconf udev gnutls libglib2 \ libgcrypt wireless_tools util-linux host-intltool readline libndp NETWORK_MANAGER_LICENSE = GPL-2.0+ (app), LGPL-2.1+ (libnm) NETWORK_MANAGER_LICENSE_FILES = COPYING COPYING.LGPL CONTRIBUTING +NETWORK_MANAGER_SELINUX_MODULES = networkmanager NETWORK_MANAGER_CONF_ENV = \ ac_cv_path_LIBGCRYPT_CONFIG=$(STAGING_DIR)/usr/bin/libgcrypt-config \
Signature · 1 line
2.25.4
PATCH 4/15 package/wpa_supplicant: add SELinux module
In reply to Maxime ChevallierSupport for wpa_supplicant is added by the services/networkmanager module in the SELinux refpolicy.
--- package/wpa_supplicant/wpa_supplicant.mk | 1 + 1 file changed, 1 insertion(+)
package/wpa_supplicant/wpa_supplicant.mk +1 -0
@@ -14,6 +14,7 @@ WPA_SUPPLICANT_DBUS_OLD_SERVICE = fi.epitest.hostap.WPASupplicant WPA_SUPPLICANT_DBUS_NEW_SERVICE = fi.w1.wpa_supplicant1 WPA_SUPPLICANT_CFLAGS = $(TARGET_CFLAGS) -I$(STAGING_DIR)/usr/include/libnl3/ WPA_SUPPLICANT_LDFLAGS = $(TARGET_LDFLAGS) +WPA_SUPPLICANT_SELINUX_MODULES = networkmanager # 0001-AP-Silently-ignore-management-frame-from-unexpected-.patch WPA_SUPPLICANT_IGNORE_CVES += CVE-2019-16275
Signature · 1 line
2.25.4
PATCH 5/15 package/ebtables: add SELinux module
In reply to Maxime ChevallierSupport for ebtables is added in the system/iptables module in the SELinux refpolicy.
--- package/ebtables/ebtables.mk | 1 + 1 file changed, 1 insertion(+)
package/ebtables/ebtables.mk +1 -0
@@ -8,6 +8,7 @@ EBTABLES_VERSION = 2.0.11 EBTABLES_SITE = http://ftp.netfilter.org/pub/ebtables EBTABLES_LICENSE = GPL-2.0+ EBTABLES_LICENSE_FILES = COPYING +EBTABLES_SELINUX_MODULES = iptables ifeq ($(BR2_PACKAGE_EBTABLES_UTILS_SAVE),y) define EBTABLES_INSTALL_TARGET_UTILS_SAVE
Signature · 1 line
2.25.4
PATCH 6/15 package/ipset: add SELinux module
In reply to Maxime ChevallierSupport for ipset is added by the system/iptables module in the SELinux refpolicy.
--- package/ipset/ipset.mk | 1 + 1 file changed, 1 insertion(+)
package/ipset/ipset.mk +1 -0
@@ -12,5 +12,6 @@ IPSET_CONF_OPTS = --with-kmod=no IPSET_LICENSE = GPL-2.0 IPSET_LICENSE_FILES = COPYING IPSET_INSTALL_STAGING = YES +IPSET_SELINUX_MODULES = iptables $(eval $(autotools-package))
Signature · 1 line
2.25.4
PATCH 7/15 package/iptables: add SELinux module
In reply to Maxime ChevallierSupport for iptables is adde by the system/iptables module in the SELinux refpolicy.
--- package/iptables/iptables.mk | 2 ++ 1 file changed, 2 insertions(+)
package/iptables/iptables.mk +2 -0
@@ -12,6 +12,8 @@ IPTABLES_DEPENDENCIES = host-pkgconf \ $(if $(BR2_PACKAGE_LIBNETFILTER_CONNTRACK),libnetfilter_conntrack) IPTABLES_LICENSE = GPL-2.0 IPTABLES_LICENSE_FILES = COPYING +IPTABLES_SELINUX_MODULES = iptables + # Building static causes ugly warnings on some plugins IPTABLES_CONF_OPTS = --libexecdir=/usr/lib --with-kernel=$(STAGING_DIR)/usr \ $(if $(BR2_STATIC_LIBS),,--disable-static)
Signature · 1 line
2.25.4
PATCH 8/15 package/nftables: add SELinux module
In reply to Maxime ChevallierSupport for nft is added by the system/iptables module in the SELinux refpolicy.
--- package/nftables/nftables.mk | 1 + 1 file changed, 1 insertion(+)
package/nftables/nftables.mk +1 -0
@@ -11,6 +11,7 @@ NFTABLES_DEPENDENCIES = libmnl libnftnl host-pkgconf $(TARGET_NLS_DEPENDENCIES) NFTABLES_LICENSE = GPL-2.0 NFTABLES_LICENSE_FILES = COPYING NFTABLES_CONF_OPTS = --disable-man-doc --disable-pdf-doc +NFTABLES_SELINUX_MODULES = iptables ifeq ($(BR2_PACKAGE_GMP),y) NFTABLES_DEPENDENCIES += gmp
Signature · 1 line
2.25.4
PATCH 9/15 package/fping: add SELinux module
In reply to Maxime ChevallierSupport for fping is added by the admin/netutils module in the SELinux refpolicy.
--- package/fping/fping.mk | 1 + 1 file changed, 1 insertion(+)
package/fping/fping.mk +1 -0
@@ -8,5 +8,6 @@ FPING_VERSION = 5.0 FPING_SITE = http://fping.org/dist FPING_LICENSE = BSD-like FPING_LICENSE_FILES = COPYING +FPING_SELINUX_MODULES = netutils $(eval $(autotools-package))
Signature · 1 line
2.25.4
PATCH 10/15 package/iputils: add SELinux module
In reply to Maxime ChevallierSupport for the iputils is added by the admin/netutils module in the SELinux refpolicy.
--- package/iputils/iputils.mk | 1 + 1 file changed, 1 insertion(+)
package/iputils/iputils.mk +1 -0
@@ -16,6 +16,7 @@ IPUTILS_SITE = $(call github,iputils,iputils,s$(IPUTILS_VERSION)) IPUTILS_LICENSE = GPL-2.0+, BSD-3-Clause IPUTILS_LICENSE_FILES = LICENSE Documentation/LICENSE.BSD3 Documentation/LICENSE.GPL2 IPUTILS_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) +IPUTILS_SELINUX_MODULES = netutils # Selectively build binaries IPUTILS_CONF_OPTS += \
Signature · 1 line
2.25.4
PATCH 11/15 package/mtr: add SELinux module
In reply to Maxime ChevallierSupport for mtr is added by the admin/netutils module in the SELinux refpolicy.
--- package/mtr/mtr.mk | 1 + 1 file changed, 1 insertion(+)
package/mtr/mtr.mk +1 -0
@@ -11,5 +11,6 @@ MTR_CONF_OPTS = --without-gtk MTR_DEPENDENCIES = host-pkgconf $(if $(BR2_PACKAGE_NCURSES),ncurses) MTR_LICENSE = GPL-2.0 MTR_LICENSE_FILES = COPYING +MTR_SELINUX_MODULES = netutils $(eval $(autotools-package))
Signature · 1 line
2.25.4
PATCH 12/15 package/nmap: add SELinux module
In reply to Maxime ChevallierSupport for nmap is added by the admin/netutils module in the SELinux refpolicy.
--- package/nmap/nmap.mk | 1 + 1 file changed, 1 insertion(+)
package/nmap/nmap.mk +1 -0
@@ -12,6 +12,7 @@ NMAP_CONF_OPTS = --without-liblua --without-zenmap \ --with-libdnet=included NMAP_LICENSE = nmap license NMAP_LICENSE_FILES = COPYING +NMAP_SELINUX_MODULES = netutils # needed by libpcap NMAP_LIBS_FOR_STATIC_LINK += `$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`
Signature · 1 line
2.25.4
PATCH 13/15 package/tcpdump: add SELinux module
In reply to Maxime ChevallierSupport for tcpdump is added by the admin/netutils module in the SELinux refpolicy.
--- package/tcpdump/tcpdump.mk | 1 + 1 file changed, 1 insertion(+)
package/tcpdump/tcpdump.mk +1 -0
@@ -17,6 +17,7 @@ TCPDUMP_CONF_OPTS = \ --with-system-libpcap \ $(if $(BR2_PACKAGE_TCPDUMP_SMB),--enable-smb,--disable-smb) TCPDUMP_DEPENDENCIES = libpcap +TCPDUMP_SELINUX_MODULES = netutils # 0001-PPP-When-un-escaping-don-t-allocate-a-too-large-buffer.patch TCPDUMP_IGNORE_CVES += CVE-2020-8037
Signature · 1 line
2.25.4
PATCH 14/15 package/haveged: add SELinux module
In reply to Maxime ChevallierSupport for haveged is added by the services/entropyd module in the SELinux refpolicy.
--- package/haveged/haveged.mk | 1 + 1 file changed, 1 insertion(+)
package/haveged/haveged.mk +1 -0
@@ -8,6 +8,7 @@ HAVEGED_VERSION = 1.9.13 HAVEGED_SITE = $(call github,jirka-h,haveged,v$(HAVEGED_VERSION)) HAVEGED_LICENSE = GPL-3.0+ HAVEGED_LICENSE_FILES = COPYING +HAVEGED_SELINUX_MODULES = entropyd ifeq ($(BR2_sparc_v8)$(BR2_sparc_leon3),y) HAVEGED_CONF_OPTS += --enable-clock_gettime=yes
Signature · 1 line
2.25.4
PATCH 15/15 package/jitterentropy-library: add SELinux module
In reply to Maxime ChevallierSupport for the jitterentropy lib is added by the services/entropyd module in the SELinux refpolicy.
--- package/jitterentropy-library/jitterentropy-library.mk | 1 + 1 file changed, 1 insertion(+)
package/jitterentropy-library/jitterentropy-library.mk +1 -0
@@ -10,6 +10,7 @@ JITTERENTROPY_LIBRARY_LICENSE = GPL-2.0 or BSD-3-Clause JITTERENTROPY_LIBRARY_LICENSE_FILES = COPYING COPYING.bsd COPYING.gplv2 JITTERENTROPY_LIBRARY_INSTALL_STAGING = YES JITTERENTROPY_LIBRARY_INSTALL_TARGETS = install-includes +JITTERENTROPY_LIBRARY_SELINUX_MODULES = entropyd ifeq ($(BR2_STATIC_LIBS)$(BR2_SHARED_STATIC_LIBS),y) JITTERENTROPY_LIBRARY_BUILD_TARGETS += jitterentropy-static
Signature · 1 line
2.25.4
cover packages: Add SELinux modules to some packages
In reply to Maxime ChevallierHi Maxime,
Quoting Maxime Chevallier (2020-12-22 16:07:21)
Quoted 5 lines
Following the recent support for the SELinux refpolicy and the ability for packages to select their own SELinux module in the refpolicy [1], this series adds a first batch of matching between packages and their respective module.
Nice to see packages using this feature :)
Quoted 5 lines
This series focuses on the tools that are impacted by the following modules in the refpolicy [2] :
- services/networkmanager, which adds support for :
- dhcp
I'm not sure about this one. When looking at the module definitions dhclient and dhcpcd seem to be supported by system/sysnetwork rather than than by services/networkmanager. (Haven't built an image to test though).
Quoted 10 lines
- iwd
- network-manager
-wpa_supplicant- system/ipatbles, which adds support for :
- ebtables
- ipset
- iptables
- nftables
Quoted 3 lines
- admin/netutils, which adds support for :
- fping
- iputils
iputils can install lots of utilities based on the configuration, many of which are supported by admin/netutils. Some are not supported in the refpolicy, and some by other modules, such as rdisc or tftpd.
I think the selinux module selection should be conditional depending on the utilities installed by the iputils package, to avoid installing an unused selinux module and to fix the support of others.
Quoted 7 lines
- mtr
- nmap
- tcpdump- services/entropyd, which adds support for :
- haveged
- jitterentropy-library
The other selinux module selections LGTM.
Quoted 10 lines
With this series, the above-mentionned tools can now be used on systems that have SELinux enabled.
This series was split per-package, which generates lots of one-liner patches. Due to the nature of the changes, I expect more patches like that to follow, so we might also use a "one package per module" approach if you want.
Maxime Chevallier (15):
packages/dhcp: add SELinux module
Nitpick: s/packages/package/
Quoted 6 lines
package/iwd: add SELinux module
package/network-manager: add SELinux module
package/wpa_supplicant: add SELinux module
package/ebtables: add SELinux module
package/ipset: add SELinux module
package/iptables: add SELinux module
Quoted 8 lines
package/nftables: add SELinux module package/fping: add SELinux module package/iputils: add SELinux module package/mtr: add SELinux module package/nmap: add SELinux module package/tcpdump: add SELinux module package/haveged: add SELinux module package/jitterentropy-library: add SELinux module
Thanks!
Antoine
cover packages: Add SELinux modules to some packages
Hi Antoine,
Thanks for the review !
Quoted 14 lines · On Tue, 22 Dec 2020 16:54:55 +0100 Antoine Tenart <[email protected]> wrote:
Hi Maxime,
Quoting Maxime Chevallier (2020-12-22 16:07:21)
Quoted 5 lines
Following the recent support for the SELinux refpolicy and the ability for packages to select their own SELinux module in the refpolicy [1], this series adds a first batch of matching between packages and their respective module.
Nice to see packages using this feature :)
Quoted 3 lines
This series focuses on the tools that are impacted by the following modules in the refpolicy [2] :
Quoted 7 lines
Quoted 2 lines
- services/networkmanager, which adds support for :
- dhcpI'm not sure about this one. When looking at the module definitions dhclient and dhcpcd seem to be supported by system/sysnetwork rather than than by services/networkmanager. (Haven't built an image to test though).
You're correct, I'll remove that from the list for now. It does seem that services/networkmanager also references some files in /etc/dhcp, hence the confusion.
Quoted 14 lines
Quoted 10 lines
- iwd
- network-manager
-wpa_supplicant- system/ipatbles, which adds support for :
- ebtables
- ipset
- iptables
- nftablesQuoted 3 lines
- admin/netutils, which adds support for :
- fping
- iputils
Quoted 7 lines
iputils can install lots of utilities based on the configuration, many of which are supported by admin/netutils. Some are not supported in the refpolicy, and some by other modules, such as rdisc or tftpd.
I think the selinux module selection should be conditional depending on the utilities installed by the iputils package, to avoid installing an unused selinux module and to fix the support of others.
You're right, I'll add the conditionnals :)
Quoted 9 lines
Quoted 7 lines
- mtr
- nmap
- tcpdump- services/entropyd, which adds support for :
- haveged
- jitterentropy-libraryThe other selinux module selections LGTM.
Thanks for the thourough review !
Maxime
Quoted 30 lines
Quoted 10 lines
With this series, the above-mentionned tools can now be used on systems that have SELinux enabled.
This series was split per-package, which generates lots of one-liner patches. Due to the nature of the changes, I expect more patches like that to follow, so we might also use a "one package per module" approach if you want.
Maxime Chevallier (15):
packages/dhcp: add SELinux moduleNitpick: s/packages/package/
Quoted 6 lines
package/iwd: add SELinux module
package/network-manager: add SELinux module
package/wpa_supplicant: add SELinux module
package/ebtables: add SELinux module
package/ipset: add SELinux module
package/iptables: add SELinux moduleQuoted 8 lines
package/nftables: add SELinux module package/fping: add SELinux module package/iputils: add SELinux module package/mtr: add SELinux module package/nmap: add SELinux module package/tcpdump: add SELinux module package/haveged: add SELinux module package/jitterentropy-library: add SELinux module
Thanks!
Antoine
Signature · 3 lines
Maxime Chevallier, Bootlin Embedded Linux and kernel engineering https://bootlin.com