Skip to contentSkip to conversation

net: ipa: fix interconnect enable bug

PATCH Applied Alex Elder 3 participants 3 messages Dec 22, 2020 – Dec 23, 2020

Subsystems (3)
lore
Share & tools
lore

Alex Elder

author
#0 lore raw

PATCH 1/1 net: ipa: fix interconnect enable bug

When the core clock rate and interconnect bandwidth specifications were moved into configuration data, a copy/paste bug was introduced, causing the memory interconnect bandwidth to be set three times rather than enabling the three different interconnects.

Fix this bug.

Fixes 91d02f9551501 ("net: ipa: use config data for clocking")
---
 drivers/net/ipa/ipa_clock.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ipa/ipa_clock.c +2 -2
index 9dcf16f399b7a..135c393437f12 100644
@@ -115,13 +115,13 @@ static int ipa_interconnect_enable(struct ipa *ipa)
 		return ret;
 
 	data = &clock->interconnect_data[IPA_INTERCONNECT_IMEM];
-	ret = icc_set_bw(clock->memory_path, data->average_rate,
+	ret = icc_set_bw(clock->imem_path, data->average_rate,
 			 data->peak_rate);
 	if (ret)
 		goto err_memory_path_disable;
 
 	data = &clock->interconnect_data[IPA_INTERCONNECT_CONFIG];
-	ret = icc_set_bw(clock->memory_path, data->average_rate,
+	ret = icc_set_bw(clock->config_path, data->average_rate,
 			 data->peak_rate);
 	if (ret)
 		goto err_imem_path_disable;
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Alex Elder

When the core clock rate and interconnect bandwidth specifications were moved into configuration data, a copy/paste bug was introduced, causing the memory interconnect bandwidth to be set three times rather than enabling the three different interconnects.

Fix this bug.

Fixes 91d02f9551501 ("net: ipa: use config data for clocking")
Quoted 25 lines
---
  drivers/net/ipa/ipa_clock.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ipa/ipa_clock.c +2 -2
index 9dcf16f399b7a..135c393437f12 100644
@@ -115,13 +115,13 @@ static int ipa_interconnect_enable(struct ipa *ipa)
  		return ret;
 
  	data = &clock->interconnect_data[IPA_INTERCONNECT_IMEM];
-	ret = icc_set_bw(clock->memory_path, data->average_rate,
+	ret = icc_set_bw(clock->imem_path, data->average_rate,
  			 data->peak_rate);
  	if (ret)
  		goto err_memory_path_disable;
 
  	data = &clock->interconnect_data[IPA_INTERCONNECT_CONFIG];
-	ret = icc_set_bw(clock->memory_path, data->average_rate,
+	ret = icc_set_bw(clock->config_path, data->average_rate,
  			 data->peak_rate);
  	if (ret)
  		goto err_imem_path_disable;
maintainer Applied
#2 lore raw
Quoted 6 lines · On Tue, 22 Dec 2020 18:18:31 +0200 Georgi Djakov wrote:
Quoted 5 lines · Alex Elder

When the core clock rate and interconnect bandwidth specifications were moved into configuration data, a copy/paste bug was introduced, causing the memory interconnect bandwidth to be set three times rather than enabling the three different interconnects.

Quoted 6 lines
Quoted 4 lines

Fix this bug.

Fixes 91d02f9551501 ("net: ipa: use config data for clocking")

Applied, thanks!