KVM: arm64: Fix hyp_cpu_pm_{init,exit} __init annotation
Marc Zyngier
maintainerPATCH 1/1 KVM: arm64: Fix hyp_cpu_pm_{init,exit} __init annotation
The __init annotations on hyp_cpu_pm_{init,exit} are obviously incorrect, and the build system shouts at you if you enable DEBUG_SECTION_MISMATCH.
Nothing really bad happens as we never execute that code outside of the init context, but we can't label the callers as __int either, as kvm_init isn't __init itself. Oh well.
--- arch/arm64/kvm/arm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/kvm/arm.c +2 -2
@@ -1574,12 +1574,12 @@ static struct notifier_block hyp_init_cpu_pm_nb = { .notifier_call = hyp_init_cpu_pm_notifier, }; -static void __init hyp_cpu_pm_init (void ) +static void hyp_cpu_pm_init (void ) {if (!is_protected_kvm_enabled ())cpu_pm_register_notifier (&hyp_init_cpu_pm_nb); } -static void __init hyp_cpu_pm_exit (void ) +static void hyp_cpu_pm_exit (void ) {if (!is_protected_kvm_enabled ())cpu_pm_unregister_notifier (&hyp_init_cpu_pm_nb);
Signature · 6 lines
2.29.2 _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
Quoted 8 lines · Marc Zyngier
The
__initannotations on hyp_cpu_pm_{init,exit} are obviously incorrect, and the build system shouts at you if you enableDEBUG_SECTION_MISMATCH.Nothing really bad happens as we never execute that code outside of the init context, but we can't label the callers as
__inteither, askvm_initisn't__inititself. Oh well.Signed-off-by Marc Zyngier <[email protected]>
Quoted 30 lines
--- arch/arm64/kvm/arm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm64/kvm/arm.c +2
-2@@ -1574,12 +1574,12 @@ static struct notifier_block hyp_init_cpu_pm_nb = { .notifier_call = hyp_init_cpu_pm_notifier, }; -static void __init hyp_cpu_pm_init (void ) +static void hyp_cpu_pm_init (void ) {if (!is_protected_kvm_enabled ())cpu_pm_register_notifier (&hyp_init_cpu_pm_nb); } -static void __init hyp_cpu_pm_exit (void ) +static void hyp_cpu_pm_exit (void ) {if (!is_protected_kvm_enabled ())cpu_pm_unregister_notifier (&hyp_init_cpu_pm_nb);Signature · 6 lines
2.29.2 _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel