RDMA/hns: remove h from printk format specifier
Subsystems (2)
PATCH 1/1 RDMA/hns: remove h from printk format specifier
From: Tom Rix <[email protected]>
This change fixes the checkpatch warning described in this commit
commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]")
Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi].
--- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/hns/hns_roce_hw_v2.c +1 -1
@@ -361,7 +361,7 @@ static int check_send_valid(struct hns_roce_dev *hr_dev, }else if (unlikely (hr_qp->state ==IB_QPS_RESET || hr_qp->state ==IB_QPS_INIT || hr_qp->state ==IB_QPS_RTR )) { -ibdev_err (ibdev,"failed to post WQE, QP state %hhu!\n" , +ibdev_err (ibdev,"failed to post WQE, QP state %u!\n" , hr_qp->state);return -EINVAL ; }else if (unlikely (hr_dev->state >=HNS_ROCE_DEVICE_STATE_RST_DOWN )) {
Signature · 1 line
2.27.0
Quoted 5 lines · On Wed, Dec 23, 2020 at 11:30:41AM -0800, [email protected] wrote:
From: Tom Rix <[email protected]>
This change fixes the checkpatch warning described in this commit
commitcbacb5ab0aa0("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]")
Quoted 8 lines
Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi].
Signed-off-by Tom Rix <[email protected]>--- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks,
Quoted 5 lines · On Wed, Dec 23, 2020 at 11:30:41AM -0800, [email protected] wrote:
From: Tom Rix <[email protected]>
This change fixes the checkpatch warning described in this commit
commitcbacb5ab0aa0("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]")
Quoted 8 lines
Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi].
Signed-off-by Tom Rix <[email protected]>Reviewed-by Leon Romanovsky <[email protected]>--- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason