Skip to contentSkip to conversation

staging: ralink-gdma: Fixed blank line coding style issue

PATCH In review Ayoub Soussi 3 participants 3 messages Dec 23, 2020 – Dec 24, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: ralink-gdma: Fixed blank line coding style issue

Fixed coding style issue.

---
 drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/ralink-gdma/ralink-gdma.c +1 -0
index 655df317d0ee..a6181a167814 100644
@@ -122,6 +122,7 @@ struct gdma_dma_dev {
 	struct gdma_data *data;
 	void __iomem *base;
 	struct tasklet_struct task;
+
 	volatile unsigned long chan_issued;
 	atomic_t cnt;
 
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 12 lines · Ayoub Soussi

Fixed coding style issue.

---
 drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/ralink-gdma/ralink-gdma.c +0 -0
index 655df317d0ee..a6181a167814 100644

drivers/staging/ralink-gdma/ralink-gdma.c struct gdma_dma_dev { · line 127

Quoted 6 lines
drivers/staging/ralink-gdma/ralink-gdma.c +1 -0
@@ -122,6 +122,7 @@ struct gdma_dma_dev {
 	struct gdma_data *data;
 	void __iomem *base;
 	struct tasklet_struct task;
+
 	volatile unsigned long chan_issued;
 	atomic_t cnt;

With your knowledge of C, does this change look correct?

thanks,

greg k-h

#2 lore raw
In reply to Ayoub Soussi
Quoted 1 line · Ayoub Soussi

Fixed coding style issue.

[]

drivers/staging/ralink-gdma/ralink-gdma.c

Quoted 1 line
drivers/staging/ralink-gdma/ralink-gdma.c +0 -0

[]

drivers/staging/ralink-gdma/ralink-gdma.c struct gdma_dma_dev { · line 127

Quoted 7 lines
drivers/staging/ralink-gdma/ralink-gdma.c +1 -0
@@ -122,6 +122,7 @@ struct gdma_dma_dev {
  	struct gdma_data *data;
  	void __iomem *base;
  	struct tasklet_struct task;
+
  	volatile unsigned long chan_issued;
  	atomic_t cnt;

This is presumably a checkpatch false positive. checkpatch is not now nor never will be a perfect tool.

Please consider what you are doing and what the desired coding style is before submitting patches.