Skip to contentSkip to conversation

vidtv: psi: fix missing crc for PMT

PATCH In review Daniel W. S. Almeida 1 participant 1 message Dec 24, 2020

Subsystems (2)
lore
Share & tools
lore

Daniel W. S. Almeida

author maintainer
#0 lore raw

PATCH 1/3 vidtv: psi: fix missing crc for PMT

From: "Daniel W. S. Almeida" <[email protected]>

The PMT write function was refactored and this broke the CRC computation.

Fix it.

Fixes db9569f67e2e ("media: vidtv: cleanup PMT write table function")
---
 drivers/media/test-drivers/vidtv/vidtv_psi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/media/test-drivers/vidtv/vidtv_psi.c +3 -2
index 4511a2a98405..1724bb485e67 100644
@@ -1164,6 +1164,8 @@ u32 vidtv_psi_pmt_write_into(struct vidtv_psi_pmt_write_args *args)
 	struct vidtv_psi_desc *table_descriptor   = args->pmt->descriptor;
 	struct vidtv_psi_table_pmt_stream *stream = args->pmt->stream;
 	struct vidtv_psi_desc *stream_descriptor;
+	u32 crc = INITIAL_CRC;
+	u32 nbytes = 0;
 	struct header_write_args h_args = {
 		.dest_buf           = args->buf,
 		.dest_offset        = args->offset,
@@ -1181,6 +1183,7 @@ u32 vidtv_psi_pmt_write_into(struct vidtv_psi_pmt_write_args *args)
 		.new_psi_section    = false,
 		.is_crc             = false,
 		.dest_buf_sz        = args->buf_sz,
+		.crc                = &crc,
 	};
 	struct desc_write_args d_args   = {
 		.dest_buf           = args->buf,
@@ -1193,8 +1196,6 @@ u32 vidtv_psi_pmt_write_into(struct vidtv_psi_pmt_write_args *args)
 		.pid                = args->pid,
 		.dest_buf_sz        = args->buf_sz,
 	};
-	u32 crc = INITIAL_CRC;
-	u32 nbytes = 0;
 
 	vidtv_psi_pmt_table_update_sec_len(args->pmt);
 
Signature · 1 line
2.29.2