support/dependencies: set cmake version min to 3.15.3
PATCH 1/1 support/dependencies: set cmake version min to 3.15.3
This is required by uvw.
Fixes:
http://autobuild.buildroot.net/results/ab6/ab6954a65fd6d43c0674cb7a38a941102cb0dfe3/build-end.log
--- support/dependencies/check-host-cmake.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
support/dependencies/check-host-cmake.mk +1 -1
@@ -3,7 +3,7 @@ # package is bumped or a new one added, and it requires a higher # version, our cmake infra will catch it and build its own. # -BR2_CMAKE_VERSION_MIN = 3.10 +BR2_CMAKE_VERSION_MIN = 3.15.3 BR2_CMAKE_CANDIDATES ?= cmake cmake3 BR2_CMAKE ?= $(call suitable-host-package,cmake,\
Signature · 1 line
2.20.1
PATCH 1/1 support/dependencies: set cmake version min to 3.15.3
Quoted 6 lines · On Mon, 27 Apr 2020 23:43:52 -0600 James Hilliard <[email protected]>…
This is required by uvw.
Fixes:
http://autobuild.buildroot.net/results/ab6/ab6954a65fd6d43c0674cb7a38a941102cb0dfe3/build-end.logSigned-off-by James Hilliard <[email protected]>
The CMake version required by uvw was suddenly bumped from 3.2 to 3.15.3 in upstream commit 55d7782af5654cde8bba89071e13d240fd27ff3b.
From a quick look of it, I don't really see why it was bumped "so high". Could you instead try to revert to a minimum CMake version of 3.10 in uvw, and see if it builds ?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 support/dependencies: set cmake version min to 3.15.3
Hello,
Quoted 9 lines · Thomas Petazzoni
Quoted 5 lines · On Mon, 27 Apr 2020 23:43:52 -0600 James Hilliard <[email protected]>…
This is required by uvw.
Fixes:
http://autobuild.buildroot.net/results/ab6/ab6954a65fd6d43c0674cb7a38a941102cb0dfe3/build-end.log
Quoted 8 lines
Quoted 1 line
Signed-off-by James Hilliard <[email protected]>The CMake version required by uvw was suddenly bumped from 3.2 to 3.15.3 in upstream commit
55d7782af5654cde8bba89071e13d240fd27ff3b.From a quick look of it, I don't really see why it was bumped "so high". Could you instead try to revert to a minimum CMake version of 3.10 in uvw, and see if it builds ?
I tried to build the package with CMake 3.10 and it failed with:
CMake Error at CMakeLists.txt:22 (project):
No CMAKE_HOMEPAGE_URL_COMPILER could be found.
Tell CMake where to find the compiler by setting the CMake cache entry CMAKE_HOMEPAGE_URL_COMPILER to the full path to the compiler, or to the compiler name if it is in the PATH.
The minimum version I managed to compile with is 3.12
Quoted 12 lines
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Regards,
Asaf.
PATCH 1/1 support/dependencies: set cmake version min to 3.15.3
Quoted 27 lines · Asaf Kahlon
Hello,
Quoted 9 lines · Thomas Petazzoni
Quoted 5 lines · On Mon, 27 Apr 2020 23:43:52 -0600 James Hilliard <[email protected]>…
This is required by uvw.
Fixes:
http://autobuild.buildroot.net/results/ab6/ab6954a65fd6d43c0674cb7a38a941102cb0dfe3/build-end.logQuoted 8 lines
Quoted 1 line
Signed-off-by James Hilliard <[email protected]>The CMake version required by uvw was suddenly bumped from 3.2 to 3.15.3 in upstream commit
55d7782af5654cde8bba89071e13d240fd27ff3b.From a quick look of it, I don't really see why it was bumped "so high". Could you instead try to revert to a minimum CMake version of 3.10 in uvw, and see if it builds ?
I tried to build the package with CMake 3.10 and it failed with:
CMake Error at CMakeLists.txt:22 (project):
NoCMAKE_HOMEPAGE_URL_COMPILERcould be found.
Quoted 6 lines
Tell CMake where to find the compiler by setting the CMake cache entry
CMAKE_HOMEPAGE_URL_COMPILERto the full path to the compiler, or to the compiler name if it is in the PATH.The minimum version I managed to compile with is 3.12
Upstream seems to think the minimum is 3.13 see discussion here:
https://github.com/skypjack/uvw/issues/194
Quoted 15 lines
Quoted 12 lines
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildrootRegards,
Asaf.
PATCH 1/1 support/dependencies: set cmake version min to 3.15.3
Hello,
Quoted 29 lines · James Hilliard
Quoted 27 lines · Asaf Kahlon
Hello,
Quoted 9 lines · Thomas Petazzoni
Quoted 5 lines · On Mon, 27 Apr 2020 23:43:52 -0600 James Hilliard <[email protected]>…
This is required by uvw.
Fixes:
http://autobuild.buildroot.net/results/ab6/ab6954a65fd6d43c0674cb7a38a941102cb0dfe3/build-end.logQuoted 8 lines
Quoted 1 line
Signed-off-by James Hilliard <[email protected]>The CMake version required by uvw was suddenly bumped from 3.2 to 3.15.3 in upstream commit
55d7782af5654cde8bba89071e13d240fd27ff3b.From a quick look of it, I don't really see why it was bumped "so high". Could you instead try to revert to a minimum CMake version of 3.10 in uvw, and see if it builds ?
I tried to build the package with CMake 3.10 and it failed with:
CMake Error at CMakeLists.txt:22 (project):
NoCMAKE_HOMEPAGE_URL_COMPILERcould be found.
Quoted 8 lines
Quoted 6 lines
Tell CMake where to find the compiler by setting the CMake cache entry
CMAKE_HOMEPAGE_URL_COMPILERto the full path to the compiler, or to the compiler name if it is in the PATH.The minimum version I managed to compile with is 3.12
Upstream seems to think the minimum is 3.13 see discussion here:
https://github.com/skypjack/uvw/issues/194
According to this issue, uvw needs at least 3.12 and for some features even 3.13.
Anyway, it seems like we have to bump our minimal required version in order to make sure
uvw builds correctly.
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Quoted 2 lines
Quoted 2 lines
Regards,
Asaf.
Regards,
Asaf.
PATCH 1/1 support/dependencies: set cmake version min to 3.15.3
In reply to James HilliardJames, All,
Sorry to come back to that one so late...
On 2020-04-27 23:43 -0600, James Hilliard spake thusly:
Quoted 6 lines
This is required by uvw.
Fixes:
http://autobuild.buildroot.net/results/ab6/ab6954a65fd6d43c0674cb7a38a941102cb0dfe3/build-end.logSigned-off-by James Hilliard <[email protected]>
Following the discussion on this thread back at the time, it turned out that the real minimum version was in fact 3.13, not 3.15, and it still is, but I can't see a v2 of that patch changing to just 3.13.
Furthermore, I've now applied another, nore recent, patch by Fabrice, who provided a better commit log at explaining another good reason to bump to 3.15.
Thanks!
Regards,
Yann E. MORIN.
Quoted 24 lines
--- support/dependencies/check-host-cmake.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)support/dependencies/check-host-cmake.mk +1
-1@@ -3,7 +3,7 @@ # package is bumped or a new one added, and it requires a higher # version, our cmake infra will catch it and build its own. # -BR2_CMAKE_VERSION_MIN = 3.10 +BR2_CMAKE_VERSION_MIN = 3.15.3 BR2_CMAKE_CANDIDATES ?= cmake cmake3 BR2_CMAKE ?= $(call suitable-host-package,cmake,\Signature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'