Skip to contentSkip to conversation

regulator: qcom-rpmh: fix build after QCOM_COMMAND_DB is tristate

PATCH In review Randy Dunlap 3 participants 3 messages Dec 25, 2020 – Dec 28, 2020 Voltage and current regulator framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regulator: qcom-rpmh: fix build after QCOM_COMMAND_DB is tristate

Restrict REGULATOR_QCOM_RPMH to QCOM_COMMAND_DB it the latter is enabled.

Fixes this build error:
microblaze-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_probe':
(.text+0x354): undefined reference to `cmd_db_read_addr'

Fixes 778279f4f5e4 ("soc: qcom: cmd-db: allow loading as a module")
Cc Lina Iyer <[email protected]>
Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
---
 drivers/regulator/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/regulator/Kconfig +1 -0
@@ -881,6 +881,7 @@ config REGULATOR_QCOM_RPM
 config REGULATOR_QCOM_RPMH
 	tristate "Qualcomm Technologies, Inc. RPMh regulator driver"
 	depends on QCOM_RPMH || (QCOM_RPMH=n && COMPILE_TEST)
+	depends on QCOM_COMMAND_DB || !QCOM_COMMAND_DB
 	help
 	  This driver supports control of PMIC regulators via the RPMh hardware
 	  block found on Qualcomm Technologies Inc. SoCs.  RPMh regulator
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Randy Dunlap

Restrict REGULATOR_QCOM_RPMH to QCOM_COMMAND_DB it the latter is enabled.

Fixes this build error:
microblaze-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_probe':
(.text+0x354): undefined reference to `cmd_db_read_addr'

Quoted 6 lines
Fixes 778279f4f5e4 ("soc: qcom: cmd-db: allow loading as a module")
Cc Lina Iyer <[email protected]>
Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Quoted 14 lines

---
drivers/regulator/Kconfig | 1 +

1 file changed, 1 insertion(+)
drivers/regulator/Kconfig +0 -0
@@ -881,6 +881,7 @@ config REGULATOR_QCOM_RPM

config REGULATOR_QCOM_RPMH

	tristate "Qualcomm Technologies, Inc. RPMh regulator driver"
	depends on QCOM_RPMH || (QCOM_RPMH=n && COMPILE_TEST)
drivers/regulator/Kconfig +1 -0
+	depends on QCOM_COMMAND_DB || !QCOM_COMMAND_DB

help
This driver supports control of PMIC regulators via the RPMh hardware block found on Qualcomm Technologies Inc. SoCs. RPMh regulator

maintainer
#2 lore raw
In reply to Randy Dunlap
Quoted 5 lines · Randy Dunlap

Restrict REGULATOR_QCOM_RPMH to QCOM_COMMAND_DB it the latter is enabled.

Fixes this build error:
microblaze-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_probe':
(.text+0x354): undefined reference to `cmd_db_read_addr'

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: qcom-rpmh: fix build after QCOM_COMMAND_DB is tristate

      commit: ac6b559d818981406e587f4784777e9112d553f4

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark