Skip to contentSkip to conversation

mfd: ab8500-debugfs: Remove extraneous curly brace

PATCH In review Nathan Chancellor 2 participants 2 messages Dec 26, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: ab8500-debugfs: Remove extraneous curly brace

Clang errors:

../drivers/mfd/ab8500-debugfs.c:1526:2: error: non-void function does not return a value [-Werror,-Wreturn-type]

        }
        ^
../drivers/mfd/ab8500-debugfs.c:1528:2: error: expected identifier or '('
return 0;
        ^

../drivers/mfd/ab8500-debugfs.c:1529:1: error: extraneous closing brace ('}') }
^
3 errors generated.

The cleanup in ab8500_interrupts_show left a curly brace around, remove it to fix the error.

Fixes 886c8121659d ("mfd: ab8500-debugfs: Remove the racy fiddling with irq_desc")
---
 drivers/mfd/ab8500-debugfs.c | 1 -
 1 file changed, 1 deletion(-)
drivers/mfd/ab8500-debugfs.c +0 -1
index a32039366a93..1cf84562351e 100644
@@ -1521,7 +1521,6 @@ static int ab8500_interrupts_show(struct seq_file *s, void *p)
 			   line + irq_first,
 			   num_interrupts[line],
 			   num_wake_interrupts[line]);
-		}
 		seq_putc(s, '\n');
 	}
 

base-commit: 61d791365b72a89062fbbea69aa61479476da946

Signature · 1 line
2.30.0.rc1
#1 lore raw

drivers/mfd/ab8500-debugfs.c

Quoted 24 lines · Nathan Chancellor

Clang errors:

../drivers/mfd/ab8500-debugfs.c:1526:2: error: non-void function does not return a value [-Werror,-Wreturn-type]
        }
        ^
../drivers/mfd/ab8500-debugfs.c:1528:2: error: expected identifier or '(' return 0;
        ^
../drivers/mfd/ab8500-debugfs.c:1529:1: error: extraneous closing brace ('}') }
^
3 errors generated.

The cleanup in ab8500_interrupts_show left a curly brace around, remove it to fix the error.

Fixes 886c8121659d ("mfd: ab8500-debugfs: Remove the racy fiddling with irq_desc")

---
 drivers/mfd/ab8500-debugfs.c | 1 -

 1 file changed, 1 deletion(-)
drivers/mfd/ab8500-debugfs.c +0 -0

[]

drivers/mfd/ab8500-debugfs.c static int ab8500_interrupts_show(struct seq_file *s, void *p) · line 1524

Quoted 6 lines
drivers/mfd/ab8500-debugfs.c +0 -1
@@ -1521,7 +1521,6 @@ static int ab8500_interrupts_show(struct seq_file *s, void *p)
  			   line + irq_first,
  			   num_interrupts[line],
  			   num_wake_interrupts[line]);
-		}
  		seq_putc(s, '\n');

It looks as if this seq_putc should be removed as well as the seq_printf above already ends in a newline.

Quoted 5 lines
drivers/mfd/ab8500-debugfs.c +0 -0
  	}

base-commit: 61d791365b72a89062fbbea69aa61479476da946