imx: ahab: allow to bypass confirmation for ahab_close cmd
Subsystems (3)
PATCH v2 1/1 imx: ahab: allow to bypass confirmation for ahab_close cmd
Calling ahab_close cmd force the user to interact for confirmation.
This is not user-friendly when using this cmd during factory process.
Allow the user to pass '-y' option to bypass this confirmation.
---
v2:
- Fix commit log
--- arch/arm/mach-imx/imx8/ahab.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-imx/imx8/ahab.c +2 -1
@@ -301,10 +301,11 @@ static int confirm_close(void)static int do_ahab_close (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) { +int confirmed = argc >=2 && !strcmp (argv[1 ],"-y" );int err;u16 lc; -if (!confirm_close ()) +if (!confirmed && !confirm_close ())return -EACCES ; err =sc_seco_chip_info (-1 , &lc,NULL ,NULL ,NULL );
Signature · 1 line
2.25.1
PATCH v2 1/1 imx: ahab: allow to bypass confirmation for ahab_close cmd
Quoted 10 lines
Subject: [PATCH v2] imx: ahab: allow to bypass confirmation for
ahab_closecmdCalling
ahab_closecmd force the user to interact for confirmation.This is not user-friendly when using this cmd during factory process.
Allow the user to pass '-y' option to bypass this confirmation.
Signed-off-by Cl?ment P?ron <[email protected]>
Quoted 28 lines
---
v2:
- Fix commit log--- arch/arm/mach-imx/imx8/ahab.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/arch/arm/mach-imx/imx8/ahab.cindexcf3c7d762a74..b0865c2330a2100644arch/arm/mach-imx/imx8/ahab.c +2
-2@@ -301,10 +301,11 @@ static int confirm_close(void) static int do_ahab_close(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { +int confirmed = argc >=2 && !strcmp (argv[1 ],"-y" );int err;u16 lc; -if (!confirm_close ()) +if (!confirmed && !confirm_close ())return -EACCES ; err =sc_seco_chip_info (-1 , &lc,NULL ,NULL ,NULL ); --2.25.1
PATCH v2 1/1 imx: ahab: allow to bypass confirmation for ahab_close cmd
In reply to Clément PéronQuoted 7 lines · Cl?ment P?ron
Calling
ahab_closecmd force the user to interact for confirmation.This is not user-friendly when using this cmd during factory process.
Allow the user to pass '-y' option to bypass this confirmation.
Signed-off-by Cl?ment P?ron <[email protected]>
PATCH v2 1/1 imx: ahab: allow to bypass confirmation for ahab_close cmd
In reply to Clément PéronQuoted 6 lines
Calling
ahab_closecmd force the user to interact for confirmation. This is not user-friendly when using this cmd during factory process. Allow the user to pass '-y' option to bypass this confirmation.Signed-off-by Cl?ment P?ron <[email protected]>Reviewed-by Peng Fan <[email protected]>Acked-by Oliver Graute <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================