Skip to contentSkip to conversation

imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

PATCH New Fabio Estevam 4 participants 10 messages Dec 21, 2020 – Dec 26, 2020 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

When booting imx8mp-evk the following allocation error message is seen:

U-Boot 2021.01-rc3-00200-ge668bec96a5f (Dec 21 2020 - 14:36:42 -0300)

alloc space exhausted

Fix it by increasing CONFIG_SYS_MALLOC_F_LEN to 0x10000 like it is done on other i.MX8MM/8MN boards.

---
 configs/imx8mp_evk_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/imx8mp_evk_defconfig +1 -1
index cd5724e811ab..c34a10c2d906 100644
@@ -4,7 +4,7 @@ CONFIG_SYS_TEXT_BASE=0x40200000
 CONFIG_SPL_GPIO_SUPPORT=y
 CONFIG_SPL_LIBCOMMON_SUPPORT=y
 CONFIG_SPL_LIBGENERIC_SUPPORT=y
-CONFIG_SYS_MALLOC_F_LEN=0x8000
+CONFIG_SYS_MALLOC_F_LEN=0x10000
 CONFIG_ENV_SIZE=0x1000
 CONFIG_ENV_OFFSET=0x400000
 CONFIG_SYS_I2C_MXC_I2C1=y
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

Hello Fabio,

Quoted 10 lines

-----Original Message-----
From: Fabio Estevam <[email protected]>
Sent: Monday, December 21, 2020 7:41 PM
To: sbabic at denx.de
Cc: peng.fan at nxp.com; u-boot at lists.denx.de; ZHIZHIKIN Andrey <[email protected]>; uboot-imx at nxp.com; Fabio Estevam <[email protected]>
Subject: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

Quoted 8 lines

When booting imx8mp-evk the following allocation error message is seen:

U-Boot 2021.01-rc3-00200-ge668bec96a5f (Dec 21 2020 - 14:36:42 -0300)

alloc space exhausted

Fix it by increasing CONFIG_SYS_MALLOC_F_LEN to 0x10000 like it is done on other i.MX8MM/8MN boards.

It would be really great to get a review from Peng here, as his commit 28fff3fa1c ("imx: imx8mp_evk: fix boot issue") changed exactly this option from 0x10000 to 0x8000.

I've tested my local build with your patch and it boots OK, hence I cannot seem to find a reasoning why the early malloc area size has been halved with above commit.

Quoted 20 lines
---
 configs/imx8mp_evk_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/imx8mp_evk_defconfig +0 -0
index cd5724e811ab..c34a10c2d906 100644
@@ -4,7 +4,7 @@ CONFIG_SYS_TEXT_BASE=0x40200000

CONFIG_SPL_GPIO_SUPPORT=y CONFIG_SPL_LIBCOMMON_SUPPORT=y CONFIG_SPL_LIBGENERIC_SUPPORT=y

configs/imx8mp_evk_defconfig +1 -2
-CONFIG_SYS_MALLOC_F_LEN=0x8000
+CONFIG_SYS_MALLOC_F_LEN=0x10000
 CONFIG_ENV_SIZE=0x1000
 CONFIG_ENV_OFFSET=0x400000
 CONFIG_SYS_I2C_MXC_I2C1=y
--
Quoted 1 line

2.17.1

author reviewer
#2 lore raw

PATCH 1/1 imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

Hi Andrey,

Quoted 2 lines · ZHIZHIKIN Andrey

It would be really great to get a review from Peng here, as his commit 28fff3fa1c ("imx: imx8mp_evk: fix boot issue") changed exactly this option from 0x10000 to 0x8000.

Yes, agreed.

Peng,

Please let us know if you are happy with this change.

Quoted 4 lines

I've tested my local build with your patch and it boots OK, hence I cannot seem to find a reasoning why the early malloc area size has been halved with above commit.

Thanks for reporting and testing it.

#3 lore raw

PATCH 1/1 imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

In reply to Fabio Estevam
Quoted 6 lines

Subject: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

When booting imx8mp-evk the following allocation error message is seen:

U-Boot 2021.01-rc3-00200-ge668bec96a5f (Dec 21 2020 - 14:36:42 -0300)

Quoted 7 lines

alloc space exhausted

Fix it by increasing CONFIG_SYS_MALLOC_F_LEN to 0x10000 like it is done on other i.MX8MM/8MN boards.

I think it might be the DM clk exhausted the space, we need find a way to improve that.

Thanks,
Peng.

Quoted 18 lines
---
 configs/imx8mp_evk_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/imx8mp_evk_defconfig +0 -0
index cd5724e811ab..c34a10c2d906 100644
@@ -4,7 +4,7 @@ CONFIG_SYS_TEXT_BASE=0x40200000

CONFIG_SPL_GPIO_SUPPORT=y CONFIG_SPL_LIBCOMMON_SUPPORT=y CONFIG_SPL_LIBGENERIC_SUPPORT=y

configs/imx8mp_evk_defconfig +1 -2
-CONFIG_SYS_MALLOC_F_LEN=0x8000
+CONFIG_SYS_MALLOC_F_LEN=0x10000
 CONFIG_ENV_SIZE=0x1000
 CONFIG_ENV_OFFSET=0x400000
 CONFIG_SYS_I2C_MXC_I2C1=y
--

2.17.1

author reviewer
#4 lore raw

PATCH 1/1 imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

Hi Tom and Stefano,

Quoted 9 lines · Peng Fan
Quoted 9 lines

Subject: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

When booting imx8mp-evk the following allocation error message is seen:

U-Boot 2021.01-rc3-00200-ge668bec96a5f (Dec 21 2020 - 14:36:42 -0300)

alloc space exhausted

Quoted 7 lines
Quoted 5 lines

Fix it by increasing CONFIG_SYS_MALLOC_F_LEN to 0x10000 like it is done on other i.MX8MM/8MN boards.

Please consider this one for 2021.01.

Thanks

#5 lore raw

PATCH 1/1 imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

Quoted 15 lines · Fabio Estevam

Hi Tom and Stefano,

Quoted 12 lines · Peng Fan
Quoted 12 lines

Subject: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

When booting imx8mp-evk the following allocation error message is seen:

U-Boot 2021.01-rc3-00200-ge668bec96a5f (Dec 21 2020 - 14:36:42 -0300)

alloc space exhausted

Fix it by increasing CONFIG_SYS_MALLOC_F_LEN to 0x10000 like it is done on other i.MX8MM/8MN boards.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Please consider this one for 2021.01.

Yes, I pick it up.

Regards,
Stefano

Quoted 2 lines

Thanks

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#6 lore raw

PATCH 1/1 imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

In reply to Peng Fan

All,

Quoted 1 line

Subject: RE: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

I am thinking to remove the CLK CCF support for i.MX8M, and use simple CLK DM. Do you agree?

Thanks,
Peng.

Quoted 42 lines
Quoted 7 lines

Subject: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

When booting imx8mp-evk the following allocation error message is seen:

U-Boot 2021.01-rc3-00200-ge668bec96a5f (Dec 21 2020 - 14:36:42 -0300)

Quoted 7 lines

alloc space exhausted

Fix it by increasing CONFIG_SYS_MALLOC_F_LEN to 0x10000 like it is done on other i.MX8MM/8MN boards.

I think it might be the DM clk exhausted the space, we need find a way to improve that.

Thanks,
Peng.

Quoted 6 lines
---
 configs/imx8mp_evk_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/configs/imx8mp_evk_defconfig index cd5724e811ab..c34a10c2d906

100644

Quoted 12 lines
configs/imx8mp_evk_defconfig +0 -0
@@ -4,7 +4,7 @@ CONFIG_SYS_TEXT_BASE=0x40200000

CONFIG_SPL_GPIO_SUPPORT=y CONFIG_SPL_LIBCOMMON_SUPPORT=y CONFIG_SPL_LIBGENERIC_SUPPORT=y

configs/imx8mp_evk_defconfig +1 -2
-CONFIG_SYS_MALLOC_F_LEN=0x8000
+CONFIG_SYS_MALLOC_F_LEN=0x10000
 CONFIG_ENV_SIZE=0x1000
 CONFIG_ENV_OFFSET=0x400000
 CONFIG_SYS_I2C_MXC_I2C1=y
--

2.17.1

author reviewer
#7 lore raw

PATCH 1/1 imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

Hi Peng,

Quoted 2 lines · Peng Fan

I am thinking to remove the CLK CCF support for i.MX8M, and use simple CLK DM. Do you agree?

As a minimal fix for 2021.01, I suggest that we go with my patch.

After 2021.01 is released we can consider using simple CLK DM.

Thanks

#8 lore raw

PATCH 1/1 imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

Quoted 10 lines

Subject: Re: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

Hi Peng,

Quoted 2 lines · Peng Fan

I am thinking to remove the CLK CCF support for i.MX8M, and use simple CLK DM. Do you agree?

As a minimal fix for 2021.01, I suggest that we go with my patch.

I agree.

Quoted 2 lines

After 2021.01 is released we can consider using simple CLK DM.

Sure. I need people agree on this before action, then prepare the stuff.

Thanks,
Peng

Quoted 2 lines

Thanks

#9 lore raw

PATCH 1/1 imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

In reply to Fabio Estevam
Quoted 10 lines

When booting imx8mp-evk the following allocation error message is seen:
U-Boot 2021.01-rc3-00200-ge668bec96a5f (Dec 21 2020 - 14:36:42 -0300) alloc space exhausted
Fix it by increasing CONFIG_SYS_MALLOC_F_LEN to 0x10000 like it is done on other i.MX8MM/8MN boards.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================