HID: uclogic: Improve support for Trust Panora
PATCH 1/1 HID: uclogic: Improve support for Trust Panora
After more discussions with the [libinput project][1], it has been determined that the uclogic driver provides better support for this tablet. Fortunately, the Trust Panora is physically and logically identical with the UGEE G5, despite having a different USB vendor and product ID.
[1]: https://gitlab.freedesktop.org/libinput/libinput/-/issues/482
--- drivers/hid/hid-quirks.c | 1 - drivers/hid/hid-uclogic-core.c | 2 ++ drivers/hid/hid-uclogic-params.c | 2 ++ 3 files changed, 4 insertions(+), 1 deletion(-)
drivers/hid/hid-quirks.c +0 -1
@@ -180,7 +180,6 @@ static const struct hid_device_id hid_quirks[] = { { HID_USB_DEVICE(USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS), HID_QUIRK_MULTI_INPUT }, { HID_USB_DEVICE(USB_VENDOR_ID_TPV, USB_DEVICE_ID_TPV_OPTICAL_TOUCHSCREEN_8882), HID_QUIRK_NOGET }, { HID_USB_DEVICE(USB_VENDOR_ID_TPV, USB_DEVICE_ID_TPV_OPTICAL_TOUCHSCREEN_8883), HID_QUIRK_NOGET }, - { HID_USB_DEVICE(USB_VENDOR_ID_TRUST, USB_DEVICE_ID_TRUST_PANORA_TABLET), HID_QUIRK_MULTI_INPUT | HID_QUIRK_HIDINPUT_FORCE }, { HID_USB_DEVICE(USB_VENDOR_ID_TURBOX, USB_DEVICE_ID_TURBOX_KEYBOARD), HID_QUIRK_NOGET }, { HID_USB_DEVICE(USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_KNA5), HID_QUIRK_MULTI_INPUT }, { HID_USB_DEVICE(USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_TWA60), HID_QUIRK_MULTI_INPUT },
drivers/hid/hid-uclogic-core.c +2 -0
@@ -371,6 +371,8 @@ static const struct hid_device_id uclogic_devices[] = { USB_DEVICE_ID_HUION_TABLET) }, {HID_USB_DEVICE (USB_VENDOR_ID_HUION , USB_DEVICE_ID_HUION_HS64) }, + { HID_USB_DEVICE(USB_VENDOR_ID_TRUST, + USB_DEVICE_ID_TRUST_PANORA_TABLET) }, { HID_USB_DEVICE(USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_HUION_TABLET) }, { HID_USB_DEVICE(USB_VENDOR_ID_UCLOGIC,
drivers/hid/hid-uclogic-params.c +2 -0
@@ -1045,6 +1045,8 @@ int uclogic_params_init(struct uclogic_params *params,uclogic_params_init_with_pen_unused (&p); }break ; +case VID_PID (USB_VENDOR_ID_TRUST , +USB_DEVICE_ID_TRUST_PANORA_TABLET ):case VID_PID (USB_VENDOR_ID_UGEE ,USB_DEVICE_ID_UGEE_TABLET_G5 ):/* Ignore non-pen interfaces */
Signature · 1 line
2.25.1
Quoted 9 lines · Cristian Klein
After more discussions with the [libinput project][1], it has been determined that the uclogic driver provides better support for this tablet. Fortunately, the Trust Panora is physically and logically identical with the UGEE G5, despite having a different USB vendor and product ID.
[1]: https://gitlab.freedesktop.org/libinput/libinput/-/issues/482
Signed-off-by Cristian Klein <[email protected]>
Applied, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs