Skip to contentSkip to conversation

staging: android: ashmem: Declared file operation with const keyword

PATCH In review jovin555 3 participants 3 messages Dec 28, 2020 – Jan 5, 2021 Staging

lore
Share & tools
lore

jovin555

author
#0 lore raw

PATCH 1/1 staging: android: ashmem: Declared file operation with const keyword

Warning found by checkpatch.pl script.

---
 drivers/staging/android/ashmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/android/ashmem.c +1 -1
index c05a214191da..f9cfa15b785f 100644
@@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
 
 static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
 {
-	static struct file_operations vmfile_fops;
+	static const struct file_operations vmfile_fops;
 	struct ashmem_area *asma = file->private_data;
 	int ret = 0;
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 12 lines · On Mon, Dec 28, 2020 at 12:13:00AM -0500, jovin555 wrote:

Warning found by checkpatch.pl script.

---
 drivers/staging/android/ashmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/android/ashmem.c +0 -0
index c05a214191da..f9cfa15b785f 100644

drivers/staging/android/ashmem.c ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, · line 373

Quoted 8 lines
drivers/staging/android/ashmem.c +1 -1
@@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
 
 static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
 {
-	static struct file_operations vmfile_fops;
+	static const struct file_operations vmfile_fops;
 	struct ashmem_area *asma = file->private_data;
 	int ret = 0;
 

Did you build your modified kernel with this change in it?

Always do so...

greg k-h

#2 lore raw
In reply to jovin555
Quoted 3 lines · On Mon, Dec 28, 2020 at 12:13:00AM -0500, jovin555 wrote:

Warning found by checkpatch.pl script.

Your Mama didn't name you "jovin555". You need to use your real name like signing a legal document. Same for the "From:" header.

regards,
dan carpenter