Skip to contentSkip to conversation

pinctrl: ralink: rt2880: fix '-Wmissing-prototypes' in init function

PATCH In review Sergio Paracuellos 2 participants 2 messages Dec 28, 2020 – Jan 4, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: ralink: rt2880: fix '-Wmissing-prototypes' in init function

Kernel test robot reported the following warning:
'warning: no previous prototype for 'rt2880_pinmux_init''. This function is the entry point for the platform driver and it is private to this driver. Hence declare it 'static' which is the correct thing to do fixing also this warning.

---
Hi Linus,

Just a note to let you know that this patch is rebased on the top of this series which are pending to be applied:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2020-December/149353.html

Thanks in advance for your time!

Best regards,
Sergio Paracuellos

 drivers/pinctrl/ralink/pinctrl-rt2880.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/ralink/pinctrl-rt2880.c +1 -1
index 983da62ff3be..1f8e8d5b71fd 100644
@@ -361,7 +361,7 @@ static struct platform_driver rt2880_pinmux_driver = {
 	},
 };
 
-int __init rt2880_pinmux_init(void)
+static int __init rt2880_pinmux_init(void)
 {
 	return platform_driver_register(&rt2880_pinmux_driver);
 }
Signature · 1 line
2.25.1
#1 lore raw
Quoted 8 lines · Sergio Paracuellos

Kernel test robot reported the following warning:
'warning: no previous prototype for 'rt2880_pinmux_init''. This function is the entry point for the platform driver and it is private to this driver. Hence declare it 'static' which is the correct thing to do fixing also this warning.

Patch applied.

Yours,
Linus Walleij