Skip to contentSkip to conversation

input, i8042: unbreak Pegatron C15B

PATCH Applied Alexey Dobriyan 3 participants 3 messages Dec 28, 2020 – Jan 4, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 input, i8042: unbreak Pegatron C15B

g++ reports

drivers/input/serio/i8042-x86ia64io.h:225:3: error: ‘.matches’ designator used multiple times in the same initializer list

C99 semantics is that last duplicated initialiser wins, so DMI entry gets overwritten.

Fixes a48491c65b51 ("Input: i8042 - add ByteSpeed touchpad to noloop table")

---

 drivers/input/serio/i8042-x86ia64io.h |    2 ++
 1 file changed, 2 insertions(+)
drivers/input/serio/i8042-x86ia64io.h +2 -0
@@ -219,6 +219,8 @@ static const struct dmi_system_id __initconst i8042_dmi_noloop_table[] = {
 			DMI_MATCH(DMI_SYS_VENDOR, "PEGATRON CORPORATION"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "C15B"),
 		},
+	},
+	{
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "ByteSpeed LLC"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "ByteSpeed Laptop C15B"),
maintainer Applied
#2 lore raw
In reply to Alexey Dobriyan
Quoted 9 lines · Alexey Dobriyan

g++ reports

drivers/input/serio/i8042-x86ia64io.h:225:3: error: ‘.matches’ designator used multiple times in the same initializer list

C99 semantics is that last duplicated initialiser wins, so DMI entry gets overwritten.

Fixes a48491c65b51 ("Input: i8042 - add ByteSpeed touchpad to noloop table")

Applied, thank you.

Signature · 1 line
Dmitry