Skip to contentSkip to conversation

rtw88: 8821c: apply CCK PD level which calculates from dynamic mechanism

PATCH In review Ping-Ke Shih 2 participants 4 messages Dec 28, 2020 – Jan 14, 2021 Realtek wireless driver (rtw88)

lore
Share & tools
lore

Ping-Ke Shih

author maintainer
#0 lore raw

PATCH 1/1 rtw88: 8821c: apply CCK PD level which calculates from dynamic mechanism

From: vincent_fann <[email protected]>

Hal function must follow the value that calculates from dynamic mechanism. Force to set new_lvl to 4 damages receiving ability. System will not able to reconnect to the AP if wifi unexpected disconnecting at this moment.

---
 drivers/net/wireless/realtek/rtw88/rtw8821c.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/net/wireless/realtek/rtw88/rtw8821c.c +0 -7
index fbfd85439d1f..74155c999ebb 100644
@@ -1022,12 +1022,6 @@ static void rtw8821c_phy_cck_pd_set(struct rtw_dev *rtwdev, u8 new_lvl)
 	u8 pd[CCK_PD_LV_MAX] = {3, 7, 13, 13, 13};
 	u8 cck_n_rx;
 
-	if (dm_info->min_rssi > 60) {
-		new_lvl = 4;
-		pd[4] = 0x1d;
-		goto set_cck_pd;
-	}
-
 	rtw_dbg(rtwdev, RTW_DBG_PHY, "lv: (%d) -> (%d)\n",
 		dm_info->cck_pd_lv[RTW_CHANNEL_WIDTH_20][RF_PATH_A], new_lvl);
 
@@ -1044,7 +1038,6 @@ static void rtw8821c_phy_cck_pd_set(struct rtw_dev *rtwdev, u8 new_lvl)
 
 	dm_info->cck_fa_avg = CCK_FA_AVG_RESET;
 
-set_cck_pd:
 	dm_info->cck_pd_lv[RTW_CHANNEL_WIDTH_20][RF_PATH_A] = new_lvl;
 	rtw_write32_mask(rtwdev, REG_PWRTH, 0x3f0000, pd[new_lvl]);
 	rtw_write32_mask(rtwdev, REG_PWRTH2, 0x1f0000,
Signature · 1 line
2.21.0
#1 lore raw
Quoted 7 lines · Ping-Ke Shih

From: vincent_fann <[email protected]>

Hal function must follow the value that calculates from dynamic mechanism. Force to set new_lvl to 4 damages receiving ability. System will not able to reconnect to the AP if wifi unexpected disconnecting at this moment.

The real name looks to be just a copy of username, badly configured git maybe? I can fix it during commit, how does Vincent format his name in regular email? Does this look ok:

Vincent Fann <[email protected]>

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
author maintainer
#2 lore raw
Quoted 8 lines · Kalle Valo
Quoted 6 lines · Ping-Ke Shih

From: vincent_fann <[email protected]>

Hal function must follow the value that calculates from dynamic mechanism. Force to set new_lvl to 4 damages receiving ability. System will not able to reconnect to the AP if wifi unexpected disconnecting at this moment.

Quoted 8 lines
Quoted 1 line

The real name looks to be just a copy of username, badly configured git maybe? I can fix it during commit, how does Vincent format his name in regular email? Does this look ok:

Vincent Fann <[email protected]>

Yes, it does.
Please help to fix it.

Thank you
---
Ping-Ke

#3 lore raw
In reply to Ping-Ke Shih
Quoted 8 lines · Ping-Ke Shih

From: Vincent Fann <[email protected]>

Hal function must follow the value that calculates from dynamic mechanism. Force to set new_lvl to 4 damages receiving ability. System will not able to reconnect to the AP if wifi unexpected disconnecting at this moment.

Patch applied to wireless-drivers-next.git, thanks.

840105e4f12f rtw88: 8821c: apply CCK PD level which calculates from dynamic mechanism

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches