common: Makefile: drop duplicated line
PATCH 1/3 common: Makefile: drop duplicated line
From: Peng Fan <[email protected]>
obj-$(CONFIG_$(SPL_TPL_)YMODEM_SUPPORT) += xyzModem.o is there, no need obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o
--- common/Makefile | 1 - 1 file changed, 1 deletion(-)
common/Makefile +0 -1
@@ -68,7 +68,6 @@ obj-$(CONFIG_DFU_OVER_USB) += dfu.o endif obj-$(CONFIG_SPL_HASH_SUPPORT) += hash.o obj-$(CONFIG_TPL_HASH_SUPPORT) += hash.o -obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o obj-$(CONFIG_SPL_LOAD_FIT) += common_fit.o obj-$(CONFIG_SPL_NET_SUPPORT) += miiphyutil.o obj-$(CONFIG_$(SPL_TPL_)OF_LIBFDT) += fdt_support.o
Signature · 1 line
2.28.0
PATCH 2/3 cmd: Makefile: build nvedit.c when needed
From: Peng Fan <[email protected]>
No need to build nvedit.c when CONFIG_$(SPL_)ENV_SUPPORT is n
--- cmd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
cmd/Makefile +1 -1
@@ -201,7 +201,7 @@ endif # !CONFIG_SPL_BUILD obj-$(CONFIG_$(SPL_)CMD_TLV_EEPROM) += tlv_eeprom.o # core command -obj-y += nvedit.o +obj-$(CONFIG_$(SPL_)ENV_SUPPORT)+= nvedit.o obj-$(CONFIG_CMD_BCM_EXT_UTILS) += broadcom/
Signature · 1 line
2.28.0
PATCH 2/3 cmd: Makefile: build nvedit.c when needed
Quoted 10 lines · Peng Fan (OSS)
From: Peng Fan <[email protected]>
No need to build
nvedit.cwhen CONFIG_$(SPL_)ENV_SUPPORT is nSigned-off-by Peng Fan <[email protected]>--- cmd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
PATCH 2/3 cmd: Makefile: build nvedit.c when needed
In reply to Peng Fan (OSS)Quoted 6 lines · Peng Fan (OSS)
From: Peng Fan <[email protected]>
No need to build
nvedit.cwhen CONFIG_$(SPL_)ENV_SUPPORT is nSigned-off-by Peng Fan <[email protected]>Reviewed-by Simon Glass <[email protected]>
This breaks a handful of PowerPC platforms that are using the original SPL/etc setup and do make use of environment.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210116/6378a026/attachment.sig>
PATCH 2/3 cmd: Makefile: build nvedit.c when needed
Quoted 6 lines
Subject: Re: [PATCH 2/3] cmd:
Makefile: buildnvedit.cwhen neededQuoted 2 lines · Peng Fan (OSS)
From: Peng Fan <[email protected]>
Quoted 7 lines
Quoted 4 lines
No need to build
nvedit.cwhen CONFIG_$(SPL_)ENV_SUPPORT is nSigned-off-by Peng Fan <[email protected]>Reviewed-by Simon Glass <[email protected]>This breaks a handful of PowerPC platforms that are using the original SPL/etc setup and do make use of environment.
Ah, please drop it.
Thanks,
Peng.
Quoted 3 lines
--
Tom
PATCH 3/3 armv8: Makefile: build cache files when needed
In reply to Peng Fan (OSS)From: Peng Fan <[email protected]>
If no need cache support, not build the cache files, such as in SPL.
--- arch/arm/cpu/armv8/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm/cpu/armv8/Makefile +3 -1
@@ -9,14 +9,16 @@ obj-y += cpu.o ifndef CONFIG_$(SPL_TPL_)TIMER obj-$(CONFIG_SYS_ARCH_TIMER) += generic_timer.o endif +ifndef CONFIG_$(SPL_)SYS_DCACHE_OFF obj-y += cache_v8.o +obj-y += cache.o +endif ifdef CONFIG_SPL_BUILD obj-$(CONFIG_ARMV8_SPL_EXCEPTION_VECTORS) += exceptions.o else obj-y += exceptions.o obj-y += exception_level.o endif -obj-y += cache.o obj-y += tlb.o obj-y += transition.o ifndef CONFIG_ARMV8_PSCI
Signature · 1 line
2.28.0
PATCH 3/3 armv8: Makefile: build cache files when needed
Quoted 5 lines · Peng Fan (OSS)
From: Peng Fan <[email protected]>
If no need cache support, not build the cache files, such as in SPL.
Signed-off-by Peng Fan <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210118/f63f82dc/attachment.sig>
PATCH 1/3 common: Makefile: drop duplicated line
In reply to Peng Fan (OSS)Quoted 10 lines · Peng Fan (OSS)
From: Peng Fan <[email protected]>
obj-$(CONFIG_$(SPL_TPL_)YMODEM_SUPPORT) += xyzModem.o is there, no need obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o
Signed-off-by Peng Fan <[email protected]>--- common/Makefile | 1 - 1 file changed, 1 deletion(-)
PATCH 1/3 common: Makefile: drop duplicated line
In reply to Peng Fan (OSS)Quoted 7 lines · Peng Fan (OSS)
From: Peng Fan <[email protected]>
obj-$(CONFIG_$(SPL_TPL_)YMODEM_SUPPORT) += xyzModem.o is there, no need obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o
Signed-off-by Peng Fan <[email protected]>Reviewed-by Simon Glass <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210118/8e846352/attachment.sig>