Skip to contentSkip to conversation

ASoC: AMD Renoir - add DMI entry for Lenovo ThinkPad X395

PATCH In review Jaroslav Kysela 2 participants 3 messages Dec 27, 2020 – Dec 28, 2020

Subsystems (3)
lore
Share & tools
lore

Jaroslav Kysela

author maintainer
#0 lore raw

PATCH v2 1/1 ASoC: AMD Renoir - add DMI entry for Lenovo ThinkPad X395

The ThinkPad X395 latop does not have the internal digital microphone connected to the AMD's ACP bridge, but it's advertised via BIOS. The internal microphone is connected to the HDA codec.

Use DMI to block the microphone PCM device for this platform.

---
 sound/soc/amd/renoir/rn-pci-acp3x.c | 7 +++++++
 1 file changed, 7 insertions(+)
sound/soc/amd/renoir/rn-pci-acp3x.c +7 -0
index 17ec35be73ac..deca8c7a0e87 100644
@@ -178,6 +178,13 @@ static const struct dmi_system_id rn_acp_quirk_table[] = {
 			DMI_EXACT_MATCH(DMI_BOARD_NAME, "20T6CTO1WW"),
 		}
 	},
+	{
+		/* Lenovo ThinkPad X395 */
+		.matches = {
+			DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "20NLCTO1WW"),
+		}
+	},
 	{}
 };
 
Signature · 1 line
2.29.2
maintainer
#1 lore raw

sound/soc/amd/renoir/rn-pci-acp3x.c static const struct dmi_system_id rn_acp_quirk_table[] = { · line 183

Quoted 6 lines · Jaroslav Kysela
sound/soc/amd/renoir/rn-pci-acp3x.c +3 -0
 			DMI_EXACT_MATCH(DMI_BOARD_NAME, "20T6CTO1WW"),
 		}
 	},
+	{
+		/* Lenovo ThinkPad X395 */
+		.matches = {

This has a context dependency on your previous patch so the two patches should've been a series, git can't figure out how to apply it independently.

maintainer
#2 lore raw
In reply to Jaroslav Kysela
Quoted 5 lines · Jaroslav Kysela

The ThinkPad X395 latop does not have the internal digital microphone connected to the AMD's ACP bridge, but it's advertised via BIOS. The internal microphone is connected to the HDA codec.

Use DMI to block the microphone PCM device for this platform.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: AMD Renoir - add DMI entry for Lenovo ThinkPad X395

      commit: 1f092d1c8819679d78a7d9c62a46d4939d217a9d

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark