EDAC/amd64: Tone down messages about missing PCI IDs
Subsystems (2)
Yazen Ghannam
maintainerPATCH 1/1 EDAC/amd64: Tone down messages about missing PCI IDs
From: Yazen Ghannam <[email protected]>
Give these messages a debug severity as they are really only useful to the module developers.
Also, drop the "(broken BIOS?)" phrase, since this can cause churn for BIOS folks. The PCI IDs needed by the module, at least on modern systems, are fixed in hardware.
Signed-off-by Yazen Ghannam <[email protected]>
--- drivers/edac/amd64_edac.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/edac/amd64_edac.c +4 -4
@@ -2665,7 +2665,7 @@ reserve_mc_sibling_devs(struct amd64_pvt *pvt, u16 pci_id1, u16 pci_id2)if (pvt->umc) { pvt->F0 =pci_get_related_function (pvt->F3->vendor, pci_id1, pvt->F3);if (!pvt->F0) { -amd64_err ("F0 not found, device 0x%x (broken BIOS?)\n" , pci_id1); +edac_dbg (1 ,"F0 not found, device 0x%x\n" , pci_id1);return -ENODEV ; }
@@ -2674,7 +2674,7 @@ reserve_mc_sibling_devs(struct amd64_pvt *pvt, u16 pci_id1, u16 pci_id2)pci_dev_put (pvt->F0); pvt->F0 =NULL ; -amd64_err ("F6 not found: device 0x%x (broken BIOS?)\n" , pci_id2); +edac_dbg (1 ,"F6 not found: device 0x%x\n" , pci_id2);return -ENODEV ; }
@@ -2691,7 +2691,7 @@ reserve_mc_sibling_devs(struct amd64_pvt *pvt, u16 pci_id1, u16 pci_id2)/* Reserve the ADDRESS MAP Device */ pvt->F1 =pci_get_related_function (pvt->F3->vendor, pci_id1, pvt->F3);if (!pvt->F1) { -amd64_err ("F1 not found: device 0x%x (broken BIOS?)\n" , pci_id1); +edac_dbg (1 ,"F1 not found: device 0x%x\n" , pci_id1);return -ENODEV ; }
@@ -2701,7 +2701,7 @@ reserve_mc_sibling_devs(struct amd64_pvt *pvt, u16 pci_id1, u16 pci_id2)pci_dev_put (pvt->F1); pvt->F1 =NULL ; -amd64_err ("F2 not found: device 0x%x (broken BIOS?)\n" , pci_id2); +edac_dbg (1 ,"F2 not found: device 0x%x\n" , pci_id2);return -ENODEV ; }
Signature · 1 line
2.25.1
Quoted 5 lines · Yazen Ghannam
From: Yazen Ghannam <[email protected]>
Give these messages a debug severity as they are really only useful to the module developers.
Quoted 8 lines
Also, drop the "(broken BIOS?)" phrase, since this can cause churn for BIOS folks. The PCI IDs needed by the module, at least on modern systems, are fixed in hardware.
Signed-off-by Yazen Ghannam <[email protected]>--- drivers/edac/amd64_edac.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Applied, thanks.
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette