video: fbdev: simplefb: Fix info message during probe
Subsystems (2)
PATCH 1/1 video: fbdev: simplefb: Fix info message during probe
The info message was showing the mapped address for the framebuffer. To avoid security problems, all virtual addresses are converted to __ptrval__, so the message has pointless information:
simple-framebuffer 3ea9b000.framebuffer: framebuffer at 0x3ea9b000, 0x12c000 bytes, mapped to 0x(____ptrval____)
Drop the extraneous bits to clean up the message:
simple-framebuffer 3ea9b000.framebuffer: framebuffer at 0x3ea9b000, 0x12c000 bytes
--- drivers/video/fbdev/simplefb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/video/fbdev/simplefb.c +2 -3
@@ -477,9 +477,8 @@ static int simplefb_probe(struct platform_device *pdev)simplefb_clocks_enable (par, pdev);simplefb_regulators_enable (par, pdev); -dev_info (&pdev->dev,"framebuffer at 0x%lx, 0x%x bytes, mapped to 0x%p\n" , - info->fix.smem_start, info->fix.smem_len, - info->screen_base); +dev_info (&pdev->dev,"framebuffer at 0x%lx, 0x%x bytes\n" , + info->fix.smem_start, info->fix.smem_len); dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n", params.format->name, info->var.xres, info->var.yres,
Signature · 1 line
2.29.2
Hi,
Quoted 11 lines · Peter Robinson
The info message was showing the mapped address for the framebuffer. To avoid security problems, all virtual addresses are converted to
__ptrval__, so the message has pointless information:simple-framebuffer 3ea9b000.framebuffer: framebuffer at
0x3ea9b000,0x12c000bytes, mapped to 0x(____ptrval____)Drop the extraneous bits to clean up the message:
simple-framebuffer 3ea9b000.framebuffer: framebuffer at
0x3ea9b000,0x12c000bytesSigned-off-by Peter Robinson <[email protected]>
Thanks, patch looks good to me:
Regards,
Hans
Quoted 11 lines
--- drivers/video/fbdev/simplefb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/video/fbdev/simplefb.c +0
-0@@ -477,9 +477,8 @@ static int simplefb_probe(struct platform_device *pdev)simplefb_clocks_enable (par, pdev);
drivers/video/fbdev/simplefb.c static int simplefb_probe(struct platform_device *pdev) · line 484
Quoted 10 lines
drivers/video/fbdev/simplefb.c +2
-3simplefb_regulators_enable (par, pdev); -dev_info (&pdev->dev,"framebuffer at 0x%lx, 0x%x bytes, mapped to 0x%p\n" , - info->fix.smem_start, info->fix.smem_len, - info->screen_base); +dev_info (&pdev->dev,"framebuffer at 0x%lx, 0x%x bytes\n" , + info->fix.smem_start, info->fix.smem_len); dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n", params.format->name, info->var.xres, info->var.yres,
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Hans,
Quoted 11 lines · Hans de Goede
Hi,
Quoted 8 lines · Peter Robinson
The info message was showing the mapped address for the framebuffer. To avoid security problems, all virtual addresses are converted to
__ptrval__, so the message has pointless information:simple-framebuffer 3ea9b000.framebuffer: framebuffer at
0x3ea9b000,0x12c000bytes, mapped to 0x(____ptrval____)Drop the extraneous bits to clean up the message:
Quoted 7 lines
Quoted 3 lines
simple-framebuffer 3ea9b000.framebuffer: framebuffer at
0x3ea9b000,0x12c000bytesSigned-off-by Peter Robinson <[email protected]>Thanks, patch looks good to me:
Reviewed-by Hans de Goede <[email protected]>
Since you have commit rights for drm-misc I'm assuming you're also going to push this one?
Thanks, Daniel
Quoted 31 lines
Regards,
Hans
Quoted 11 lines
--- drivers/video/fbdev/simplefb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/video/fbdev/simplefb.c +0
-0@@ -477,9 +477,8 @@ static int simplefb_probe(struct platform_device *pdev)simplefb_clocks_enable (par, pdev);drivers/video/fbdev/simplefb.c static int simplefb_probe(struct platform_device *pdev) · line 484
Quoted 10 lines
drivers/video/fbdev/simplefb.c +2
-3simplefb_regulators_enable (par, pdev); -dev_info (&pdev->dev,"framebuffer at 0x%lx, 0x%x bytes, mapped to 0x%p\n" , - info->fix.smem_start, info->fix.smem_len, - info->screen_base); +dev_info (&pdev->dev,"framebuffer at 0x%lx, 0x%x bytes\n" , + info->fix.smem_start, info->fix.smem_len); dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n", params.format->name, info->var.xres, info->var.yres,_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi,
Quoted 16 lines · Daniel Vetter
Hi Hans,
Quoted 13 lines · Hans de Goede
Hi,
Quoted 10 lines · Peter Robinson
The info message was showing the mapped address for the framebuffer. To avoid security problems, all virtual addresses are converted to
__ptrval__, so the message has pointless information:simple-framebuffer 3ea9b000.framebuffer: framebuffer at
0x3ea9b000,0x12c000bytes, mapped to 0x(____ptrval____)Drop the extraneous bits to clean up the message:
simple-framebuffer 3ea9b000.framebuffer: framebuffer at
0x3ea9b000,0x12c000bytes
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Peter Robinson <[email protected]>Thanks, patch looks good to me:
Reviewed-by Hans de Goede <[email protected]>Since you have commit rights for drm-misc I'm assuming you're also going to push this one?
I knew there was some discussion about using drm-misc for drivers/video/fbdev stuff but I missed that it was decided to go ahead with that.
Good to know that this is handled through drm-misc now.
I've pushed this patch to drm-misc-next.
Regards,
Hans
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
--- drivers/video/fbdev/simplefb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/video/fbdev/simplefb.c +0
-0@@ -477,9 +477,8 @@ static int simplefb_probe(struct platform_device *pdev)simplefb_clocks_enable (par, pdev);simplefb_regulators_enable (par, pdev);
Quoted 15 lines
Quoted 6 lines
Quoted 6 lines
drivers/video/fbdev/simplefb.c +2
-3-dev_info (&pdev->dev,"framebuffer at 0x%lx, 0x%x bytes, mapped to 0x%p\n" , - info->fix.smem_start, info->fix.smem_len, - info->screen_base); +dev_info (&pdev->dev,"framebuffer at 0x%lx, 0x%x bytes\n" , + info->fix.smem_start, info->fix.smem_len); dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n",Quoted 8 lines
drivers/video/fbdev/simplefb.c static int simplefb_probe(struct platform_device *pdev) · line 484
Quoted 3 lines
drivers/video/fbdev/simplefb.c +0
-0params.format->name, info->var.xres, info->var.yres,_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 26 lines · Hans de Goede
Hi,
Quoted 22 lines · Daniel Vetter
Hi Hans,
Quoted 18 lines · Hans de Goede
Hi,
Quoted 11 lines · Peter Robinson
The info message was showing the mapped address for the framebuffer. To avoid security problems, all virtual addresses are converted to
__ptrval__, so the message has pointless information:simple-framebuffer 3ea9b000.framebuffer: framebuffer at
0x3ea9b000,0x12c000bytes, mapped to 0x(____ptrval____)Drop the extraneous bits to clean up the message:
simple-framebuffer 3ea9b000.framebuffer: framebuffer at
0x3ea9b000,0x12c000bytesSigned-off-by Peter Robinson <[email protected]>Thanks, patch looks good to me:
Reviewed-by Hans de Goede <[email protected]>
Quoted 7 lines
Quoted 2 lines
Since you have commit rights for drm-misc I'm assuming you're also going to push this one?
I knew there was some discussion about using drm-misc for
drivers/video/fbdevstuff but I missed that it was decided to go ahead with that.Good to know that this is handled through drm-misc now.
This is official since a while:
commit 6a7553e8d84d5322d883cb83bb9888c49a0f04e0
Author: Bartlomiej Zolnierkiewicz <[email protected]> Date: Fri Aug 9 15:46:40 2019 +0200
MAINTAINERS: handle fbdev changes through drm-misc tree
Cheers, Daniel
Quoted 37 lines
I've pushed this patch to drm-misc-next.
Regards,
Hans
Quoted 27 lines
Quoted 26 lines
Quoted 11 lines
--- drivers/video/fbdev/simplefb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/video/fbdev/simplefb.c +0
-0@@ -477,9 +477,8 @@ static int simplefb_probe(struct platform_device *pdev)simplefb_clocks_enable (par, pdev);drivers/video/fbdev/simplefb.c static int simplefb_probe(struct platform_device *pdev) · line 484
Quoted 10 lines
drivers/video/fbdev/simplefb.c +2
-3simplefb_regulators_enable (par, pdev); -dev_info (&pdev->dev,"framebuffer at 0x%lx, 0x%x bytes, mapped to 0x%p\n" , - info->fix.smem_start, info->fix.smem_len, - info->screen_base); +dev_info (&pdev->dev,"framebuffer at 0x%lx, 0x%x bytes\n" , + info->fix.smem_start, info->fix.smem_len); dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n", params.format->name, info->var.xres, info->var.yres,_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel