Skip to contentSkip to conversation

package/tpm2-pkcs11: new package

PATCH Superseded Yair Ben-Avraham 2 participants 2 messages Dec 22, 2020 – Dec 29, 2020

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/tpm2-pkcs11: new package

A PKCS#11 interface for TPM2 hardware

---
 DEVELOPERS                           |  1 +
 package/Config.in                    |  1 +
 package/tpm2-pkcs11/Config.in        | 15 ++++++++++
 package/tpm2-pkcs11/tpm2-pkcs11.hash |  3 ++
 package/tpm2-pkcs11/tpm2-pkcs11.mk   | 42 ++++++++++++++++++++++++++++
 5 files changed, 62 insertions(+)
 create mode 100644 package/tpm2-pkcs11/Config.in
 create mode 100644 package/tpm2-pkcs11/tpm2-pkcs11.hash
 create mode 100644 package/tpm2-pkcs11/tpm2-pkcs11.mk
DEVELOPERS +1 -0
index d0b4cd7531..11f20a1c49 100644
@@ -2687,6 +2687,7 @@ F:	package/fwup/
 
 N:	Yair Ben Avraham <[email protected]>
 F:	package/gloox/
+F:	package/tpm2-pkcs11/
 
 N:	Yann E. MORIN <[email protected]>
 F:	board/friendlyarm/nanopi-neo/
package/Config.in +1 -0
index c3677dd15e..43a7549841 100644
@@ -1363,6 +1363,7 @@ menu "Crypto"
 	source "package/pkcs11-helper/Config.in"
 	source "package/rhash/Config.in"
 	source "package/tinydtls/Config.in"
+	source "package/tpm2-pkcs11/Config.in"
 	source "package/tpm2-tss/Config.in"
 	source "package/trousers/Config.in"
 	source "package/ustream-ssl/Config.in"
package/tpm2-pkcs11/Config.in new file +15 -0
new file mode 100644
index 0000000000..ab7ad02480
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_TPM2_PKCS11
+	bool "tpm2-pkcs11"
+	depends on !BR2_STATIC_LIBS # tpm2-tss
+	select BR2_PACKAGE_LIBYAML
+	select BR2_PACKAGE_P11_KIT
+	select BR2_PACKAGE_SQLITE
+	select BR2_PACKAGE_TPM2_TOOLS
+	select BR2_PACKAGE_TPM2_TSS
+	help
+	  A PKCS#11 interface for TPM2 hardware
+
+	  https://github.com/tpm2-software/tpm2-pkcs11
+
+comment "tpm2-pkcs11 needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
package/tpm2-pkcs11/tpm2-pkcs11.hash new file +3 -0
new file mode 100644
index 0000000000..16dd9166ba
@@ -0,0 +1,3 @@
+# Locally computed:
+sha256  13425c34358ec798d333743099b9aec5e42f6a4653c4c0e40eb075681f369687  tpm2-pkcs11-1.5.0.tar.gz
+sha256  793aa007f793458434d7cc60b1c827053a399308658b32fcaa6023802adc22e1  LICENSE
package/tpm2-pkcs11/tpm2-pkcs11.mk new file +42 -0

42 lines not on this page · raw message

--
2.20.1

#1 lore raw

PATCH v2 1/1 package/tpm2-pkcs11: new package

Yair, All,

On 2020-12-22 10:32 +0000, Yair Ben-Avraham via buildroot spake thusly:

Quoted 3 lines

A PKCS#11 interface for TPM2 hardware

[--SNIP--]

Quoted 6 lines
package/tpm2-pkcs11/Config.in new file +0 -0
new file mode 100644
index 0000000000..ab7ad02480

package/tpm2-pkcs11/Config.in line 8

Quoted 8 lines
package/tpm2-pkcs11/Config.in new file +8 -0
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_TPM2_PKCS11
+	bool "tpm2-pkcs11"
+	depends on !BR2_STATIC_LIBS # tpm2-tss
+	select BR2_PACKAGE_LIBYAML
+	select BR2_PACKAGE_P11_KIT
+	select BR2_PACKAGE_SQLITE
+	select BR2_PACKAGE_TPM2_TOOLS
+	select BR2_PACKAGE_TPM2_TSS

You need to propagate the dependencies of all the packages you select:

p11-kit depends on !static, MMU, and threads

When you propagate a dependency from two packages, you should add both to the comment:

depends on !BR2_STATIC_LIBS # tpm2-tss, p11-kit

Quoted 27 lines
package/tpm2-pkcs11/Config.in new file +7 -0
+	help
+	  A PKCS#11 interface for TPM2 hardware
+
+	  https://github.com/tpm2-software/tpm2-pkcs11
+
+comment "tpm2-pkcs11 needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
package/tpm2-pkcs11/tpm2-pkcs11.hash new file +3 -0
new file mode 100644
index 0000000000..16dd9166ba
@@ -0,0 +1,3 @@
+# Locally computed:
+sha256  13425c34358ec798d333743099b9aec5e42f6a4653c4c0e40eb075681f369687  tpm2-pkcs11-1.5.0.tar.gz
+sha256  793aa007f793458434d7cc60b1c827053a399308658b32fcaa6023802adc22e1  LICENSE
package/tpm2-pkcs11/tpm2-pkcs11.mk new file +5 -0
new file mode 100644
index 0000000000..14ff1e4e07
@@ -0,0 +1,42 @@
+################################################################################
+#
+# tpm2-pkcs11
+#
+################################################################################

package/tpm2-pkcs11/tpm2-pkcs11.mk line 15

Quoted 10 lines
package/tpm2-pkcs11/tpm2-pkcs11.mk new file +10 -0
+
+TPM2_PKCS11_VERSION = 1.5.0
+TPM2_PKCS11_SITE = https://github.com/tpm2-software/tpm2-pkcs11/releases/download/$(TPM2_PKCS11_VERSION)
+TPM2_PKCS11_LICENSE = BSD-2-Clause
+TPM2_PKCS11_LICENSE_FILES = LICENSE
+TPM2_PKCS11_DEPENDENCIES = libyaml p11-kit sqlite tpm2-tools tpm2-tss
+
+TPM2_PKCS11_CONF_OPTS += \
+		--disable-hardening \
+		--with-p11kitconfigdir=/../usr/share/p11-kit/modules

Why the leading /../ ?

package/tpm2-pkcs11/tpm2-pkcs11.mk line 20

Quoted 4 lines
package/tpm2-pkcs11/tpm2-pkcs11.mk new file +4 -0
+# Fix tpm.c:746:5: error: 'for' loop initial declarations are only allowed in C99 mode
+# Fix implicit declaration of function 'strnlen'
+ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM),y)
+TPM2_PKCS11_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -std=gnu99"

Why does it only matter for the CS ARM toolchain?

Quoted 10 lines
package/tpm2-pkcs11/tpm2-pkcs11.mk new file +10 -0
+endif
+
+# do not build man pages
+TPM2_PKCS11_CONF_ENV += ac_cv_prog_PANDOC=''
+
+ifeq ($(BR2_PACKAGE_TPM2_TOOLS),y)
+TPM2_PKCS11_CONF_ENV += \
+	ac_cv_prog_tpm2_createprimary=yes \
+	ac_cv_prog_tpm2_create=yes \
+	ac_cv_prog_tpm2_evictcontrol=yes \

package/tpm2-pkcs11/tpm2-pkcs11.mk line 40

Quoted 10 lines
package/tpm2-pkcs11/tpm2-pkcs11.mk new file +10 -0
+	ac_cv_prog_tpm2_readpublic=yes \
+	ac_cv_prog_tpm2_load=yes \
+	ac_cv_prog_tpm2_loadexternal=yes \
+	ac_cv_prog_tpm2_unseal=yes \
+	ac_cv_prog_tpm2_encryptdecrypt=yes \
+	ac_cv_prog_tpm2_sign=yes \
+	ac_cv_prog_tpm2_getcap=yes \
+	ac_cv_prog_tpm2_import=yes \
+	ac_cv_prog_tpm2_changeauth=yes
+endif

What are those for? A little blurb in the commit log would be nice...

Regards,
Yann E. MORIN.

Quoted 8 lines
package/tpm2-pkcs11/tpm2-pkcs11.mk new file +1 -1
+$(eval $(autotools-package))
--

2.20.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'