Skip to contentSkip to conversation

pinctrl: nomadik: Remove unused variable in nmk_gpio_dbg_show_one

PATCH In review Nathan Chancellor 2 participants 2 messages Dec 29, 2020 – Jan 5, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: nomadik: Remove unused variable in nmk_gpio_dbg_show_one

Clang warns:

drivers/pinctrl/nomadik/pinctrl-nomadik.c:952:8: warning: unused variable 'wake' [-Wunused-variable]

                bool wake;
                     ^

1 warning generated.

There were two wake declarations added to nmk_gpio_dbg_show_one when converting it to use irq_has_action but only one is used within its scope. Remove the unused one so there is no more warning.

Fixes f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()")
---
 drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 -
 1 file changed, 1 deletion(-)
drivers/pinctrl/nomadik/pinctrl-nomadik.c +0 -1
index d4ea10803fd9..abfe11c7b49f 100644
@@ -949,7 +949,6 @@ static void nmk_gpio_dbg_show_one(struct seq_file *s,
 	} else {
 		int irq = chip->to_irq(chip, offset);
 		const int pullidx = pull ? 1 : 0;
-		bool wake;
 		int val;
 		static const char * const pulls[] = {
 			"none        ",

base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e

Signature · 1 line
2.30.0
#1 lore raw
Quoted 4 lines · Nathan Chancellor

drivers/pinctrl/nomadik/pinctrl-nomadik.c:952:8: warning: unused variable 'wake' [-Wunused-variable]

                bool wake;
                     ^
Quoted 8 lines

1 warning generated.

There were two wake declarations added to nmk_gpio_dbg_show_one when converting it to use irq_has_action but only one is used within its scope. Remove the unused one so there is no more warning.

Fixes f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()")

Patch applied.

Yours,
Linus Walleij