Skip to contentSkip to conversation

libtirpc: remove NIS patch

PATCH New Petr Vorel 2 participants 8 messages Dec 2, 2020 – Dec 29, 2020

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH 1/2 libtirpc: remove NIS patch

It was originally added in 6dc861f2a2 ("libtirpc: new package") for libtirpc 0.2.2 (8 years ago). It might have been fixed in 5f00f8c ("Remove dependency to nis.h"), released in 1.0.2.

Testing with test-pkg shows the only failure for br-riscv32:
RPC support not available in C library, please disable BR2_TOOLCHAIN_EXTERNAL_INET_RPC

But test fails with the same error even when this patch is kept.

---
Originally sent in
https://patchwork.ozlabs.org/project/buildroot/patch/20201127203907.16845-1-petr.vorel at gmail.com/

 ...parts-of-TIRPC-requiring-NIS-support.patch | 50 -------------------
 1 file changed, 50 deletions(-)
 delete mode 100644 package/libtirpc/0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch
package/libtirpc/0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch deleted +0 -50
deleted file mode 100644
index 101a779ade..0000000000
@@ -1,50 +0,0 @@
-From cb30579c9195ae29c82545c934e0bd9677262bce Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?J=C3=B6rg=20Krause?= <[email protected]>
-Date: Fri, 20 Dec 2019 17:58:17 +0100
-Subject: [PATCH] Disable parts of TIRPC requiring NIS support
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-Signed-off-by: Thomas Petazzoni <[email protected]>
-[yann.morin.1998 at free.fr: update for 0.3.1]
-Signed-off-by: "Yann E. MORIN" <[email protected]>
-[joerg.krause at embedded.rocks: update for 0.3.2]
-Signed-off-by: J?rg Krause <[email protected]>
-[peda at axentia.se: update for 1.0.1]
-Signed-off-by: Peter Rosin <[email protected]>
-[bernd.kuhls at t-online.de: update for 1.0.2]
-Signed-off-by: Bernd Kuhls <[email protected]>
-[pvorel: update for 1.2.5]
-Signed-off-by: Petr Vorel <[email protected]>
----
- src/Makefile.am | 6 +++---
- 1 file changed, 3 insertions(+), 3 deletions(-)
-
-diff --git a/src/Makefile.am b/src/Makefile.am
-index b2d5436..864f984 100644
---- a/src/Makefile.am
-+++ b/src/Makefile.am
-@@ -24,7 +24,7 @@ libtirpc_la_SOURCES = auth_none.c auth_unix.c authunix_prot.c \
-         rpc_callmsg.c rpc_generic.c rpc_soc.c rpcb_clnt.c rpcb_prot.c \
-         rpcb_st_xdr.c svc.c svc_auth.c svc_dg.c svc_auth_unix.c svc_auth_none.c \
-         svc_generic.c svc_raw.c svc_run.c svc_simple.c svc_vc.c getpeereid.c \
--        auth_time.c debug.c 
-+        debug.c
- 
- if AUTHDES
- libtirpc_la_SOURCES += auth_des.c  authdes_prot.c  des_crypt.c  des_impl.c  des_soft.c  svc_auth_des.c
-@@ -45,8 +45,8 @@ if GSS
-     libtirpc_la_CFLAGS = -DHAVE_RPCSEC_GSS $(GSSAPI_CFLAGS)
- endif
- 
--libtirpc_la_SOURCES += key_call.c key_prot_xdr.c getpublickey.c
--libtirpc_la_SOURCES += netname.c netnamer.c rpcdname.c rtime.c
-+#libtirpc_la_SOURCES += key_call.c key_prot_xdr.c getpublickey.c
-+#libtirpc_la_SOURCES += netname.c netnamer.c rpcdname.c rtime.c
- 
- CLEANFILES	       = cscope.* *~
- DISTCLEANFILES	       = Makefile.in
--- 
-2.24.0
-
Signature · 1 line
2.29.2
author
#1 lore raw

PATCH 2/2 package/libtirpc: bump version to 1.3.1

---
 package/libtirpc/libtirpc.hash | 4 ++--
 package/libtirpc/libtirpc.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
package/libtirpc/libtirpc.hash +2 -2
index e437554285..0e77f23947 100644
@@ -1,5 +1,5 @@
 # From sourceforge's info on download page:
-sha1 f182235e32942fc0ac6b9b5b6fe7e32f69362659  libtirpc-1.2.6.tar.bz2
+sha1 882eaf4c13f0cafb83afd96cd2855638f978d755  libtirpc-1.3.1.tar.bz2
 # Locally computed
-sha256 4278e9a5181d5af9cd7885322fdecebc444f9a3da87c526e7d47f7a12a37d1cc  libtirpc-1.2.6.tar.bz2
+sha256 245895caf066bec5e3d4375942c8cb4366adad184c29c618d97f724ea309ee17  dl/libtirpc/libtirpc-1.3.1.tar.bz2
 sha256 17cf6098f95bdbb269f0bbc68e76c88fe20487ca7ec53f454923ab4256ecd2e7  COPYING
package/libtirpc/libtirpc.mk +1 -1
index f1bdc32eba..5371d20488 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBTIRPC_VERSION = 1.2.6
+LIBTIRPC_VERSION = 1.3.1
 LIBTIRPC_SOURCE = libtirpc-$(LIBTIRPC_VERSION).tar.bz2
 LIBTIRPC_SITE = http://downloads.sourceforge.net/project/libtirpc/libtirpc/$(LIBTIRPC_VERSION)
 LIBTIRPC_LICENSE = BSD-3-Clause
Signature · 1 line
2.29.2
author
#2 lore raw

PATCH 2/2 package/libtirpc: bump version to 1.3.1

Hi,

package/libtirpc/libtirpc.mk line 10

Quoted 5 lines
package/libtirpc/libtirpc.mk +1 -1
-LIBTIRPC_VERSION = 1.2.6
+LIBTIRPC_VERSION = 1.3.1
 LIBTIRPC_SOURCE = libtirpc-$(LIBTIRPC_VERSION).tar.bz2
 LIBTIRPC_SITE = http://downloads.sourceforge.net/project/libtirpc/libtirpc/$(LIBTIRPC_VERSION)
 LIBTIRPC_LICENSE = BSD-3-Clause

Tested:

                             andes-nds32 [ 1/45]: OK
                             arm-aarch64 [ 2/45]: OK
                    bootlin-x86-64-glibc [ 3/45]: OK
                        br-aarch64-glibc [ 4/45]: OK
                           br-arcle-hs38 [ 5/45]: OK
                            br-arm-basic [ 6/45]: OK
                  br-arm-cortex-a9-glibc [ 7/45]: OK
                   br-arm-cortex-a9-musl [ 8/45]: OK
                   br-arm-cortex-m4-full [ 9/45]: OK
                             br-arm-full [10/45]: OK
                    br-arm-full-nothread [11/45]: SKIPPED
                      br-arm-full-static [12/45]: OK
                br-i386-pentium-mmx-musl [13/45]: OK
                   br-i386-pentium4-full [14/45]: OK
                    br-microblazeel-full [15/45]: OK
                      br-mipsel-o32-full [16/45]: OK
                 br-mips32r6-el-hf-glibc [17/45]: OK
                      br-mips64-n64-full [18/45]: OK
                 br-mips64r6-el-hf-glibc [19/45]: OK
                       br-m68k-5208-full [20/45]: OK
                      br-m68k-68040-full [21/45]: OK
                          br-nios2-glibc [22/45]: OK
                      br-openrisc-uclibc [23/45]: OK
                  br-powerpc-e500mc-full [24/45]: OK
               br-powerpc-603e-basic-cpp [25/45]: OK
             br-powerpc64le-power8-glibc [26/45]: OK
               br-powerpc64-power7-glibc [27/45]: OK
                              br-riscv32 [28/45]: FAILED
                              br-riscv64 [29/45]: OK
                         br-riscv64-musl [30/45]: OK
                             br-sh4-full [31/45]: OK
                         br-sparc-uclibc [32/45]: OK
                        br-sparc64-glibc [33/45]: OK
                          br-xtensa-full [34/45]: OK
                    br-x86-64-core2-full [35/45]: OK
                          br-x86-64-musl [36/45]: OK
                       linaro-aarch64-be [37/45]: OK
                          linaro-aarch64 [38/45]: OK
                              linaro-arm [39/45]: OK
                     sourcery-arm-armv4t [40/45]: OK
                            sourcery-arm [41/45]: OK
                     sourcery-arm-thumb2 [42/45]: OK
                           sourcery-mips [43/45]: OK
                         sourcery-mips64 [44/45]: OK
                          sourcery-nios2 [45/45]: OK

45 builds, 1 skipped, 1 build failed, 0 legal-info failed

Again, br-riscv32 should not be affected by this change (BR2_TOOLCHAIN_EXTERNAL_INET_RPC, broken also without this patchset).

Kind regards,
Petr

#3 lore raw

PATCH 2/2 package/libtirpc: bump version to 1.3.1

In reply to Petr Vorel

Petr, All,

On 2020-12-02 19:49 +0100, Petr Vorel spake thusly:

Quoted 11 lines
---
 package/libtirpc/libtirpc.hash | 4 ++--
 package/libtirpc/libtirpc.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
package/libtirpc/libtirpc.hash +0 -0
index e437554285..0e77f23947 100644

package/libtirpc/libtirpc.hash line 4

Quoted 6 lines
package/libtirpc/libtirpc.hash +2 -2
@@ -1,5 +1,5 @@
 # From sourceforge's info on download page:
-sha1 f182235e32942fc0ac6b9b5b6fe7e32f69362659  libtirpc-1.2.6.tar.bz2
+sha1 882eaf4c13f0cafb83afd96cd2855638f978d755  libtirpc-1.3.1.tar.bz2
 # Locally computed
-sha256 4278e9a5181d5af9cd7885322fdecebc444f9a3da87c526e7d47f7a12a37d1cc  libtirpc-1.2.6.tar.bz2
+sha256 245895caf066bec5e3d4375942c8cb4366adad184c29c618d97f724ea309ee17  dl/libtirpc/libtirpc-1.3.1.tar.bz2

___________________________________________________________________________,^^^^^^^^^^^^

Hmmm... bad copy-paste. ;-)

Fixed, and applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 21 lines
package/libtirpc/libtirpc.hash +0 -0
 sha256 17cf6098f95bdbb269f0bbc68e76c88fe20487ca7ec53f454923ab4256ecd2e7  COPYING
package/libtirpc/libtirpc.mk +1 -1
index f1bdc32eba..5371d20488 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBTIRPC_VERSION = 1.2.6
+LIBTIRPC_VERSION = 1.3.1
 LIBTIRPC_SOURCE = libtirpc-$(LIBTIRPC_VERSION).tar.bz2
 LIBTIRPC_SITE = http://downloads.sourceforge.net/project/libtirpc/libtirpc/$(LIBTIRPC_VERSION)
 LIBTIRPC_LICENSE = BSD-3-Clause
Signature · 6 lines
2.29.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author
#4 lore raw

PATCH 2/2 package/libtirpc: bump version to 1.3.1

Hi Yann,

Quoted 22 lines

Petr, All,

On 2020-12-02 19:49 +0100, Petr Vorel spake thusly:

Quoted 11 lines
---
 package/libtirpc/libtirpc.hash | 4 ++--
 package/libtirpc/libtirpc.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
package/libtirpc/libtirpc.hash +0 -0
index e437554285..0e77f23947 100644

package/libtirpc/libtirpc.hash line 4

Quoted 6 lines
package/libtirpc/libtirpc.hash +2 -2
@@ -1,5 +1,5 @@
 # From sourceforge's info on download page:
-sha1 f182235e32942fc0ac6b9b5b6fe7e32f69362659  libtirpc-1.2.6.tar.bz2
+sha1 882eaf4c13f0cafb83afd96cd2855638f978d755  libtirpc-1.3.1.tar.bz2
 # Locally computed
-sha256 4278e9a5181d5af9cd7885322fdecebc444f9a3da87c526e7d47f7a12a37d1cc  libtirpc-1.2.6.tar.bz2
+sha256 245895caf066bec5e3d4375942c8cb4366adad184c29c618d97f724ea309ee17  dl/libtirpc/libtirpc-1.3.1.tar.bz2

___________________________________________________________________________,^^^^^^^^^^^^

Quoted 3 lines

Hmmm... bad copy-paste. ;-)

Fixed, and applied to master, thanks.

Uh, sorry for it, thanks for fixing!

Quoted 2 lines

Regards,
Yann E. MORIN.

Kind regards,
Petr

#5 lore raw

PATCH 1/2 libtirpc: remove NIS patch

In reply to Petr Vorel

Petr, All,

On 2020-12-02 19:49 +0100, Petr Vorel spake thusly:

Quoted 3 lines

It was originally added in 6dc861f2a2 ("libtirpc: new package") for libtirpc 0.2.2 (8 years ago). It might have been fixed in 5f00f8c ("Remove dependency to nis.h"), released in 1.0.2.

Yup, seems like it.

Applied to master, thanks.

Quoted 5 lines

Testing with test-pkg shows the only failure for br-riscv32:
RPC support not available in C library, please disable BR2_TOOLCHAIN_EXTERNAL_INET_RPC

But test fails with the same error even when this patch is kept.

Indeed, the risc32 case is special: it uses a glibc more recent than 2.32. In glibc 2.32, RPC support was entirely removed, so it is not unexpected that we do have RPC-relacted issues for riscv32.

Regards,
Yann E. MORIN.

Quoted 72 lines

---
Originally sent in
https://patchwork.ozlabs.org/project/buildroot/patch/20201127203907.16845-1-petr.vorel at gmail.com/

 ...parts-of-TIRPC-requiring-NIS-support.patch | 50 -------------------
 1 file changed, 50 deletions(-)
 delete mode 100644 package/libtirpc/0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch
package/libtirpc/0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch deleted +0 -50
deleted file mode 100644
index 101a779ade..0000000000
@@ -1,50 +0,0 @@
-From cb30579c9195ae29c82545c934e0bd9677262bce Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?J=C3=B6rg=20Krause?= <[email protected]>
-Date: Fri, 20 Dec 2019 17:58:17 +0100
-Subject: [PATCH] Disable parts of TIRPC requiring NIS support
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-Signed-off-by: Thomas Petazzoni <[email protected]>
-[yann.morin.1998 at free.fr: update for 0.3.1]
-Signed-off-by: "Yann E. MORIN" <[email protected]>
-[joerg.krause at embedded.rocks: update for 0.3.2]
-Signed-off-by: J?rg Krause <[email protected]>
-[peda at axentia.se: update for 1.0.1]
-Signed-off-by: Peter Rosin <[email protected]>
-[bernd.kuhls at t-online.de: update for 1.0.2]
-Signed-off-by: Bernd Kuhls <[email protected]>
-[pvorel: update for 1.2.5]
-Signed-off-by: Petr Vorel <[email protected]>
----
- src/Makefile.am | 6 +++---
- 1 file changed, 3 insertions(+), 3 deletions(-)
-
-diff --git a/src/Makefile.am b/src/Makefile.am
-index b2d5436..864f984 100644
---- a/src/Makefile.am
-+++ b/src/Makefile.am
-@@ -24,7 +24,7 @@ libtirpc_la_SOURCES = auth_none.c auth_unix.c authunix_prot.c \
-         rpc_callmsg.c rpc_generic.c rpc_soc.c rpcb_clnt.c rpcb_prot.c \
-         rpcb_st_xdr.c svc.c svc_auth.c svc_dg.c svc_auth_unix.c svc_auth_none.c \
-         svc_generic.c svc_raw.c svc_run.c svc_simple.c svc_vc.c getpeereid.c \
--        auth_time.c debug.c 
-+        debug.c
- 
- if AUTHDES
- libtirpc_la_SOURCES += auth_des.c  authdes_prot.c  des_crypt.c  des_impl.c  des_soft.c  svc_auth_des.c
-@@ -45,8 +45,8 @@ if GSS
-     libtirpc_la_CFLAGS = -DHAVE_RPCSEC_GSS $(GSSAPI_CFLAGS)
- endif
- 
--libtirpc_la_SOURCES += key_call.c key_prot_xdr.c getpublickey.c
--libtirpc_la_SOURCES += netname.c netnamer.c rpcdname.c rtime.c
-+#libtirpc_la_SOURCES += key_call.c key_prot_xdr.c getpublickey.c
-+#libtirpc_la_SOURCES += netname.c netnamer.c rpcdname.c rtime.c
- 
- CLEANFILES	       = cscope.* *~
- DISTCLEANFILES	       = Makefile.in
--- 
-2.24.0
-
Signature · 6 lines
2.29.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author
#6 lore raw

PATCH 1/2 libtirpc: remove NIS patch

Hi Yann, all,

...

Quoted 9 lines
Quoted 5 lines

Testing with test-pkg shows the only failure for br-riscv32:
RPC support not available in C library, please disable BR2_TOOLCHAIN_EXTERNAL_INET_RPC

But test fails with the same error even when this patch is kept.

Indeed, the risc32 case is special: it uses a glibc more recent than 2.32. In glibc 2.32, RPC support was entirely removed, so it is not unexpected that we do have RPC-relacted issues for riscv32.

I wonder if there is some package which is not yet ported to libtirpc and requires Sun-RPC. Suppose yes, otherwise there wouldn't be that check, but I haven't find any.

FYI openSUSE has been using libtirpc as a drop-in replacement for quite long time. Maybe that could be a solution for Buildroot as well.

openSUSE change libtirpc.pc.in [1] in rpm spec file before build [1]:
sed -i -e 's|${includedir}/tirpc|${includedir}|g' libtirpc.pc.in

[1] https://build.opensuse.org/package/view_file/openSUSE:Factory/libtirpc/libtirpc.spec?expand=1

Quoted 2 lines

Regards,
Yann E. MORIN.

Kind regards,
Petr

#7 lore raw

PATCH 1/2 libtirpc: remove NIS patch

Petr, All,

On 2020-12-29 22:06 +0100, Petr Vorel spake thusly:

Quoted 11 lines
Quoted 4 lines
Quoted 1 line

But test fails with the same error even when this patch is kept.

Indeed, the risc32 case is special: it uses a glibc more recent than 2.32. In glibc 2.32, RPC support was entirely removed, so it is not unexpected that we do have RPC-relacted issues for riscv32.

I wonder if there is some package which is not yet ported to libtirpc and requires Sun-RPC. Suppose yes, otherwise there wouldn't be that check, but I haven't find any.

FYI openSUSE has been using libtirpc as a drop-in replacement for quite long time. Maybe that could be a solution for Buildroot as well.

And this is exactly what we've just done tonight with Thomas;
9853983336 package/glibc, toolchain/toolchain-buildroot: disable
native RPC in glibc toolchains

Thanks! ;-)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'