Skip to contentSkip to conversation

ibmvnic: fix: NULL pointer dereference.

PATCH Applied YANG LI 4 participants 4 messages Dec 30, 2020 – Jan 4, 2021

Subsystems (4)
lore
Share & tools
lore

YANG LI

author
#0 lore raw

PATCH 1/1 ibmvnic: fix: NULL pointer dereference.

The error is due to dereference a null pointer in function reset_one_sub_crq_queue():

if (!scrq) {
    netdev_dbg(adapter->netdev,
               "Invalid scrq reset. irq (%d) or msgs(%p).\n",
		scrq->irq, scrq->msgs);
		return -EINVAL;
}

If the expression is true, scrq must be a null pointer and cannot dereference.

---
 drivers/net/ethernet/ibm/ibmvnic.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/ethernet/ibm/ibmvnic.c +1 -3
index f302504..d7472be 100644
@@ -2981,9 +2981,7 @@ static int reset_one_sub_crq_queue(struct ibmvnic_adapter *adapter,
 	int rc;
 
 	if (!scrq) {
-		netdev_dbg(adapter->netdev,
-			   "Invalid scrq reset. irq (%d) or msgs (%p).\n",
-			   scrq->irq, scrq->msgs);
+		netdev_dbg(adapter->netdev, "Invalid scrq reset.\n");
 		return -EINVAL;
 	}
 
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 10 lines · YANG LI

The error is due to dereference a null pointer in function reset_one_sub_crq_queue():

if (!scrq) {
    netdev_dbg(adapter->netdev,
               "Invalid scrq reset. irq (%d) or msgs(%p).\n",
		scrq->irq, scrq->msgs);
		return -EINVAL;
}
Quoted 5 lines

If the expression is true, scrq must be a null pointer and cannot dereference.

Fixes 9281cf2d5840 ("ibmvnic: avoid memset null scrq msgs")
Quoted 22 lines
---
 drivers/net/ethernet/ibm/ibmvnic.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/ethernet/ibm/ibmvnic.c +1 -3
index f302504..d7472be 100644
@@ -2981,9 +2981,7 @@ static int reset_one_sub_crq_queue(struct ibmvnic_adapter *adapter,
 	int rc;
 
 	if (!scrq) {
-		netdev_dbg(adapter->netdev,
-			   "Invalid scrq reset. irq (%d) or msgs (%p).\n",
-			   scrq->irq, scrq->msgs);
+		netdev_dbg(adapter->netdev, "Invalid scrq reset.\n");
 		return -EINVAL;
 	}
 
Signature · 1 line
1.8.3.1
Acked-by on v1 1/1
#2 lore raw
In reply to YANG LI
Quoted 11 lines · YANG LI

The error is due to dereference a null pointer in function reset_one_sub_crq_queue():

if (!scrq) {
    netdev_dbg(adapter->netdev,
               "Invalid scrq reset. irq (%d) or msgs(%p).\n",
                scrq->irq, scrq->msgs);
                return -EINVAL;
}
Quoted 6 lines

If the expression is true, scrq must be a null pointer and cannot dereference.

---

#3 lore raw
In reply to YANG LI
This patch was applied to netdev/net.git (refs/heads/master):

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

Quoted 11 lines · On Wed, 30 Dec 2020 15:23:14 +0800 you wrote:

The error is due to dereference a null pointer in function reset_one_sub_crq_queue():

if (!scrq) {
    netdev_dbg(adapter->netdev,
               "Invalid scrq reset. irq (%d) or msgs(%p).\n",
		scrq->irq, scrq->msgs);
		return -EINVAL;
}

[...]

Here is the summary with links:
- ibmvnic: fix: NULL pointer dereference.

    https://git.kernel.org/netdev/net/c/862aecbd9569

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html