Skip to contentSkip to conversation

regulator: qcom-rpmh: add QCOM_COMMAND_DB dependency

PATCH In review Arnd Bergmann 3 participants 3 messages Dec 30, 2020 – Jan 4, 2021 Voltage and current regulator framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regulator: qcom-rpmh: add QCOM_COMMAND_DB dependency

From: Arnd Bergmann <[email protected]>

A built-in regulator driver cannot link against a modular cmd_db driver:

qcom-rpmh-regulator.c:(.text+0x174): undefined reference to `cmd_db_read_addr'

There is already a dependency for RPMh, so add another one of this type for cmd_db.

Fixes 34c5aa2666db ("regulator: Kconfig: Fix REGULATOR_QCOM_RPMH dependencies to avoid build error")
Fixes 46fc033eba42 ("regulator: add QCOM RPMh regulator driver")
---
 drivers/regulator/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/regulator/Kconfig +1 -0
index 53fa84f4d1e1..5abdd29fb9f3 100644
@@ -881,6 +881,7 @@ config REGULATOR_QCOM_RPM
 config REGULATOR_QCOM_RPMH
 	tristate "Qualcomm Technologies, Inc. RPMh regulator driver"
 	depends on QCOM_RPMH || (QCOM_RPMH=n && COMPILE_TEST)
+	depends on QCOM_COMMAND_DB || (QCOM_COMMAND_DB=n && COMPILE_TEST)
 	help
 	  This driver supports control of PMIC regulators via the RPMh hardware
 	  block found on Qualcomm Technologies Inc. SoCs.  RPMh regulator
Signature · 1 line
2.29.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

A built-in regulator driver cannot link against a modular cmd_db driver:

Quoted 8 lines

qcom-rpmh-regulator.c:(.text+0x174): undefined reference to `cmd_db_read_addr'

There is already a dependency for RPMh, so add another one of this type for cmd_db.

Fixes 34c5aa2666db ("regulator: Kconfig: Fix REGULATOR_QCOM_RPMH dependencies to avoid build error")
Fixes 46fc033eba42 ("regulator: add QCOM RPMh regulator driver")

Regards,
Bjorn

Quoted 19 lines
---
 drivers/regulator/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/regulator/Kconfig +1 -0
index 53fa84f4d1e1..5abdd29fb9f3 100644
@@ -881,6 +881,7 @@ config REGULATOR_QCOM_RPM
 config REGULATOR_QCOM_RPMH
 	tristate "Qualcomm Technologies, Inc. RPMh regulator driver"
 	depends on QCOM_RPMH || (QCOM_RPMH=n && COMPILE_TEST)
+	depends on QCOM_COMMAND_DB || (QCOM_COMMAND_DB=n && COMPILE_TEST)
 	help
 	  This driver supports control of PMIC regulators via the RPMh hardware
 	  block found on Qualcomm Technologies Inc. SoCs.  RPMh regulator
Signature · 1 line
2.29.2
maintainer
#2 lore raw
In reply to Arnd Bergmann
Quoted 6 lines · Arnd Bergmann

A built-in regulator driver cannot link against a modular cmd_db driver:

qcom-rpmh-regulator.c:(.text+0x174): undefined reference to `cmd_db_read_addr'

There is already a dependency for RPMh, so add another one of this type for cmd_db.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: qcom-rpmh: add QCOM_COMMAND_DB dependency

      commit: d957d1610c661e758426654de3b04bea6fb29f8b

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark