Skip to contentSkip to conversation

genirq: Export irq_check_status_bit

PATCH In review Arnd Bergmann 2 participants 2 messages Dec 30, 2020 – Dec 31, 2020 IRQ

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 genirq: Export irq_check_status_bit

From: Arnd Bergmann <[email protected]>

Changing some inline functions to use the new irq_check_status_bit function out of line breaks calling them from loadable modules:

ERROR: modpost: "irq_check_status_bit" [drivers/perf/arm_spe_pmu.ko] undefined!

Export the function to make it work again. One can debate over whether this should be EXPORT_SYMBOL() or EXPORT_SYMBOL_GPL(), as it could be called from any module before and making it GPL-only changes behavior. However all other symbols in this file are EXPORT_SYMBOL_GPL(), so I went with that for consistency.

Fixes fdd029630434 ("genirq: Move status flag checks to core")
---
 kernel/irq/manage.c | 1 +
 1 file changed, 1 insertion(+)
kernel/irq/manage.c +1 -0
index ab8567f32501..dec3f73e8db9 100644
@@ -2859,3 +2859,4 @@ bool irq_check_status_bit(unsigned int irq, unsigned int bitmask)
 	rcu_read_unlock();
 	return res;
 }
+EXPORT_SYMBOL_GPL(irq_check_status_bit);
Signature · 1 line
2.29.2
#1 lore raw

Am 30.12.20 um 16:45 schrieb Arnd Bergmann:

Quoted 6 lines

From: Arnd Bergmann <[email protected]>

Changing some inline functions to use the new irq_check_status_bit function out of line breaks calling them from loadable modules:

ERROR: modpost: "irq_check_status_bit" [drivers/perf/arm_spe_pmu.ko] undefined!

Just FYI: Levi Yun sent a similar patch a on Dec, 26 already:
https://lore.kernel.org/lkml/20201226123818.GA693525@ubuntu/

But nothing happened afaics, the festival season is taking its toll. ;-)

I'd like to see this fixed, too, as it broke my
Kernel Vanilla builds for Fedora
(https://fedoraproject.org/wiki/Kernel_Vanilla_Repositories) just a day after I finally started building packages for aarch64, too. Bad timing. :-D

Ciao, Thorsten