Skip to contentSkip to conversation

keyctl.2: SYNOPSIS: Fix prototype parameter types

PATCH In review Alejandro Colomar 2 participants 2 messages Dec 30, 2020 Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 keyctl.2: SYNOPSIS: Fix prototype parameter types

The Linux kernel uses 'unsigned long'.
There's no reason to use the typedef '__kernel_ulong_t'.

......

$ syscall='keyctl';
$ find linux/ -type f -name '*.c' \
  |xargs pcregrep -Mn "(?s)^[\w_]*SYSCALL_DEFINE.\(${syscall},.*?\)";
linux/security/keys/keyctl.c:1869:
SYSCALL_DEFINE5(keyctl, int, option, unsigned long, arg2, unsigned long, arg3,
		unsigned long, arg4, unsigned long, arg5)
linux/security/keys/compat.c:17:
COMPAT_SYSCALL_DEFINE5(keyctl, u32, option,
		       u32, arg2, u32, arg3, u32, arg4, u32, arg5)
Cc Eugene Syromyatnikov <[email protected]>
---
 man2/keyctl.2 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
man2/keyctl.2 +3 -3
index 9311100cf..ea3a5d3dd 100644
@@ -40,9 +40,9 @@ keyctl \- manipulate the kernel's key management facility
 .B #include <linux/keyctl.h>
 .B #include <unistd.h>
 .PP
-.BI "long syscall(__NR_keyctl, int " operation ", __kernel_ulong_t " arg2 ,
-.BI "             __kernel_ulong_t " arg3 ", __kernel_ulong_t " arg4 ,
-.BI "             __kernel_ulong_t " arg5 );
+.BI "long syscall(__NR_keyctl, int " operation ", unsigned long " arg2 ,
+.BI "             unsigned long " arg3 ", unsigned long " arg4 ,
+.BI "             unsigned long " arg5 );
 .fi
 .PP
 .IR Note :
Signature · 1 line
2.29.2
#1 lore raw

Hi Alex,

Quoted 15 lines · Alejandro Colomar

The Linux kernel uses 'unsigned long'.
There's no reason to use the typedef '__kernel_ulong_t'.

......

$ syscall='keyctl';
$ find linux/ -type f -name '*.c' \
  |xargs pcregrep -Mn "(?s)^[\w_]*SYSCALL_DEFINE.\(${syscall},.*?\)";
linux/security/keys/keyctl.c:1869:
SYSCALL_DEFINE5(keyctl, int, option, unsigned long, arg2, unsigned long, arg3,
		unsigned long, arg4, unsigned long, arg5)
linux/security/keys/compat.c:17:
COMPAT_SYSCALL_DEFINE5(keyctl, u32, option,
		       u32, arg2, u32, arg3, u32, arg4, u32, arg5)
Quoted 2 lines
Cc Eugene Syromyatnikov <[email protected]>

Thanks. Patch applied.

Cheers,

Michael

Quoted 22 lines
---
 man2/keyctl.2 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
man2/keyctl.2 +3 -3
index 9311100cf..ea3a5d3dd 100644
@@ -40,9 +40,9 @@ keyctl \- manipulate the kernel's key management facility
 .B #include <linux/keyctl.h>
 .B #include <unistd.h>
 .PP
-.BI "long syscall(__NR_keyctl, int " operation ", __kernel_ulong_t " arg2 ,
-.BI "             __kernel_ulong_t " arg3 ", __kernel_ulong_t " arg4 ,
-.BI "             __kernel_ulong_t " arg5 );
+.BI "long syscall(__NR_keyctl, int " operation ", unsigned long " arg2 ,
+.BI "             unsigned long " arg3 ", unsigned long " arg4 ,
+.BI "             unsigned long " arg5 );
 .fi
 .PP
 .IR Note :
Signature · 3 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/