net: suggest L2 discards be counted towards rx_dropped
Subsystems (2)
Jakub Kicinski
maintainerPATCH 1/1 net: suggest L2 discards be counted towards rx_dropped
From the existing definitions it's unclear which stat to use to report filtering based on L2 dst addr in old broadcast-medium Ethernet.
Signed-off-by Jakub Kicinski <[email protected]>
--- include/uapi/linux/if_link.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
include/uapi/linux/if_link.h +3 -2
@@ -75,8 +75,9 @@ struct rtnl_link_stats {* * @rx_dropped: Number of packets received but not processed, * e.g. due to lack of resources or unsupported protocol. -* For hardware interfaces this counter should not include packets -* dropped by the device which are counted separately in +* For hardware interfaces this counter may include packets discarded +* due to L2 address filtering but should not include packets dropped +* by the device due to buffer exhaustion which are counted separately in * @rx_missed_errors (since procfs folds those two counters together). * * @tx_dropped: Number of packets dropped on their way to transmission,
Signature · 1 line
2.26.2
From: Jakub Kicinski <[email protected]>
Date: Wed, 30 Dec 2020 19:37:53 -0800
Quoted 5 lines
From the existing definitions it's unclear which stat to use to report filtering based on L2 dst addr in old broadcast-medium Ethernet.
Signed-off-by Jakub Kicinski <[email protected]>
Applied.