Skip to contentSkip to conversation

net/iavf: fix GTPU UL and DL support for FDIR

PATCH Applied Junfeng Guo 3 participants 3 messages Dec 31, 2020 – Jan 6, 2021 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/iavf: fix GTPU UL and DL support for FDIR

For AVF FDIR, GTPU uplink and downlink are not supported in previous code. This patch distinguishes GTPU with IP/EH/DL/UL for AVF FDIR.

Fixes 4c7a41ae6b23 ("net/iavf: support flow director GTPU outer IPv4/IPv6")
---
 drivers/net/iavf/iavf_fdir.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
drivers/net/iavf/iavf_fdir.c +11 -1
index 4473936cb9..1b96e16546 100644
@@ -25,6 +25,9 @@
 #define IAVF_FDIR_IPV6_TC_OFFSET 20
 #define IAVF_IPV6_TC_MASK  (0xFF << IAVF_FDIR_IPV6_TC_OFFSET)
 
+#define IAVF_GTPU_EH_DWLINK 0
+#define IAVF_GTPU_EH_UPLINK 1
+
 #define IAVF_FDIR_INSET_ETH (\
 	IAVF_INSET_ETHERTYPE)
 
@@ -861,7 +864,14 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad,
 
 			hdr = &filter->add_fltr.rule_cfg.proto_hdrs.proto_hdr[layer];
 
-			VIRTCHNL_SET_PROTO_HDR_TYPE(hdr, GTPU_EH);
+			if (!gtp_psc_spec)
+				VIRTCHNL_SET_PROTO_HDR_TYPE(hdr, GTPU_EH);
+			else if ((gtp_psc_mask->qfi) && !(gtp_psc_mask->pdu_type))
+				VIRTCHNL_SET_PROTO_HDR_TYPE(hdr, GTPU_EH);
+			else if (gtp_psc_spec->pdu_type == IAVF_GTPU_EH_UPLINK)
+				VIRTCHNL_SET_PROTO_HDR_TYPE(hdr, GTPU_EH_PDU_UP);
+			else if (gtp_psc_spec->pdu_type == IAVF_GTPU_EH_DWLINK)
+				VIRTCHNL_SET_PROTO_HDR_TYPE(hdr, GTPU_EH_PDU_DWN);
 
 			if (gtp_psc_spec && gtp_psc_mask) {
 				if (gtp_psc_mask->qfi == UINT8_MAX) {
Signature · 1 line
2.25.1
Acked-by on v1 1/1 Applied
#1 lore raw
Quoted 11 lines

-----Original Message-----
From: Guo, Junfeng <[email protected]>
Sent: Thursday, December 31, 2020 1:13 PM
To: Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Cc: [email protected]; [email protected]; Yigit, Ferruh <[email protected]>; Guo, Junfeng <[email protected]>
Subject: [PATCH] net/iavf: fix GTPU UL and DL support for FDIR

Quoted 7 lines

For AVF FDIR, GTPU uplink and downlink are not supported in previous code. This patch distinguishes GTPU with IP/EH/DL/UL for AVF FDIR.

Fixes 4c7a41ae6b23 ("net/iavf: support flow director GTPU outer IPv4/IPv6")

Applied to dpdk-next-net-intel.

Thanks
Qi

Tested-by Acked-by Qi Zhang Applied
#2 lore raw

Regards,
Xu, Hailin

-----Original Message-----
From: dev <[email protected]> On Behalf Of Zhang, Qi Z
Sent: Monday, January 4, 2021 10:28 AM
To: Guo, Junfeng <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Cc: [email protected]; [email protected]; Yigit, Ferruh <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix GTPU UL and DL support for FDIR

Quoted 9 lines

-----Original Message-----
From: Guo, Junfeng <[email protected]>
Sent: Thursday, December 31, 2020 1:13 PM
To: Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Cc: [email protected]; [email protected]; Yigit, Ferruh <[email protected]>; Guo, Junfeng <[email protected]>
Subject: [PATCH] net/iavf: fix GTPU UL and DL support for FDIR

Quoted 8 lines

For AVF FDIR, GTPU uplink and downlink are not supported in previous code. This patch distinguishes GTPU with IP/EH/DL/UL for AVF FDIR.

Fixes 4c7a41ae6b23 ("net/iavf: support flow director GTPU outer

IPv4/IPv6")
Cc: [email protected]

Applied to dpdk-next-net-intel.

Thanks
Qi