Skip to contentSkip to conversation

package/libodb-mysql: fix static build

PATCH New Fabrice Fontaine 3 participants 3 messages Dec 14, 2020 – Jan 5, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libodb-mysql: fix static build

Fixes:
- http://autobuild.buildroot.org/results/ba2c5ef1bb54c2751569f79beef21ff486348469

---
 package/libodb-mysql/libodb-mysql.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libodb-mysql/libodb-mysql.mk +1 -1
index 835e5bc6bf..a9040c65f8 100644
@@ -12,6 +12,6 @@ LIBODB_MYSQL_INSTALL_STAGING = YES
 LIBODB_MYSQL_LICENSE = GPL-2.0
 LIBODB_MYSQL_LICENSE_FILES = LICENSE
 LIBODB_MYSQL_DEPENDENCIES = libodb mysql
-LIBODB_MYSQL_CONF_ENV = LIBS="$(shell $(STAGING_DIR)/usr/bin/mysql_config --libs)"
+LIBODB_MYSQL_CONF_ENV = LIBS=`$(STAGING_DIR)/usr/bin/mysql_config --libs`
 
 $(eval $(autotools-package))
Signature · 1 line
2.29.2
#1 lore raw

PATCH 1/1 package/libodb-mysql: fix static build

Quoted 7 lines · On Mon, 14 Dec 2020 22:43:13 +0100 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/ba2c5ef1bb54c2751569f79beef21ff486348469

---
 package/libodb-mysql/libodb-mysql.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks. I think this issue only appears with per-package directories, and indeed the failed configuration you're pointing has BR2_PER_PACKAGE_DIRECTORIES=y.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/libodb-mysql: fix static build

In reply to Fabrice Fontaine
Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Fixes:
- http://autobuild.buildroot.org/results/ba2c5ef1bb54c2751569f79beef21ff486348469

---
 package/libodb-mysql/libodb-mysql.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libodb-mysql/libodb-mysql.mk +0 -0
index 835e5bc6bf..a9040c65f8 100644

package/libodb-mysql/libodb-mysql.mk LIBODB_MYSQL_INSTALL_STAGING = YES · line 15

Quoted 5 lines
package/libodb-mysql/libodb-mysql.mk +1 -1
@@ -12,6 +12,6 @@ LIBODB_MYSQL_INSTALL_STAGING = YES
 LIBODB_MYSQL_LICENSE = GPL-2.0
 LIBODB_MYSQL_LICENSE_FILES = LICENSE
 LIBODB_MYSQL_DEPENDENCIES = libodb mysql
-LIBODB_MYSQL_CONF_ENV = LIBS="$(shell $(STAGING_DIR)/usr/bin/mysql_config --libs)"
+LIBODB_MYSQL_CONF_ENV = LIBS=`$(STAGING_DIR)/usr/bin/mysql_config --libs`

Committed to 2020.11.x, thanks.

I see you dropped the quotes around the output of mysql_config, is that always guaranteed to only return a single word?

Signature · 1 line
Bye, Peter Korsgaard