Skip to contentSkip to conversation

dt-bindings: mips: lantiq: Document Lantiq Xway EBU bindings

PATCH Applied Aleksander Jan Bajkowski 4 participants 4 messages Jan 1, 2021 – Jan 16, 2021

Subsystems (2)
Device tree bindings MIPS
lore
Share & tools
lore

Aleksander Jan Bajkowski

author
#0 lore raw

PATCH 1/1 dt-bindings: mips: lantiq: Document Lantiq Xway EBU bindings

Document the Lantiq Xway SoC series External Bus Unit (EBU) bindings.

Signed-off-by Aleksander Jan Bajkowski <[email protected]>
---
 .../bindings/mips/lantiq/lantiq,ebu.yaml      | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mips/lantiq/lantiq,ebu.yaml
Documentation/devicetree/bindings/mips/lantiq/lantiq,ebu.yaml new file +32 -0
new file mode 100644
index 000000000000..0fada1f085a9
@@ -0,0 +1,32 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mips/lantiq/lantiq,ebu.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Lantiq Xway SoC series External Bus Unit (EBU)
+
+maintainers:
+  - John Crispin <[email protected]>
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - lantiq,ebu-xway
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    ebu@105300 {
+        compatible = "lantiq,ebu-xway";
+        reg = <0x105300 0x100>;
+    };
Signature · 1 line
2.20.1
maintainer Applied
#2 lore raw
In reply to Aleksander Jan Bajkowski
Quoted 7 lines · Aleksander Jan Bajkowski

Document the Lantiq Xway SoC series External Bus Unit (EBU) bindings.

Signed-off-by Aleksander Jan Bajkowski <[email protected]>
---
 .../bindings/mips/lantiq/lantiq,ebu.yaml      | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mips/lantiq/lantiq,ebu.yaml

applied to mips-next.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
#3 lore raw
In reply to Aleksander Jan Bajkowski

(again, sorry for seeing this patch late)

Documentation/devicetree/bindings/mips/lantiq/lantiq,ebu.yaml line 16

Quoted 5 lines
Documentation/devicetree/bindings/mips/lantiq/lantiq,ebu.yaml new file +5 -0
+properties:
+  compatible:
+    items:
+      - enum:
+          - lantiq,ebu-xway

I think this compatible string is very generic and with that comes some problems.
There is actually two different versions of this IP: one which has support for controlling the interrupt of the PCI controller on some SoCs (Danube, xRX100, xRX200). Other SoC variants (Falcon, Amazon-SE) don't have that interrupt-controller as they don't have PCI support.

Also there is at least one clock input. I *assume* we need to describe it but I am not sure (as this platform doesn't use the common clock framework yet).

My version of this can be found here [0]. It's still sitting in my tree because it has a dependency on an ICU patch in my tree which I could not make work properly yet.

Best regards,
Martin

[0] https://github.com/xdarklight/linux/blob/8d5c632e11fe0ca14497efc2f9d99b69f75590ba/Documentation/devicetree/bindings/mips/lantiq/lantiq%2Cebu.yaml