Skip to contentSkip to conversation

efi: Don't use knowledge about efi_guid_t internals

PATCH In review Andy Shevchenko 1 participant 2 messages Oct 15, 2020 – Jan 2, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 efi: Don't use knowledge about efi_guid_t internals

When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather its internal members.

---
 security/integrity/platform_certs/efi_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
security/integrity/platform_certs/efi_parser.c +1 -1
index 18f01f36fe6a..d98260f8402a 100644
@@ -55,7 +55,7 @@ int __init parse_efi_signature_list(
 		memcpy(&list, data, sizeof(list));
 		pr_devel("LIST[%04x] guid=%pUl ls=%x hs=%x ss=%x\n",
 			 offs,
-			 list.signature_type.b, list.signature_list_size,
+			 &list.signature_type, list.signature_list_size,
 			 list.signature_header_size, list.signature_size);
 
 		lsize = list.signature_list_size;
Signature · 1 line
2.28.0
#1 lore raw
Quoted 2 lines · Andy Shevchenko

When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather its internal members.

Any comment on this?

Quoted 21 lines
---
 security/integrity/platform_certs/efi_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
security/integrity/platform_certs/efi_parser.c +1 -1
index 18f01f36fe6a..d98260f8402a 100644
@@ -55,7 +55,7 @@ int __init parse_efi_signature_list(
 		memcpy(&list, data, sizeof(list));
 		pr_devel("LIST[%04x] guid=%pUl ls=%x hs=%x ss=%x\n",
 			 offs,
-			 list.signature_type.b, list.signature_list_size,
+			 &list.signature_type, list.signature_list_size,
 			 list.signature_header_size, list.signature_size);
 
 		lsize = list.signature_list_size;
Signature · 1 line
2.28.0
Signature · 2 lines
With Best Regards,
Andy Shevchenko