Skip to contentSkip to conversation

remoteproc: qcom: pil_info: avoid 64-bit division

PATCH Applied Arnd Bergmann 3 participants 3 messages Jan 3, 2021 – May 26, 2021

Subsystems (2)
Arm Qualcomm mailing list Remote processor (remoteproc)
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 remoteproc: qcom: pil_info: avoid 64-bit division

From: Arnd Bergmann <[email protected]>

On 32-bit machines with 64-bit resource_size_t, the driver causes a link failure because of the 64-bit division:

arm-linux-gnueabi-ld: drivers/remoteproc/qcom_pil_info.o: in function `qcom_pil_info_store':
qcom_pil_info.c:(.text+0x1ec): undefined reference to `__aeabi_uldivmod'

Add a cast to an u32 to avoid this. If the resource exceeds 4GB, there are bigger problems.

Fixes 549b67da660d ("remoteproc: qcom: Introduce helper to store pil info in IMEM")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/remoteproc/qcom_pil_info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/remoteproc/qcom_pil_info.c +1 -1
index 5521c4437ffa..7c007dd7b200 100644
@@ -56,7 +56,7 @@ static int qcom_pil_info_init(void)
 	memset_io(base, 0, resource_size(&imem));
 
 	_reloc.base = base;
-	_reloc.num_entries = resource_size(&imem) / PIL_RELOC_ENTRY_SIZE;
+	_reloc.num_entries = (u32)resource_size(&imem) / PIL_RELOC_ENTRY_SIZE;
 
 	return 0;
 }
Signature · 1 line
2.29.2
CI Applied
#1 lore raw
This patch was applied to andersson/remoteproc.git (refs/heads/for-next):

Hello:

This patch was applied to andersson/remoteproc.git (refs/heads/for-next):

Quoted 9 lines · On Sun, 3 Jan 2021 14:56:12 +0100 you wrote:

From: Arnd Bergmann <[email protected]>

On 32-bit machines with 64-bit resource_size_t, the driver causes a link failure because of the 64-bit division:

arm-linux-gnueabi-ld: drivers/remoteproc/qcom_pil_info.o: in function `qcom_pil_info_store':
qcom_pil_info.c:(.text+0x1ec): undefined reference to `__aeabi_uldivmod'

[...]

Here is the summary with links:
- remoteproc: qcom: pil_info: avoid 64-bit division

    https://git.kernel.org/andersson/remoteproc/c/c101deb7d50b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

CI Applied
#2 lore raw
In reply to Arnd Bergmann
This patch was applied to qcom/linux.git (refs/heads/for-next):

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

Quoted 9 lines · On Sun, 3 Jan 2021 14:56:12 +0100 you wrote:

From: Arnd Bergmann <[email protected]>

On 32-bit machines with 64-bit resource_size_t, the driver causes a link failure because of the 64-bit division:

arm-linux-gnueabi-ld: drivers/remoteproc/qcom_pil_info.o: in function `qcom_pil_info_store':
qcom_pil_info.c:(.text+0x1ec): undefined reference to `__aeabi_uldivmod'

[...]

Here is the summary with links:
- remoteproc: qcom: pil_info: avoid 64-bit division

    https://git.kernel.org/qcom/c/7029e7830277

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html